openocd bump to 0.8.0

Signed-off-by Claudio Laurita <[email protected]>

---
 .../openocd/001-fix-gcc-warning-in-mini51.patch    |  13 ++
 package/openocd/Config.in                          | 191 +++++++++++++++++++--
 ...s-compilation-host-libsub-was-used-before.patch |  33 ----
 ...002-fix-xscale-uninitialise-breakpoint_pc.patch |  20 ---
 package/openocd/openocd-0003-force-gnu99.patch     |  19 --
 .../openocd/openocd-0004-force_jimtcl_static.patch |  25 ---
 .../openocd/openocd-0005-dont-force-ldflags.patch  |  37 ----
 package/openocd/openocd-0006-automake-compat.patch |  40 -----
 package/openocd/openocd.mk                         | 150 ++++++++++++++--

 9 files changed, 330 insertions(+), 198 deletions(-)
 create mode 100644 package/openocd/001-fix-gcc-warning-in-mini51.patch
 delete mode 100644 package/openocd/openocd-0001-fix-cross-compilation-host-libsub-was-used-before.patch
 delete mode 100644 package/openocd/openocd-0002-fix-xscale-uninitialise-breakpoint_pc.patch
 delete mode 100644 package/openocd/openocd-0003-force-gnu99.patch
 delete mode 100644 package/openocd/openocd-0004-force_jimtcl_static.patch
 delete mode 100644 package/openocd/openocd-0005-dont-force-ldflags.patch
 delete mode 100644 package/openocd/openocd-0006-automake-compat.patch

The patch is doing a lot more than just bumping the version, so it

package/openocd/001-fix-gcc-warning-in-mini51.patch

Quoted 5 lines

package/openocd/001-fix-gcc-warning-in-mini51.patch new file +0 -0

new file mode 100644!
index 0000000..514d166

Patches should have a description + Signed-off-by. See
http://buildroot.org/downloads/manual/manual.html#_format_and_licensing_of_the_package_patches.

package/openocd/001-fix-gcc-warning-in-mini51.patch

Quoted 2 lines

package/openocd/001-fix-gcc-warning-in-mini51.patch new file +1 -1

-HOST_OPENOCD_DEPENDENCIES = host-libusb-compat host-libftdi
+HOST_OPENOCD_CONF_OPTS = $(OPENOCD_CONF_OPTS)

Target options should normally not affect the build of host tools:
remember that someone can enable the host OpenOCD without building the target OpenOCD.

package/openocd/001-fix-gcc-warning-in-mini51.patch

Quoted 2 lines

package/openocd/001-fix-gcc-warning-in-mini51.patch new file +2 -0

+# force disabling shared libraries to let jimtcl build its static version
+SHARED_STATIC_LIBS_OPTS=

This is clearly not a solution: the namespace of variables in Buildroot is global, so you are not allowed to modify such a global variable. You can always force --enable-static --disable-shared in OPENOCD_CONF_OPTS if needed.

This is my first tentative of "real" collaboration, so thank you for the patience.

Quoted 1 line

The patch is doing a lot more than just bumping the version, so it

would be good to have some details about the changes that are made.

Ok, I thought it was not a lot ;-)

Quoted 5 lines

package/openocd/openocd.mk line 162

Quoted 2 lines

package/openocd/openocd.mk +1 -1

-HOST_OPENOCD_DEPENDENCIES = host-libusb-compat host-libftdi
+HOST_OPENOCD_CONF_OPTS = $(OPENOCD_CONF_OPTS)

Target options should normally not affect the build of host tools:
remember that someone can enable the host OpenOCD without building the target OpenOCD.

You're perfectly right, obviously. I made an hard shortcut ;-) I tried to find a way to avoid duplicating the logic of selecting options and finding related real dependencies. In current version it's not allowed any choice for the host and I think it's a limit. Duplicating everything is a bit redundant, but my idea was terribly based on my actual needs. I apologize.

This is a problem.
If I understand, changing this variable would affect every successive step of the global build. Is this the point? Not bad, as a mistake. I should have studied better the main makefile. Sorry. Anyway, SHARED_STATIC_LIBS_OPT is added by default to the configure

parameters. If your default is having shared preferred, It ends up in a first assignment to --enable-shared (the global) and a second one to --disable-shared (the local). Unfortunately, jimtcl ignores the second one and keeps building only the shared lib, making openocd build fail. The current BR implementation applies a patch to auto.def of jimtcl to force it ignore -enable-shared. I don't like much this approach and tried to find an alternative to avoid the patch. So, the only way is redefining OPENOCD_CONFIGURE_CMDS entirely?

Dear Claudio Laurita,

Quoted 2 lines · Claudio Laurita

This is my first tentative of "real" collaboration, so thank you for the patience.

Sure, no problem. We try to welcome contributions for everyone, and your contribution is very welcome.

Quoted 4 lines

Quoted 1 line

The patch is doing a lot more than just bumping the version, so it

would be good to have some details about the changes that are made.

Ok, I thought it was not a lot ;-)

Well, a patch doing a version bump normally is nothing but a one-liner changing the version. Here you're adding a new patch, removing many patches, adding a large number of configuration options, etc.

Quoted 11 lines

Quoted 5 lines

package/openocd/openocd.mk line 162

Quoted 2 lines

package/openocd/openocd.mk +1 -1

-HOST_OPENOCD_DEPENDENCIES = host-libusb-compat host-libftdi
+HOST_OPENOCD_CONF_OPTS = $(OPENOCD_CONF_OPTS)

Target options should normally not affect the build of host tools:
remember that someone can enable the host OpenOCD without building the target OpenOCD.

You're perfectly right, obviously. I made an hard shortcut ;-) I tried to find a way to avoid duplicating the logic of selecting options and finding related real dependencies. In current version it's not allowed any choice for the host and I think it's a limit. Duplicating everything is a bit redundant, but my idea was terribly based on my actual needs. I apologize.

We unfortunately don't really have a very good solution here. My proposal would be the following one:

* For the target version, provide many configuration options to only build what's really needed, as we need to save space on the target and build only the features that will be useful.

* For the host version, just build all the possible features (i.e support for all the JTAG interfaces, etc.). I don't think OpenOCD is that long to build, so it should be a reasonable compromise I believe.

Quoted 5 lines

This is a problem.
If I understand, changing this variable would affect every successive step of the global build. Is this the point? Not bad, as a mistake. I should have studied better the main makefile. Sorry. Anyway, SHARED_STATIC_LIBS_OPT is added by default to the configure

Quoted 8 lines

parameters. If your default is having shared preferred, It ends up in a first assignment to --enable-shared (the global) and a second one to --disable-shared (the local). Unfortunately, jimtcl ignores the second one and keeps building only the shared lib, making openocd build fail. The current BR implementation applies a patch to auto.def of jimtcl to force it ignore -enable-shared. I don't like much this approach and tried to find an alternative to avoid the patch. So, the only way is redefining OPENOCD_CONFIGURE_CMDS entirely?

Hum. I believe the easiest way is to keep the patch as is. It is really a deficiency of the OpenOCD build system to not build both the static *and* shared versions of jimctl if --enable-shared --enable-static are passed.

Thank you very much. BR is doing much for me in my everyday work. I'm trying to do something for BR. I'll do my best.

Quoted 8 lines

* For the target version, provide many configuration options to only build what's really needed, as we need to save space on the target and build only the features that will be useful.

* For the host version, just build all the possible features (i.e support for all the JTAG interfaces, etc.). I don't think OpenOCD is that long to build, so it should be a reasonable compromise I believe.

Very wise suggestion. I finally caught the basic philosophy and I like it.

I agree. OpenOCD build system is a bit "particular". But, giving the right options (from their point of view) we get the right result (from our point of view too).
So I'd not define it "buggy", just "different". A buggy thing needs patching, a different one needs flexibility. Maybe this could be the right case to use the overriding features of BR. A custom build system,

a custom configure command. It sounds logic to me. Isn't it? Anyway, it would be nice to have a way to modify the standard BR configure command, instead of replacing it totally. This is what I was looking for with my first terrific tentative. A single line solving everything (but destroying all the rest, a modest side effect for the sake of elegance). As this is a sort of exercise/challenge for me, I wasn't looking for the easiest way, but the cleanest one, or the most elegant, if you prefer. But I don't want to abuse of your time, just to learn something.

No, it's buggy: the OpenOCD build system is based on the autotools, and the autotools normally guarantee that you can do: --enable-foo --disable-foo and be sure that "foo" will be disabled. The fact that OpenOCD doesn't comply with that makes it incorrect. The reason why we don't allow to change the base options is because you never need to do
so: you can override them as I just exposed above. And the build system of OpenOCD is really buggy: if you specify --enable-shared --enable-static, it builds a shared variant of jimtcl, but OpenOCD tries to link against the static variant. This is not coherent at all.

Another option you could look at is to use the existing Buildroot jimtcl package, instead of relying on the jimtcl implementation built into OpenOCD. I've seen that OpenOCD has an option to use an external jimtcl implementation. Best regards, Thomas

I was aware of the external option, but the actual BR package script for jimtcl suffers exactly of the same problem. No patches applied there and no autotools-package called. A custom configure command and generic-package management. But no way to build a static library if --enable-shared is globally adopted.

Anyway, I collected enough information to start working on release 2. Just need some spare hours, now.

Dear Claudio Laurita,

Quoted 8 lines · Claudio Laurita

I was aware of the external option, but the actual BR package script for jimtcl suffers exactly of the same problem. No patches applied there and no autotools-package called. A custom configure command and generic-package management. But no way to build a static library if --enable-shared is globally adopted.

Anyway, I collected enough information to start working on release 2. Just need some spare hours, now.

Do you think you will have some time to work on an updated patch to bump OpenOCD to 0.8.0 ?

Thanks!

Thomas