libevent: use github call

PATCH New Maxime Hadjinlian 4 participants 10 messages Oct 12, 2014

lore

Share & tools

lore

Maxime Hadjinlian

author

2014-10-12 16:00 UTC #0 lore raw

PATCH 1/1 libevent: use github call

Add AUTORECONF as theses releases don't contains 'configure' and such.

Two patchs are added to make the autotools happy. Theses patchs are already in upstream, waiting for a new release.

---
 .../0001-Disable-building-tests-programs.patch     | 30 ++++++++++
 .../libevent/0002-Remove-usage-of-top_srcdir.patch | 64 ++++++++++++++++++++++
 .../libevent-disable-building-test-programs.patch  | 30 ----------
 package/libevent/libevent.mk                       |  4 +-
 4 files changed, 96 insertions(+), 32 deletions(-)
 create mode 100644 package/libevent/0001-Disable-building-tests-programs.patch
 create mode 100644 package/libevent/0002-Remove-usage-of-top_srcdir.patch
 delete mode 100644 package/libevent/libevent-disable-building-test-programs.patch

package/libevent/0001-Disable-building-tests-programs.patch new file +30 -0

new file mode 100644
index 0000000..65fd928
@@ -0,0 +1,30 @@
+From a4fb64af00b76600f85416471a513c89dc89d769 Mon Sep 17 00:00:00 2001
+From: Maxime Hadjinlian <[email protected]>
+Date: Sun, 12 Oct 2014 17:12:22 +0200
+Subject: [PATCH 1/2] Disable building tests programs
+
+We are not really interested in building test programs.
+Moreover, these programs use fork() function that is not available on
+MMU-less architectures.
+
+Signed-off-by: Maxime Hadjinlian <[email protected]>
+---
+ Makefile.am | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/Makefile.am b/Makefile.am
+index 42879a3..dc90359 100644
+--- a/Makefile.am
++++ b/Makefile.am
+@@ -126,7 +126,7 @@ else
+ noinst_LTLIBRARIES =  $(LIBEVENT_LIBS_LA)
+ endif
+ 
+-SUBDIRS = . include sample test
++SUBDIRS = . include sample
+ 
+ if BUILD_WIN32
+ 
+-- 
+2.1.1
+

package/libevent/0002-Remove-usage-of-top_srcdir.patch new file +64 -0

64 lines not on this page · raw message

package/libevent/libevent-disable-building-test-programs.patch deleted +0 ~~-30~~

deleted file mode 100644
index 4b0f0d9..0000000
@@ -1,30 +0,0 @@
-From e932c8864e1bb8b6a7901d4b049a1100c4becba5 Mon Sep 17 00:00:00 2001
-From: Gilles Talis <[email protected]>
-Date: Fri, 21 Jun 2013 15:25:11 -0700
-Subject: [PATCH] Disable building test programs
-
-We are not really interested in building test programs.
-Moreover, these programs use fork() function that is
-not available on MMU-less architectures.
-
-Signed-off-by: Gilles Talis <[email protected]>
----
- Makefile.in |    2 +-
- 1 files changed, 1 insertions(+), 1 deletions(-)
-
-diff --git a/Makefile.in b/Makefile.in
-index 2ebefa2..4fba1ff 100644
---- a/Makefile.in
-+++ b/Makefile.in
-@@ -487,7 +487,7 @@ LIBEVENT_LIBS_LA = libevent.la libevent_core.la libevent_extra.la \
- @INSTALL_LIBEVENT_TRUE at lib_LTLIBRARIES = $(LIBEVENT_LIBS_LA)
- @INSTALL_LIBEVENT_TRUE at pkgconfig_DATA = $(LIBEVENT_PKGCONFIG)
- @INSTALL_LIBEVENT_FALSE at noinst_LTLIBRARIES = $(LIBEVENT_LIBS_LA)
--SUBDIRS = . include sample test
-+SUBDIRS = . include sample
- @BUILD_WIN32_FALSE at SYS_LIBS = 
- @BUILD_WIN32_TRUE at SYS_LIBS = -lws2_32 -lshell32 -ladvapi32
- @BUILD_WIN32_FALSE at SYS_SRC = $(am__append_5) $(am__append_6) \
--- 
-1.7.4.1
-

package/libevent/libevent.mk +2 -2

index 73be502..fbc7c54 100644
@@ -5,11 +5,11 @@
 ################################################################################
 
 LIBEVENT_VERSION = 2.0.21
-LIBEVENT_SOURCE = libevent-$(LIBEVENT_VERSION)-stable.tar.gz
-LIBEVENT_SITE = https://github.com/downloads/libevent/libevent
+LIBEVENT_SITE = $(call github,libevent,libevent,release-$(LIBEVENT_VERSION)-stable)
 LIBEVENT_INSTALL_STAGING = YES
 LIBEVENT_LICENSE = BSD-3c, OpenBSD
 LIBEVENT_LICENSE_FILES = LICENSE
+LIBEVENT_AUTORECONF = YES
 
 define LIBEVENT_REMOVE_PYSCRIPT
 	rm $(TARGET_DIR)/usr/bin/event_rpcgen.py

Signature · 1 line

2.1.1

Yann E. MORIN

2014-10-12 16:08 UTC #1 lore raw

PATCH 1/1 libevent: use github call

Maxime, All,

On 2014-10-12 18:00 +0200, Maxime Hadjinlian spake thusly:
[--SNIP--]

package/libevent/0002-Remove-usage-of-top_srcdir.patch line 6

Quoted 12 lines

package/libevent/0002-Remove-usage-of-top_srcdir.patch new file +6 -0

new file mode 100644
index 0000000..34c90f0
@@ -0,0 +1,64 @@
+From 8fe87a7dd2179ae6a3697af5c2a43143adba3c82 Mon Sep 17 00:00:00 2001
+From: Maxime Hadjinlian <[email protected]>
+Date: Sun, 12 Oct 2014 17:41:41 +0200
+Subject: [PATCH 2/2] Remove usage of top_srcdir
+
+This is already upstream, waiting for a release.

For an upstream patch, we like yto have an URL pointing to the upstream commit or mailing-post about it.

[--SNIP--]

Quoted 5 lines

package/libevent/libevent.mk +0 -0
index 73be502..fbc7c54 100644

package/libevent/libevent.mk line 12

Quoted 10 lines

package/libevent/libevent.mk +2 -2

@@ -5,11 +5,11 @@
 ################################################################################
 
 LIBEVENT_VERSION = 2.0.21
-LIBEVENT_SOURCE = libevent-$(LIBEVENT_VERSION)-stable.tar.gz
-LIBEVENT_SITE = https://github.com/downloads/libevent/libevent
+LIBEVENT_SITE = $(call github,libevent,libevent,release-$(LIBEVENT_VERSION)-stable)
 LIBEVENT_INSTALL_STAGING = YES
 LIBEVENT_LICENSE = BSD-3c, OpenBSD
 LIBEVENT_LICENSE_FILES = LICENSE
+LIBEVENT_AUTORECONF = YES

Please, add a small comment why we autoreconf:
# Straight from the repository, need to generate autotools files

Regards,
Yann E. MORIN.

Signature · 6 lines

.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

Thomas Petazzoni

2014-10-12 16:17 UTC #2 lore raw

PATCH 1/1 libevent: use github call

In reply to Maxime Hadjinlian

Dear Maxime Hadjinlian,

Sorry, but the title of your patch is wrong: it does *much* more than use the github call.

The title of the commit should summarize the entirety of the patch, and then the rest of the description should go in the details of what the patch does.

Quoted 5 lines · Maxime Hadjinlian

Add AUTORECONF as theses releases don't contains 'configure' and such.
Two patchs are added to make the autotools happy. Theses patchs are already in upstream, waiting for a new release.

Missing SoB line.

Quoted 6 lines

package/libevent/0001-Disable-building-tests-programs.patch new file +0 -0
new file mode 100644
index 0000000..65fd928

package/libevent/0001-Disable-building-tests-programs.patch line 10

Quoted 10 lines

package/libevent/0001-Disable-building-tests-programs.patch new file +10 -0

@@ -0,0 +1,30 @@
+From a4fb64af00b76600f85416471a513c89dc89d769 Mon Sep 17 00:00:00 2001
+From: Maxime Hadjinlian <[email protected]>
+Date: Sun, 12 Oct 2014 17:12:22 +0200
+Subject: [PATCH 1/2] Disable building tests programs
+
+We are not really interested in building test programs.
+Moreover, these programs use fork() function that is not available on
+MMU-less architectures.
+
+Signed-off-by: Maxime Hadjinlian <[email protected]>

You are not the author of this patch, it was written by Gilles Tallis.

Please use git format-patch -M to enable rename detection so we see that it's actually the other patch that has only be changed slightly and renamed.

package/libevent/0001-Disable-building-tests-programs.patch

Quoted 8 lines

package/libevent/0001-Disable-building-tests-programs.patch new file +2 -2

 LIBEVENT_VERSION = 2.0.21
-LIBEVENT_SOURCE = libevent-$(LIBEVENT_VERSION)-stable.tar.gz
-LIBEVENT_SITE = https://github.com/downloads/libevent/libevent
+LIBEVENT_SITE = $(call github,libevent,libevent,release-$(LIBEVENT_VERSION)-stable)
 LIBEVENT_INSTALL_STAGING = YES
 LIBEVENT_LICENSE = BSD-3c, OpenBSD
 LIBEVENT_LICENSE_FILES = LICENSE
+LIBEVENT_AUTORECONF = YES

Why use the github function when a tarball is provided?

Sorry, but patch unclear.

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Maxime Hadjinlian

author

2014-10-12 16:30 UTC #3 lore raw

PATCH 1/1 libevent: use github call

Hi all

Quoted 8 lines · Thomas Petazzoni

Dear Maxime Hadjinlian,
Sorry, but the title of your patch is wrong: it does *much* more than use the github call.
The title of the commit should summarize the entirety of the patch, and then the rest of the description should go in the details of what the patch does.

Yes, forgot to amend my commit.

Quoted 20 lines · Maxime Hadjinlian

Quoted 5 lines
Add AUTORECONF as theses releases don't contains 'configure' and such.
Two patchs are added to make the autotools happy. Theses patchs are already in upstream, waiting for a new release.
Missing SoB line.
Quoted 10 lines
package/libevent/0001-Disable-building-tests-programs.patch new file +4 -0
new file mode 100644
index 0000000..65fd928
@@ -0,0 +1,30 @@
+From a4fb64af00b76600f85416471a513c89dc89d769 Mon Sep 17 00:00:00 2001
+From: Maxime Hadjinlian <[email protected]>
+Date: Sun, 12 Oct 2014 17:12:22 +0200
+Subject: [PATCH 1/2] Disable building tests programs

Quoted 8 lines

package/libevent/0001-Disable-building-tests-programs.patch line 10
Quoted 6 lines
package/libevent/0001-Disable-building-tests-programs.patch new file +6 -0
+
+We are not really interested in building test programs.
+Moreover, these programs use fork() function that is not available on
+MMU-less architectures.
+
+Signed-off-by: Maxime Hadjinlian <[email protected]>
You are not the author of this patch, it was written by Gilles Tallis.

Sorry about that, some git am/rebase going awry. Will fix right away.

Quoted 5 lines

Please use git format-patch -M to enable rename detection so we see that it's actually the other patch that has only be changed slightly and renamed.

Quoted 10 lines

package/libevent/0001-Disable-building-tests-programs.patch
Quoted 8 lines
package/libevent/0001-Disable-building-tests-programs.patch new file +2 -2
 LIBEVENT_VERSION = 2.0.21
-LIBEVENT_SOURCE = libevent-$(LIBEVENT_VERSION)-stable.tar.gz
-LIBEVENT_SITE = https://github.com/downloads/libevent/libevent
+LIBEVENT_SITE = $(call github,libevent,libevent,release-$(LIBEVENT_VERSION)-stable)
 LIBEVENT_INSTALL_STAGING = YES
 LIBEVENT_LICENSE = BSD-3c, OpenBSD
 LIBEVENT_LICENSE_FILES = LICENSE
+LIBEVENT_AUTORECONF = YES
Why use the github function when a tarball is provided?

Only because we were using the github repository before, but we could uses the tarball from the servers ? I don't know which is prefered ?

Quoted 2 lines

Sorry, but patch unclear.

I'll respin right away.

Quoted 6 lines

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Thomas Petazzoni

2014-10-12 16:46 UTC #4 lore raw

PATCH 1/1 libevent: use github call

Dear Maxime Hadjinlian,

Quoted 3 lines · Maxime Hadjinlian

Quoted 1 line
Why use the github function when a tarball is provided?
Only because we were using the github repository before, but we could uses the tarball from the servers ? I don't know which is prefered ?

My personal point of view is that if there's a tarball, then we should use it. Don't know if that opinion is shared by the community as a whole, please ask right now during the meeting :-)

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Samuel Martin

2014-10-12 16:58 UTC #5 lore raw

PATCH 1/1 libevent: use github call

Hi Maxime, Thomas, all,

Quoted 11 lines · Thomas Petazzoni

Dear Maxime Hadjinlian,
Quoted 3 lines · Maxime Hadjinlian
Quoted 1 line
Why use the github function when a tarball is provided?
Only because we were using the github repository before, but we could uses the tarball from the servers ? I don't know which is prefered ?
My personal point of view is that if there's a tarball, then we should use it. Don't know if that opinion is shared by the community as a whole, please ask right now during the meeting :-)

I agree.

Quoted 10 lines

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Signature · 1 line

Samuel

Maxime Hadjinlian

author

2014-10-12 17:06 UTC #6 lore raw

PATCH 1/1 libevent: use github call

Quoted 9 lines · Samuel Martin

Hi Maxime, Thomas, all,
Quoted 5 lines · Thomas Petazzoni
Dear Maxime Hadjinlian,
Quoted 1 line · Maxime Hadjinlian
Quoted 1 line
Why use the github function when a tarball is provided?

Quoted 8 lines

Quoted 6 lines
Quoted 2 lines
Only because we were using the github repository before, but we could uses the tarball from the servers ? I don't know which is prefered ?
My personal point of view is that if there's a tarball, then we should use it. Don't know if that opinion is shared by the community as a whole, please ask right now during the meeting :-)
I agree.

It seems that the tarball available on the website, is the tarball generated by github from the tag.

Quoted 16 lines

Quoted 11 lines
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
--
Samuel

Thomas Petazzoni

2014-10-12 17:08 UTC #7 lore raw

PATCH 1/1 libevent: use github call

Dear Maxime Hadjinlian,

Quoted 7 lines · Maxime Hadjinlian

Quoted 5 lines
Quoted 3 lines
My personal point of view is that if there's a tarball, then we should use it. Don't know if that opinion is shared by the community as a whole, please ask right now during the meeting :-)
I agree.
It seems that the tarball available on the website, is the tarball generated by github from the tag.

Yes, and?

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Maxime Hadjinlian

author

2014-10-12 17:22 UTC #8 lore raw

PATCH 1/1 libevent: use github call

Quoted 8 lines · Thomas Petazzoni

Dear Maxime Hadjinlian,
Quoted 4 lines · Maxime Hadjinlian
Quoted 4 lines
Quoted 3 lines
My personal point of view is that if there's a tarball, then we should use it. Don't know if that opinion is shared by the community as a whole, please ask right now during the meeting :-)

Quoted 5 lines

Quoted 3 lines
Quoted 1 line
I agree.
It seems that the tarball available on the website, is the tarball generated by github from the tag.
Yes, and?

To put everything cleary in a mail:

When a maintainer do a release from github, there's two possibilities:
Either you don't upload a file, then the tarball you download is generated from the tag.

Or you upload a file, and then the tarball, is *NOT* generated, it's the file that you uploaded.

Since the hepers, will call the http URL of github (and not doing a git clone), for me the github helper is used for any generated tarball.
*BUT* if the releases is a manually uploaded file, then we have to uses the http link and not the helper. I'd recommend to put a comments on each one theses cases.

In the case of libevent, the link from the website points to the release on github, which is a generated tarball, not an uploaded one. So the uses of the helper is perfectly fine here.

Hope I gave enough details here, maybe this should be put in the manual ? Don't know if it's really usefull.

Quoted 6 lines

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Thomas Petazzoni

2014-10-12 17:25 UTC #9 lore raw

PATCH 1/1 libevent: use github call

Dear Maxime Hadjinlian,

Quoted 16 lines · Maxime Hadjinlian

To put everything cleary in a mail:
When a maintainer do a release from github, there's two possibilities:
Either you don't upload a file, then the tarball you download is generated from the tag.
Or you upload a file, and then the tarball, is *NOT* generated, it's the file that you uploaded.
Since the hepers, will call the http URL of github (and not doing a git clone), for me the github helper is used for any generated tarball.
*BUT* if the releases is a manually uploaded file, then we have to uses the http link and not the helper. I'd recommend to put a comments on each one theses cases.

Quoted 6 lines

In the case of libevent, the link from the website points to the release on github, which is a generated tarball, not an uploaded one. So the uses of the helper is perfectly fine here.
Hope I gave enough details here, maybe this should be put in the manual ? Don't know if it's really usefull.

Makes sense, especially when you add the information that the github helper doesn't provide a git URL that will lead to a git clone, but a http URL that will lead to wget-ing a tarball.

So, fine with using the github helper here.

Thanks,

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com