Skip to contentSkip to conversation

WTF is d_add_ci() doing with negative dentries?

DISCUSSION Al Viro 2 participants 4 messages Oct 12, 2014 – Oct 13, 2014 VFS

lore
Share & tools
lore

Al Viro

author maintainer
#0 lore raw

AFAICS, if d_add_ci() ever finds a negative hashed dentry for
exact name, it's already buggered. Because right *before* that d_add_ci() lookup for exact name would've turned valid negative. IOW, the whole thing ought to be

        found = d_hash_and_lookup(dentry->d_parent, name);
	if (found) {
		iput(inode);
		return found;
	}
	new = d_alloc(dentry->d_parent, name);
	if (!new) {
		iput(inode);
		return ERR_PTR(-ENOMEM);
	}
	found = d_splice_alias(inode, new);
	if (found) {
		dput(new);
		return found;
	}
	return new;

Moreover, it might very well be better to pass dentry->d_parent instead of dentry... Objections?

#1 lore raw

Hi Al,

Quoted 3 lines · Al Viro

AFAICS, if d_add_ci() ever finds a negative hashed dentry for
exact name, it's already buggered. Because right *before* that d_add_ci() lookup for exact name would've turned valid negative.

Christoph copied d_add_ci() from code I wrote for NTFS so you can blame me for it. (-;

Do you mean that given the exact name exists on disk, there cannot be a negative dentry for it in memory, i.e. there would either be no dentry in memory or it would be a positive dentry in memory?

If so then that makes sense, yes.

I am just wondering whether there might be error conditions in which we might end up with a (perhaps invalid) negative dentry in memory which could be found here? Probably not a problem especially now that d_invalidate() cannot fail any more.

Is it worth adding a BUG_ON(!found->d_inode); to ensure sanity/catch bugs?

Quoted 17 lines

IOW, the whole thing ought to be

       found = d_hash_and_lookup(dentry->d_parent, name);
	if (found) {
		iput(inode);
		return found;
	}
	new = d_alloc(dentry->d_parent, name);
	if (!new) {
		iput(inode);
		return ERR_PTR(-ENOMEM);
	}
	found = d_splice_alias(inode, new);
	if (found) {
		dput(new);
		return found;
	}
	return new;
Quoted 2 lines

Moreover, it might very well be better to pass dentry->d_parent instead of dentry... Objections?

Yes, that bit makes perfect sense given we only ever use dentry->d_parent.

Best regards,

Anton

Signature · 3 lines
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
University of Cambridge Information Services, Roger Needham Building
7 JJ Thomson Avenue, Cambridge, CB3 0RB, UK
author maintainer
#2 lore raw
Quoted 1 line · Anton Altaparmakov

I am just wondering whether there might be error conditions in which we might end up with a (perhaps invalid) negative dentry in memory which could be found here? Probably not a problem especially now that d_invalidate() cannot fail any more.

Huh? Failing d_invalidate() on _negative_ dentry is flat-out impossible; it would be dropped just fine, and we wouldn't have found it in the first place. Check what it used to do all way back to 2.2.0:

        if (dentry->d_count) {
                if (dentry->d_inode && S_ISDIR(dentry->d_inode->i_mode))
                        return -EBUSY;
        }

So unless you care about 2.1.something (2.0 didn't have dcache at all), this scenario isn't possible.

In any case, d_add_ci() users that might have negative dentries become positive cannot afford hashed negative dentries at all - at the very least they need to treat them as invalid in ->d_revalidate() in such situations. Exactly because having a hashed valid negative dentry for FuBaR after e.g. mkdir fubar will really hurt - mkdir won't have any way to know that old dentry was there; there was no variant of fubar in directory prior to that mkdir (FuBaR _was_ negative) and there's nothing to suggest looking for it. So it won't be noticed and it'll bloody well stay negative and hashed. I.e. stat FuBaR; mkdir fubar; stat FuBaR will have the second stat find dentry still hashed and valid negative.

You can get away with that if you store something like timestamp[1] of the parent directory in those negative dentries and check that in ->d_revalidate(). But that will work just fine, since d_add_ci() is serialized by ->i_mutex held on parent and whatever it was that added your "exact spelling" into directory has made all preexisting negative dentries invalid...

[1] for arbitrary values of time - e.g.

	on positive lookup set ->d_time to 0
	on negative lookup set ->d_time to that of parent dentry
	on mkdir set ->d_time to 0
	on unlink, rmdir and rename victim copy ->d_time from parent dentry
	on any directory modification bump its ->d_time
	on d_revalidate of negative dentry compare ->d_time with that of parent
	dentry and declare invalid on mismatch

will do just fine.

#3 lore raw

Hi Al,

Quoted 6 lines · Al Viro
Quoted 1 line · Anton Altaparmakov

I am just wondering whether there might be error conditions in which we might end up with a (perhaps invalid) negative dentry in memory which could be found here? Probably not a problem especially now that d_invalidate() cannot fail any more.

Huh? Failing d_invalidate() on _negative_ dentry is flat-out impossible; it would be dropped just fine, and we wouldn't have found it in the first place. Check what it used to do all way back to 2.2.0:

Quoted 7 lines
       if (dentry->d_count) {
               if (dentry->d_inode && S_ISDIR(dentry->d_inode->i_mode))
                       return -EBUSY;
       }

So unless you care about 2.1.something (2.0 didn't have dcache at all), this scenario isn't possible.

That's fine then. And no I don't care about 2.1. I start caring at 2.6.15 at the moment.

Quoted 4 lines

In any case, d_add_ci() users that might have negative dentries become positive cannot afford hashed negative dentries at all - at the very least they need to treat them as invalid in ->d_revalidate() in such situations.

Yes, that is what I do. I have my own d_revalidate method which reports all negative dentries as invalid any time a new name is added in the parent directory. In fact I set d_time of each dentry to i_version of the parent directory inode and on each "add name to directory" I bump i_version of the parent directory and d_revalidate checks d_time against d_parent->d_inode->i_version and if not equal the negative dentry is considered invalid and that seems to work fine (I ignore d_time on positive dentries in d_revalidate).

Quoted 8 lines

Exactly because having a hashed valid negative dentry for
FuBaR after e.g. mkdir fubar will really hurt - mkdir won't have any way to know that old dentry was there; there was no variant of fubar in directory prior to that mkdir (FuBaR _was_ negative) and there's nothing to suggest looking for it. So it won't be noticed and it'll bloody well stay negative and hashed. I.e. stat FuBaR; mkdir fubar; stat FuBaR will have the second stat find dentry still hashed and valid negative.

Quoted 6 lines

You can get away with that if you store something like timestamp[1] of the parent directory in those negative dentries and check that in ->d_revalidate(). But that will work just fine, since d_add_ci() is serialized by ->i_mutex held on parent and whatever it was that added your "exact spelling" into directory has made all preexisting negative dentries invalid...

Yes, that is basically what I do except I use i_version on the parent rather than its d_time and I don't set d_time to zero (I always set it to i_version of parent instead though I doubt it matters in the slightest - I could equally not be setting it at all for positive dentries given I never check it for them).

Best regards,

Anton

Quoted 9 lines

[1] for arbitrary values of time - e.g.

	on positive lookup set ->d_time to 0
	on negative lookup set ->d_time to that of parent dentry
	on mkdir set ->d_time to 0
	on unlink, rmdir and rename victim copy ->d_time from parent dentry
	on any directory modification bump its ->d_time
	on d_revalidate of negative dentry compare ->d_time with that of parent
	dentry and declare invalid on mismatch

will do just fine.

Signature · 3 lines
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
University of Cambridge Information Services, Roger Needham Building
7 JJ Thomson Avenue, Cambridge, CB3 0RB, UK