Skip to contentSkip to conversation

sunxi: axp152: dcdc3 scale is 50mV / step

PATCH New Hans de Goede 2 participants 3 messages Oct 13, 2014 X-powers multifunction PMIC device drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sunxi: axp152: dcdc3 scale is 50mV / step

Hi Tom,

Here is a last minute fix for v2014.10 to fix the axp152 code setting the DRAM voltage way too high on some sunxi boards (2.3V instead of 1.5V).

I hope this can still make v2014.10, if not it is not too bad as most boards use the axp209, not the axp152, and the axp152 boards I've seem to work fine even with the 2.3V DRAM setting.

Regards,

Hans

#1 lore raw

PATCH 1/1 sunxi: axp152: dcdc3 scale is 50mV / step not 25mV / step

Currently uboot wrongly uses 25mV / step for dcdc3, this is a copy and paste error introduced when adding the axp152_mvolt_to_target during review of the axp152.c driver. This results in u-boot setting Vddr to 2.3V instead of 1.5V.

This commit fixes this.

---
 drivers/power/axp152.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/power/axp152.c +1 -1
index fa4ea05..27c2c4c 100644
@@ -62,7 +62,7 @@ int axp152_set_dcdc2(int mvolt)
 
 int axp152_set_dcdc3(int mvolt)
 {
-	u8 target = axp152_mvolt_to_target(mvolt, 700, 3500, 25);
+	u8 target = axp152_mvolt_to_target(mvolt, 700, 3500, 50);
 
 	return axp152_write(AXP152_DCDC3_VOLTAGE, target);
 }
Signature · 1 line
2.1.0
#2 lore raw

PATCH 1/1 sunxi: axp152: dcdc3 scale is 50mV / step not 25mV / step

Quoted 7 lines · Hans de Goede

Currently uboot wrongly uses 25mV / step for dcdc3, this is a copy and paste error introduced when adding the axp152_mvolt_to_target during review of the axp152.c driver. This results in u-boot setting Vddr to 2.3V instead of 1.5V.

This commit fixes this.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141013/4b6a048d/attachment.pgp>