dm: serial: Fix breakage due to stdio changes

PATCH New Simon Glass 2 participants 5 messages Oct 10, 2014 – Oct 14, 2014

lore

Share & tools

lore

Simon Glass

author

2014-10-10 03:06 UTC #0 lore raw

PATCH 1/1 dm: serial: Fix breakage due to stdio changes

Commit 32d0192 broke the sandbox build - fix it.

Signed-off-by Simon Glass <[email protected]>

---

 drivers/serial/serial-uclass.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/serial/serial-uclass.c +1 -1

index fd010ca..6dde4ea 100644
@@ -198,7 +198,7 @@ static int serial_pre_remove(struct udevice *dev)
 #ifdef CONFIG_SYS_STDIO_DEREGISTER
 	struct serial_dev_priv *upriv = dev->uclass_priv;
 
-	if (stdio_deregister_dev(upriv->sdev), 0)
+	if (stdio_deregister_dev(upriv->sdev, 0))
 		return -EPERM;
 #endif

Signature · 1 line

2.1.0.rc2.206.gedb03e5

Simon Glass

author

2014-10-14 07:34 UTC #1 lore raw

PATCH 1/1 dm: serial: Fix breakage due to stdio changes

Hi Tom,

Quoted 13 lines · Simon Glass

Commit 32d0192 broke the sandbox build - fix it.
Signed-off-by Simon Glass <[email protected]>
---
 drivers/serial/serial-uclass.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/serial/serial-uclass.c +0 -0
index fd010ca..6dde4ea 100644

drivers/serial/serial-uclass.c static int serial_pre_remove(struct udevice *dev) · line 203

Quoted 7 lines

drivers/serial/serial-uclass.c +1 -1

@@ -198,7 +198,7 @@ static int serial_pre_remove(struct udevice *dev)
 #ifdef CONFIG_SYS_STDIO_DEREGISTER
        struct serial_dev_priv *upriv = dev->uclass_priv;
 
-       if (stdio_deregister_dev(upriv->sdev), 0)
+       if (stdio_deregister_dev(upriv->sdev, 0))
                return -EPERM;
 #endif

Can you please pick up this one?

Regards,
Simon

Tom Rini

2014-10-14 08:48 UTC #2 lore raw

PATCH 1/1 dm: serial: Fix breakage due to stdio changes

Quoted 19 lines · Simon Glass

Hi Tom,
Quoted 16 lines · Simon Glass
Commit 32d0192 broke the sandbox build - fix it.
Signed-off-by Simon Glass <[email protected]>
---
 drivers/serial/serial-uclass.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/serial/serial-uclass.c +0 -0
index fd010ca..6dde4ea 100644
@@ -198,7 +198,7 @@ static int serial_pre_remove(struct udevice *dev)
 #ifdef CONFIG_SYS_STDIO_DEREGISTER
        struct serial_dev_priv *upriv = dev->uclass_priv;
 

Quoted 6 lines

drivers/serial/serial-uclass.c static int serial_pre_remove(struct udevice *dev) · line 203
Quoted 4 lines
drivers/serial/serial-uclass.c +1 -1
-       if (stdio_deregister_dev(upriv->sdev), 0)
+       if (stdio_deregister_dev(upriv->sdev, 0))
                return -EPERM;
 #endif
Can you please pick up this one?

Arg, I thought I had already grabbed this one, sorry.

Signature · 8 lines

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141014/69512b9e/attachment.pgp>

Tom Rini

2014-10-14 08:50 UTC #3 lore raw

PATCH 1/1 dm: serial: Fix breakage due to stdio changes

In reply to Simon Glass

Quoted 19 lines · Simon Glass

Hi Tom,
Quoted 16 lines · Simon Glass
Commit 32d0192 broke the sandbox build - fix it.
Signed-off-by Simon Glass <[email protected]>
---
 drivers/serial/serial-uclass.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/serial/serial-uclass.c +0 -0
index fd010ca..6dde4ea 100644
@@ -198,7 +198,7 @@ static int serial_pre_remove(struct udevice *dev)
 #ifdef CONFIG_SYS_STDIO_DEREGISTER
        struct serial_dev_priv *upriv = dev->uclass_priv;
 

Quoted 6 lines

drivers/serial/serial-uclass.c static int serial_pre_remove(struct udevice *dev) · line 203
Quoted 4 lines
drivers/serial/serial-uclass.c +1 -1
-       if (stdio_deregister_dev(upriv->sdev), 0)
+       if (stdio_deregister_dev(upriv->sdev, 0))
                return -EPERM;
 #endif
Can you please pick up this one?

Ah, wait!

Author: Hans de Goede <[email protected]>
Date:   Fri Oct 10 18:30:17 2014 +0200

serial-uclass: Fix compilation error

Signed-off-by Hans de Goede <[email protected]>

So we're good to go still.

Signature · 8 lines

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141014/4b2d903a/attachment.pgp>

Simon Glass

author

2014-10-14 09:48 UTC #4 lore raw

PATCH 1/1 dm: serial: Fix breakage due to stdio changes

Hi Tom,

Quoted 28 lines · Tom Rini

Quoted 19 lines · Simon Glass
Hi Tom,
Quoted 16 lines · Simon Glass
Commit 32d0192 broke the sandbox build - fix it.
Signed-off-by Simon Glass <[email protected]>
---
 drivers/serial/serial-uclass.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/serial/serial-uclass.c +0 -0
index fd010ca..6dde4ea 100644
@@ -198,7 +198,7 @@ static int serial_pre_remove(struct udevice *dev)
 #ifdef CONFIG_SYS_STDIO_DEREGISTER
        struct serial_dev_priv *upriv = dev->uclass_priv;
 
Quoted 6 lines
drivers/serial/serial-uclass.c static int serial_pre_remove(struct udevice *dev) · line 203
Quoted 4 lines
drivers/serial/serial-uclass.c +1 -1
-       if (stdio_deregister_dev(upriv->sdev), 0)
+       if (stdio_deregister_dev(upriv->sdev, 0))
                return -EPERM;
 #endif
Can you please pick up this one?
Ah, wait!

Quoted 8 lines

Author: Hans de Goede <[email protected]>
Date:   Fri Oct 10 18:30:17 2014 +0200
serial-uclass: Fix compilation error
Signed-off-by Hans de Goede <[email protected]>
So we're good to go still.

Thanks, sorry I missed that.

Regards,
Simon