PCI: imx6q-pcie doc: Update the clocks descriptions to use defines
Subsystems (4)
Fabio Estevam
reviewerPATCH 1/1 PCI: imx6q-pcie doc: Update the clocks descriptions to use defines
From: Fabio Estevam <[email protected]>
Let's make the imx6q-pcie example to actually match the usage on imx6qdl.dtsi by providing the clock names via defines rather than hardcoded numbers.
--- Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt +3 -1
@@ -35,6 +35,8 @@ Example: <0 0 0 2 &intc GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>, <0 0 0 3 &intc GIC_SPI 121 IRQ_TYPE_LEVEL_HIGH>, <0 0 0 4 &intc GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>; - clocks = <&clks 144>, <&clks 206>, <&clks 189>; + clocks = <&clks IMX6QDL_CLK_PCIE_AXI>, + <&clks IMX6QDL_CLK_LVDS1_GATE>, + <&clks IMX6QDL_CLK_PCIE_REF_125M>; clock-names = "pcie", "pcie_bus", "pcie_phy"; };
Signature · 1 line
1.9.1
Bjorn Helgaas
maintainerPATCH 1/1 PCI: imx6q-pcie doc: Update the clocks descriptions to use defines
[+cc Rob, Arnd, linux-arm-kernel]
Quoted 6 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Let's make the imx6q-pcie example to actually match the usage on
imx6qdl.dtsiby providing the clock names via defines rather than hardcoded numbers.Signed-off-by Fabio Estevam <[email protected]>
Is this an arm-soc thing?
If you want me to take it, I'll wait for an ack from the likes of Richard/Lucas/Rob/Arnd since I can't review this myself.
Quoted 21 lines
--- Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt +3
-1@@ -35,6 +35,8 @@ Example: <0 0 0 2 &intc GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>, <0 0 0 3 &intc GIC_SPI 121 IRQ_TYPE_LEVEL_HIGH>, <0 0 0 4 &intc GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>; - clocks = <&clks 144>, <&clks 206>, <&clks 189>; + clocks = <&clks IMX6QDL_CLK_PCIE_AXI>, + <&clks IMX6QDL_CLK_LVDS1_GATE>, + <&clks IMX6QDL_CLK_PCIE_REF_125M>; clock-names = "pcie", "pcie_bus", "pcie_phy"; };Signature · 1 line
1.9.1
PATCH 1/1 PCI: imx6q-pcie doc: Update the clocks descriptions to use defines
Quoted 18 lines
-----Original Message-----
From: Bjorn Helgaas [mailto:bhelgaas at google.com]
Sent: Wednesday, October 15, 2014 8:18 AM
To: Fabio Estevam
Cc: l.stach at pengutronix.de; Zhu Richard-R65037; linux-pci at vger.kernel.org; Estevam Fabio-R49496; Zhu Richard-R65037; Rob Herring; Arnd Bergmann; linux- arm-kernel at lists.infradead.org
Subject: Re: [PATCH] PCI: imx6q-pcie doc: Update the clocks descriptions to use defines[+cc Rob, Arnd, linux-arm-kernel]
Quoted 4 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Let's make the imx6q-pcie example to actually match the usage on
imx6qdl.dtsiby providing the clock names via defines rather than hardcoded
Quoted 9 lines
numbers.
Quoted 2 lines
Signed-off-by Fabio Estevam <[email protected]>Is this an arm-soc thing?
If you want me to take it, I'll wait for an ack from the likes of Richard/Lucas/Rob/Arnd since I can't review this myself.
Hi Bjorn:
yes, this should be an arm-soc stuff.
Hi Fabio:
The prefix of this patch should be ARM: xxxx, and reviewed/merged by shawn.
Best Regards
Richard Zhu
Quoted 22 lines
Quoted 22 lines
--- Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt +3
-2@@ -35,6 +35,8 @@ Example: <0 0 0 2 &intc GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>, <0 0 0 3 &intc GIC_SPI 121 IRQ_TYPE_LEVEL_HIGH>, <0 0 0 4 &intc GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>; - clocks = <&clks 144>, <&clks 206>, <&clks 189>; + clocks = <&clks IMX6QDL_CLK_PCIE_AXI>, + <&clks IMX6QDL_CLK_LVDS1_GATE>, + <&clks IMX6QDL_CLK_PCIE_REF_125M>; clock-names = "pcie", "pcie_bus", "pcie_phy"; }; --1.9.1