Skip to contentSkip to conversation

qat: cleanup unnecessary break checkpatch warning

PATCH Applied Bruce Allan 2 participants 2 messages Oct 15, 2014 – Oct 24, 2014 Crypto API

lore
Share & tools
lore

Bruce Allan

author
#0 lore raw

PATCH 1/1 qat: cleanup unnecessary break checkpatch warning

WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return #472: FILE: drivers/crypto/qat/qat_common/qat_algs.c:472:
+ goto bad_key;
+ break;

Signed-off-by Bruce Allan <[email protected]>

---

 drivers/crypto/qat/qat_common/qat_algs.c |    1 -
 1 file changed, 1 deletion(-)
drivers/crypto/qat/qat_common/qat_algs.c +0 -1
index 3e26fa2..e03afe9 100644
@@ -469,7 +469,6 @@ static int qat_alg_init_sessions(struct qat_alg_session_ctx *ctx,
 		break;
 	default:
 		goto bad_key;
-		break;
 	}
 
 	if (qat_alg_init_enc_session(ctx, alg, &keys))
maintainer Applied
#1 lore raw
Quoted 6 lines · Bruce Allan

WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return #472: FILE: drivers/crypto/qat/qat_common/qat_algs.c:472:

(quoted diff) +2 -0
+               goto bad_key;
+               break;
Signed-off-by Bruce Allan <[email protected]>

Applied.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt