ARM: sunxi_defconfig: enable CONFIG_REGULATOR
Subsystems (2)
PATCH 1/1 ARM: sunxi_defconfig: enable CONFIG_REGULATOR
Commit 97a13e5289ba ('net: phy: mdio-sun4i: don't select REGULATOR') removed the select of REGULATOR, which means that it now has to be explicitly enabled in the defconfig or things won't work very well.
In particular, this fixes a problem with SD/MMC not probing on my A31-based board.
---
Maxime, I'll apply this on our fixes branch directly.
arch/arm/configs/sunxi_defconfig | 1 + 1 file changed, 1 insertion(+)
arch/arm/configs/sunxi_defconfig +1 -0
@@ -75,6 +75,7 @@ CONFIG_POWER_RESET_SUN6I=y CONFIG_WATCHDOG=y CONFIG_SUNXI_WATCHDOG=y CONFIG_MFD_AXP20X=y +CONFIG_REGULATOR=y CONFIG_REGULATOR_GPIO=y CONFIG_USB=y CONFIG_USB_EHCI_HCD=y
Signature · 1 line
2.0.1.473.gc4d58ca
PATCH 1/1 ARM: sunxi_defconfig: enable CONFIG_REGULATOR
Hi Olof,
Quoted 4 lines · Olof Johansson
Commit
97a13e5289ba('net: phy: mdio-sun4i: don't select REGULATOR') removed the select of REGULATOR, which means that it now has to be explicitly enabled in the defconfig or things won't work very well.
Quoted 8 lines
In particular, this fixes a problem with SD/MMC not probing on my A31-based board.
Cc Beniamino Galvani <[email protected]>Signed-off-by Olof Johansson <[email protected]>---
Maxime, I'll apply this on our fixes branch directly.
I've been chasing the same bug, but didn't make a patch yet. Thanks for taking the time to do it!
If it's not applied yet, you have my
Maxime
Signature · 10 lines
Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141016/629fbef0/attachment.sig>
PATCH 1/1 ARM: sunxi_defconfig: enable CONFIG_REGULATOR
Quoted 14 lines · Maxime Ripard
Hi Olof,
Quoted 11 lines · Olof Johansson
Commit
97a13e5289ba('net: phy: mdio-sun4i: don't select REGULATOR') removed the select of REGULATOR, which means that it now has to be explicitly enabled in the defconfig or things won't work very well.In particular, this fixes a problem with SD/MMC not probing on my A31-based board.
Cc Beniamino Galvani <[email protected]>Signed-off-by Olof Johansson <[email protected]>---
Quoted 7 lines
Quoted 1 line
Maxime, I'll apply this on our fixes branch directly.
I've been chasing the same bug, but didn't make a patch yet. Thanks for taking the time to do it!
If it's not applied yet, you have my
Acked-by Maxime Ripard <[email protected]>
Sorry for the breakage, I didn't realize that some configurations could rely on the implicit selection of the symbol.
Beniamino
PATCH 1/1 ARM: sunxi_defconfig: enable CONFIG_REGULATOR
Quoted 17 lines · Beniamino Galvani
Quoted 16 lines · Maxime Ripard
Hi Olof,
Quoted 12 lines · Olof Johansson
Commit
97a13e5289ba('net: phy: mdio-sun4i: don't select REGULATOR') removed the select of REGULATOR, which means that it now has to be explicitly enabled in the defconfig or things won't work very well.In particular, this fixes a problem with SD/MMC not probing on my A31-based board.
Cc Beniamino Galvani <[email protected]>Signed-off-by Olof Johansson <[email protected]>---
Maxime, I'll apply this on our fixes branch directly.
Quoted 8 lines
Quoted 5 lines
I've been chasing the same bug, but didn't make a patch yet. Thanks for taking the time to do it!
If it's not applied yet, you have my
Acked-by Maxime Ripard <[email protected]>Sorry for the breakage, I didn't realize that some configurations could rely on the implicit selection of the symbol.
Don't worry, it's fine, it's why we have a bugfix period and boots testing for :)
Signature · 10 lines
Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141016/0c8648c2/attachment.sig>
PATCH 1/1 ARM: sunxi_defconfig: enable CONFIG_REGULATOR
Quoted 21 lines · Maxime Ripard
Quoted 20 lines · Beniamino Galvani
Quoted 19 lines · Maxime Ripard
Hi Olof,
Quoted 4 lines · Olof Johansson
Commit
97a13e5289ba('net: phy: mdio-sun4i: don't select REGULATOR') removed the select of REGULATOR, which means that it now has to be explicitly enabled in the defconfig or things won't work very well.Quoted 8 lines
In particular, this fixes a problem with SD/MMC not probing on my A31-based board.
Cc Beniamino Galvani <[email protected]>Signed-off-by Olof Johansson <[email protected]>---
Maxime, I'll apply this on our fixes branch directly.
I've been chasing the same bug, but didn't make a patch yet. Thanks for taking the time to do it!
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
If it's not applied yet, you have my
Acked-by Maxime Ripard <[email protected]>Sorry for the breakage, I didn't realize that some configurations could rely on the implicit selection of the symbol.
Don't worry, it's fine, it's why we have a bugfix period and boots testing for :)
Yep, no worries.
However, it doesn't seem to have been enough and I don't know how I made the test pass the first time when I checked the fix. Looks like it needs REGULATOR_FIXED_VOLTAGE too, and I didn't catch it before I sent out the pull request. D'oh.
I'll fix it for -rc2.
-Olof