Skip to contentSkip to conversation

modplugtools: Added package

PATCH New Maarten ter Huurne 3 participants 4 messages Oct 17, 2014 – Oct 18, 2014

lore
Share & tools
lore

Maarten ter Huurne

author
#0 lore raw

PATCH 1/1 modplugtools: Added package

This installs the 'modplug123' command line tool to play music files using libmodplug.

http://modplug-xmms.sourceforge.net/

Signed-off-by Maarten ter Huurne <[email protected]>

---
The command line tool is about 10 kB in size and is useful to test libmodplug and/or audio playback in general.

 package/Config.in                    |  1 +
 package/modplugtools/Config.in       |  9 +++++++++
 package/modplugtools/modplugtools.mk | 21 +++++++++++++++++++++
 3 files changed, 31 insertions(+)
 create mode 100644 package/modplugtools/Config.in
 create mode 100644 package/modplugtools/modplugtools.mk
package/Config.in +1 -0
index 76fd1a0..03c7074 100644
@@ -18,6 +18,7 @@ menu "Audio and video applications"
 	source "package/lame/Config.in"
 	source "package/libvpx/Config.in"
 	source "package/madplay/Config.in"
+	source "package/modplugtools/Config.in"
 	source "package/mpd/Config.in"
 	source "package/mpg123/Config.in"
 	source "package/mplayer/Config.in"
package/modplugtools/Config.in new file +9 -0
new file mode 100644
index 0000000..53e9672
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_MODPLUGTOOLS
+	bool "modplugtools"
+	select BR2_PACKAGE_LIBAO
+	select BR2_PACKAGE_LIBMODPLUG
+	help
+	  This installs the 'modplug123' command line tool to play music files
+	  using libmodplug.
+
+	  http://modplug-xmms.sourceforge.net/
package/modplugtools/modplugtools.mk new file +21 -0
new file mode 100644
index 0000000..392f0f2
@@ -0,0 +1,21 @@
+################################################################################
+#
+# modplugtools
+#
+################################################################################
+
+MODPLUGTOOLS_VERSION = 0.5.3
+MODPLUGTOOLS_SITE = http://downloads.sourceforge.net/project/modplug-xmms/modplug-tools
+MODPLUGTOOLS_LICENSE = GPLv3
+MODPLUGTOOLS_LICENSE_FILES = COPYING
+
+MODPLUGTOOLS_DEPENDENCIES = libao libmodplug
+
+# Only play through libao: some platforms don't have OSS support and for those
+# that do, playing through libao is still going to be sufficient.
+define MODPLUGTOOLS_REMOVE_MODPLUGPLAY
+	rm $(TARGET_DIR)/usr/bin/modplugplay
+endef
+MODPLUGTOOLS_POST_INSTALL_TARGET_HOOKS += MODPLUGTOOLS_REMOVE_MODPLUGPLAY
+
+$(eval $(autotools-package))
Signature · 1 line
1.8.4.5
#1 lore raw

PATCH 1/1 modplugtools: Added package

Quoted 35 lines · Maarten ter Huurne

This installs the 'modplug123' command line tool to play music files using libmodplug.

http://modplug-xmms.sourceforge.net/

Signed-off-by Maarten ter Huurne <[email protected]>

---
The command line tool is about 10 kB in size and is useful to test libmodplug and/or audio playback in general.

 package/Config.in                    |  1 +
 package/modplugtools/Config.in       |  9 +++++++++
 package/modplugtools/modplugtools.mk | 21 +++++++++++++++++++++
 3 files changed, 31 insertions(+)
 create mode 100644 package/modplugtools/Config.in
 create mode 100644 package/modplugtools/modplugtools.mk
package/Config.in +1 -0
index 76fd1a0..03c7074 100644
@@ -18,6 +18,7 @@ menu "Audio and video applications"
 	source "package/lame/Config.in"
 	source "package/libvpx/Config.in"
 	source "package/madplay/Config.in"
+	source "package/modplugtools/Config.in"
 	source "package/mpd/Config.in"
 	source "package/mpg123/Config.in"
 	source "package/mplayer/Config.in"
package/modplugtools/Config.in new file +0 -0
new file mode 100644
index 0000000..53e9672

package/modplugtools/Config.in line 7

Quoted 7 lines
package/modplugtools/Config.in new file +7 -0
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_MODPLUGTOOLS
+	bool "modplugtools"
+	select BR2_PACKAGE_LIBAO
+	select BR2_PACKAGE_LIBMODPLUG
+	help
+	  This installs the 'modplug123' command line tool to play music files
+	  using libmodplug.

Small nit: I'd say "MOD files" rather than "music files". Or does it play other
formats as well?

Quoted 8 lines
package/modplugtools/Config.in new file +2 -0
+
+	  http://modplug-xmms.sourceforge.net/
package/modplugtools/modplugtools.mk new file +0 -0
new file mode 100644
index 0000000..392f0f2

package/modplugtools/modplugtools.mk line 10

Quoted 10 lines
package/modplugtools/modplugtools.mk new file +10 -0
@@ -0,0 +1,21 @@
+################################################################################
+#
+# modplugtools
+#
+################################################################################
+
+MODPLUGTOOLS_VERSION = 0.5.3
+MODPLUGTOOLS_SITE = http://downloads.sourceforge.net/project/modplug-xmms/modplug-tools
+MODPLUGTOOLS_LICENSE = GPLv3
+MODPLUGTOOLS_LICENSE_FILES = COPYING

It's indeed v3 only (cfr. AUTHORS).

package/modplugtools/modplugtools.mk line 17

Quoted 7 lines
package/modplugtools/modplugtools.mk new file +7 -0
+
+MODPLUGTOOLS_DEPENDENCIES = libao libmodplug
+
+# Only play through libao: some platforms don't have OSS support and for those
+# that do, playing through libao is still going to be sufficient.
+define MODPLUGTOOLS_REMOVE_MODPLUGPLAY
+	rm $(TARGET_DIR)/usr/bin/modplugplay

I don't understand this. The executable is really small, and it builds
correctly (otherwise you wouldn't even get this far), so why bother with removing it? Someone who cares that much about their rootfs size will have to remove a bunch of other stuff from the installed system anyway.

Regards,
Arnout

Quoted 5 lines
package/modplugtools/modplugtools.mk new file +4 -0
+endef
+MODPLUGTOOLS_POST_INSTALL_TARGET_HOOKS += MODPLUGTOOLS_REMOVE_MODPLUGPLAY
+
+$(eval $(autotools-package))
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
author
#2 lore raw

PATCH 1/1 modplugtools: Added package

Quoted 13 lines · On Saturday 18 October 2014 16:13:24 Arnout Vandecappelle wrote:

package/modplugtools/Config.in line 6

Quoted 12 lines · Maarten ter Huurne
(quoted diff) +0 -0

b/package/modplugtools/Config.in new file mode 100644 index 0000000..53e9672

package/modplugtools/Config.in new file +6 -0
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_MODPLUGTOOLS
+	bool "modplugtools"
+	select BR2_PACKAGE_LIBAO
+	select BR2_PACKAGE_LIBMODPLUG
+	help
+	  This installs the 'modplug123' command line tool to play music

files

Quoted 4 lines

package/modplugtools/Config.in line 7

Quoted 1 line
package/modplugtools/Config.in new file +1 -0
+	  using libmodplug.

Small nit: I'd say "MOD files" rather than "music files". Or does it play
other formats as well?

It plays various tracker formats. I tested it with S3M files, for example. I considered "tracker songs" instead of "music files", but I wasn't sure whether "tracker" is still a commonly understood term.

Quoted 4 lines
Quoted 4 lines
package/modplugtools/Config.in new file +4 -0
+
+MODPLUGTOOLS_DEPENDENCIES = libao libmodplug
+
+# Only play through libao: some platforms don't have OSS support and
Quoted 8 lines

package/modplugtools/Config.in

Quoted 3 lines

for those +# that do, playing through libao is still going to be sufficient. +define MODPLUGTOOLS_REMOVE_MODPLUGPLAY

package/modplugtools/Config.in new file +1 -0
+	rm $(TARGET_DIR)/usr/bin/modplugplay

I don't understand this. The executable is really small, and it builds
correctly (otherwise you wouldn't even get this far), so why bother with removing it? Someone who cares that much about their rootfs size will have to remove a bunch of other stuff from the installed system anyway.

It wouldn't execute correctly on target systems that don't have OSS support. Since OSS has been deprecated in the kernel for many years (*), my hope is that most embedded kernels today don't have OSS support.

(*) I tried to look up how long, but it predates the move to Git in 2005.

Bye,
Maarten

#3 lore raw

PATCH 1/1 modplugtools: Added package

Maarten, All,

On 2014-10-18 19:19 +0200, Maarten ter Huurne spake thusly:

Quoted 15 lines · On Saturday 18 October 2014 16:13:24 Arnout Vandecappelle wrote:
Quoted 5 lines · Maarten ter Huurne
Quoted 4 lines
(quoted diff) +0 -0

b/package/modplugtools/Config.in new file mode 100644 index 0000000..53e9672
--- /dev/null

Quoted 8 lines

package/modplugtools/Config.in line 6

Quoted 8 lines

+++ b/package/modplugtools/Config.in

package/modplugtools/Config.in new file +6 -0
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_MODPLUGTOOLS
+	bool "modplugtools"
+	select BR2_PACKAGE_LIBAO
+	select BR2_PACKAGE_LIBMODPLUG
+	help
+	  This installs the 'modplug123' command line tool to play music

files

Quoted 8 lines
Quoted 4 lines

package/modplugtools/Config.in line 7

Quoted 1 line
package/modplugtools/Config.in new file +1 -0
+	  using libmodplug.

Small nit: I'd say "MOD files" rather than "music files". Or does it play
other formats as well?

It plays various tracker formats. I tested it with S3M files, for example. I considered "tracker songs" instead of "music files", but I wasn't sure whether "tracker" is still a commonly understood term.

Eh! I do! :-)

Wikipedia considers them to be "module files", and are to be played with a "music tracker":
https://en.wikipedia.org/wiki/Module_file
https://en.wikipedia.org/wiki/Music_tracker

So, "MOD files" is OK, maybe something like:

    MOD files (eg. .mod, .s3m...)
Quoted 12 lines
Quoted 11 lines

package/modplugtools/modplugtools.mk line 17

Quoted 6 lines
package/modplugtools/modplugtools.mk new file +3 -0
+MODPLUGTOOLS_DEPENDENCIES = libao libmodplug
+
+# Only play through libao: some platforms don't have OSS support and

for those +# that do, playing through libao is still going to be sufficient. +define MODPLUGTOOLS_REMOVE_MODPLUGPLAY

package/modplugtools/modplugtools.mk new file +1 -0
+	rm $(TARGET_DIR)/usr/bin/modplugplay

I don't understand this. The executable is really small, and it builds
correctly (otherwise you wouldn't even get this far), so why bother with removing it? Someone who cares that much about their rootfs size will have to remove a bunch of other stuff from the installed system anyway.

Quoted 5 lines

It wouldn't execute correctly on target systems that don't have OSS support. Since OSS has been deprecated in the kernel for many years (*), my hope is that most embedded kernels today don't have OSS support.

(*) I tried to look up how long, but it predates the move to Git in 2005.

Yeah, I wouldn't bother with OSS.

But then, be more explicit in the comment, and/or make it configurable.

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'