Skip to contentSkip to conversation

mongrel2: Add comments to avoid use of github call

PATCH New Maxime Hadjinlian 3 participants 3 messages Oct 12, 2014 – Oct 30, 2014

lore
Share & tools
lore

Maxime Hadjinlian

author
#0 lore raw

PATCH v3 1/1 mongrel2: Add comments to avoid use of github call

As the comment says, we don't want to uses the github helper, as we would end up with a generated tarball, which is not the same one as the one linked with the releases.

Signed-off-by Maxime Hadjinlian <[email protected]>

---
v2 -> v3:
- fix typo
v1 -> v2:
- Do not change the URL but add a comments instead

---
 package/mongrel2/mongrel2.mk | 2 ++
 1 file changed, 2 insertions(+)
package/mongrel2/mongrel2.mk +2 -0
index 14e3a80..23cec50 100644
@@ -5,6 +5,8 @@
 ################################################################################
 
 MONGREL2_VERSION = v1.9.1
+# Do not use the github helper here, the generated tarball is *NOT* the same
+# as the one uploaded by upstream for the release.
 MONGREL2_SITE = https://github.com/zedshaw/mongrel2/releases/download/$(MONGREL2_VERSION)
 MONGREL2_LICENSE = BSD-3c
 MONGREL2_LICENSE_FILES = LICENSE
Signature · 1 line
2.1.1
#1 lore raw

PATCH v3 1/1 mongrel2: Add comments to avoid use of github call

Maxime, All,

On 2014-10-12 21:39 +0200, Maxime Hadjinlian spake thusly:

Quoted 5 lines

As the comment says, we don't want to uses the github helper, as we would end up with a generated tarball, which is not the same one as the one linked with the releases.

Signed-off-by Maxime Hadjinlian <[email protected]>
Reviewed-by "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 29 lines

---
v2 -> v3:
- fix typo
v1 -> v2:
- Do not change the URL but add a comments instead

---
 package/mongrel2/mongrel2.mk | 2 ++
 1 file changed, 2 insertions(+)
package/mongrel2/mongrel2.mk +2 -0
index 14e3a80..23cec50 100644
@@ -5,6 +5,8 @@
 ################################################################################
 
 MONGREL2_VERSION = v1.9.1
+# Do not use the github helper here, the generated tarball is *NOT* the same
+# as the one uploaded by upstream for the release.
 MONGREL2_SITE = https://github.com/zedshaw/mongrel2/releases/download/$(MONGREL2_VERSION)
 MONGREL2_LICENSE = BSD-3c
 MONGREL2_LICENSE_FILES = LICENSE
Signature · 6 lines
2.1.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
Applied
#2 lore raw

PATCH v3 1/1 mongrel2: Add comments to avoid use of github call

In reply to Maxime Hadjinlian

Dear Maxime Hadjinlian,

Quoted 5 lines · Maxime Hadjinlian

As the comment says, we don't want to uses the github helper, as we would end up with a generated tarball, which is not the same one as the one linked with the releases.

Signed-off-by Maxime Hadjinlian <[email protected]>
Quoted 8 lines

---
v2 -> v3:
- fix typo
v1 -> v2:
- Do not change the URL but add a comments instead

---
 package/mongrel2/mongrel2.mk | 2 ++
 1 file changed, 2 insertions(+)

Applied, thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com