libevent: Use github call & fix patch

PATCH Superseded Maxime Hadjinlian 2 participants 2 messages Oct 19, 2014

lore

Share & tools

lore

Maxime Hadjinlian

author

2014-10-19 10:16 UTC #0 lore raw

PATCH v3 1/1 libevent: Use github call & fix patch

We want to use the github helper since we download a generated tarball from the tag anyway.

We also need to use AUTORECONF as those releases do not contains 'configure' and such.

The patch that was already present is updated to apply against Makefile.am instead of Makefile.in

The second patch is backported from upstream to remove the use of $(top_src_dirs) which makes current autotools error out.

Signed-off-by Maxime Hadjinlian <[email protected]>

---
v2 -> v3:
- Fix grammar in commit log (Yann E. Morin)
- Change version to reflect the whole tag name (Yann E. Morin)
v1 -> v2:
- Fix the added patches so they have correct SoB (Thomas Petazzoni)
- Add SoB (Thomas Petazzoni)
- Add comment for autoreconf (Yann E. Morin)

---
 .../0001-Disable-building-test-programs.patch      | 30 +++++++++
 .../0002-Avoid-using-top_srcdir-in-TESTS.patch     | 71 ++++++++++++++++++++++
 .../libevent-disable-building-test-programs.patch  | 30 ---------
 package/libevent/libevent.mk                       |  7 ++-
 4 files changed, 105 insertions(+), 33 deletions(-)
 create mode 100644 package/libevent/0001-Disable-building-test-programs.patch
 create mode 100644 package/libevent/0002-Avoid-using-top_srcdir-in-TESTS.patch
 delete mode 100644 package/libevent/libevent-disable-building-test-programs.patch

package/libevent/0001-Disable-building-test-programs.patch new file +30 -0

new file mode 100644
index 0000000..eb1acfd
@@ -0,0 +1,30 @@
+From 4b5a135fa681e85eb6988a379f59f3c7a41cc48c Mon Sep 17 00:00:00 2001
+From: Gilles Talis <[email protected]>
+Date: Fri, 21 Jun 2013 15:25:11 -0700
+Subject: [PATCH 1/2] Disable building test programs
+
+We are not really interested in building test programs.
+Moreover, these programs use fork() function that is
+not available on MMU-less architectures.
+
+Signed-off-by: Gilles Talis <[email protected]>
+---
+ Makefile.am | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/Makefile.am b/Makefile.am
+index 42879a3..dc90359 100644
+--- a/Makefile.am
++++ b/Makefile.am
+@@ -126,7 +126,7 @@ else
+ noinst_LTLIBRARIES =  $(LIBEVENT_LIBS_LA)
+ endif
+ 
+-SUBDIRS = . include sample test
++SUBDIRS = . include sample
+ 
+ if BUILD_WIN32
+ 
+-- 
+2.1.1
+

package/libevent/0002-Avoid-using-top_srcdir-in-TESTS.patch new file +71 -0

71 lines not on this page · raw message

package/libevent/libevent-disable-building-test-programs.patch deleted +0 ~~-30~~

deleted file mode 100644
index 4b0f0d9..0000000
@@ -1,30 +0,0 @@
-From e932c8864e1bb8b6a7901d4b049a1100c4becba5 Mon Sep 17 00:00:00 2001
-From: Gilles Talis <[email protected]>
-Date: Fri, 21 Jun 2013 15:25:11 -0700
-Subject: [PATCH] Disable building test programs
-
-We are not really interested in building test programs.
-Moreover, these programs use fork() function that is
-not available on MMU-less architectures.
-
-Signed-off-by: Gilles Talis <[email protected]>
----
- Makefile.in |    2 +-
- 1 files changed, 1 insertions(+), 1 deletions(-)
-
-diff --git a/Makefile.in b/Makefile.in
-index 2ebefa2..4fba1ff 100644
---- a/Makefile.in
-+++ b/Makefile.in
-@@ -487,7 +487,7 @@ LIBEVENT_LIBS_LA = libevent.la libevent_core.la libevent_extra.la \
- @INSTALL_LIBEVENT_TRUE at lib_LTLIBRARIES = $(LIBEVENT_LIBS_LA)
- @INSTALL_LIBEVENT_TRUE at pkgconfig_DATA = $(LIBEVENT_PKGCONFIG)
- @INSTALL_LIBEVENT_FALSE at noinst_LTLIBRARIES = $(LIBEVENT_LIBS_LA)
--SUBDIRS = . include sample test
-+SUBDIRS = . include sample
- @BUILD_WIN32_FALSE at SYS_LIBS = 
- @BUILD_WIN32_TRUE at SYS_LIBS = -lws2_32 -lshell32 -ladvapi32
- @BUILD_WIN32_FALSE at SYS_SRC = $(am__append_5) $(am__append_6) \
--- 
-1.7.4.1
-

package/libevent/libevent.mk +4 -3

index 73be502..607b7b2 100644
@@ -4,12 +4,13 @@
 #
 ################################################################################
 
-LIBEVENT_VERSION = 2.0.21
-LIBEVENT_SOURCE = libevent-$(LIBEVENT_VERSION)-stable.tar.gz
-LIBEVENT_SITE = https://github.com/downloads/libevent/libevent
+LIBEVENT_VERSION = release-2.0.21-stable
+LIBEVENT_SITE = $(call github,libevent,libevent,$(LIBEVENT_VERSION))
 LIBEVENT_INSTALL_STAGING = YES
 LIBEVENT_LICENSE = BSD-3c, OpenBSD
 LIBEVENT_LICENSE_FILES = LICENSE
+# Straight from the repository, need to generate autotools files
+LIBEVENT_AUTORECONF = YES
 
 define LIBEVENT_REMOVE_PYSCRIPT
 	rm $(TARGET_DIR)/usr/bin/event_rpcgen.py

Signature · 1 line

2.1.1

Thomas Petazzoni

2014-10-19 15:06 UTC #1 lore raw

PATCH v3 1/1 libevent: Use github call & fix patch

Dear Maxime Hadjinlian,

Quoted 6 lines · Maxime Hadjinlian

We want to use the github helper since we download a generated tarball from the tag anyway.
We also need to use AUTORECONF as those releases do not contains 'configure' and such.

Quoted 7 lines

The patch that was already present is updated to apply against Makefile.am instead of Makefile.in
The second patch is backported from upstream to remove the use of $(top_src_dirs) which makes current autotools error out.
Signed-off-by Maxime Hadjinlian <[email protected]>

I still don't understand the benefit of switching from a download place that provides a tarball with the configure and Makefile.in already generated to a place where those are not generated and will therefore always require an autoreconf.

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com