Skip to contentSkip to conversation

package/ipset: Fix compile error

PATCH New Bernd Kuhls 3 participants 6 messages Oct 19, 2014 – Oct 26, 2014

lore
Share & tools
lore

Bernd Kuhls

author
#0 lore raw

PATCH 1/1 package/ipset: Fix compile error

Error occured with an allyespackageconfig setup:

In file included from print.c:19:0:
print.c: In function 'ipset_print_ip':
../include/libipset/data.h:150:1: error: inlining failed in call to 'ipset_data_test': call is unlikely and code size would grow [-Werror=inline]
ipset_data_test(const struct ipset_data *data, enum ipset_opt opt)
^
print.c:273:21: error: called from here [-Werror=inline]
if (ipset_data_test(data, cidropt)) {

Signed-off-by Bernd Kuhls <[email protected]>
---
 package/ipset/ipset.mk |    2 ++
 1 file changed, 2 insertions(+)
package/ipset/ipset.mk +2 -0
index d3dbc67..b1518f4 100644
@@ -13,4 +13,6 @@ IPSET_AUTORECONF = YES
 IPSET_LICENSE = GPLv2
 IPSET_LICENSE_FILES = COPYING
 
+IPSET_CONF_ENV = ax_cv_cflags_gcc_option__Winline=""
+
 $(eval $(autotools-package))
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/1 package/ipset: Fix compile error

Hi Bernd,

Quoted 20 lines · Bernd Kuhls

Error occured with an allyespackageconfig setup:

In file included from print.c:19:0:
print.c: In function 'ipset_print_ip':
../include/libipset/data.h:150:1: error: inlining failed in call to 'ipset_data_test': call is unlikely and code size would grow [-Werror=inline]
ipset_data_test(const struct ipset_data *data, enum ipset_opt opt)
^
print.c:273:21: error: called from here [-Werror=inline]
if (ipset_data_test(data, cidropt)) {

Signed-off-by Bernd Kuhls <[email protected]>
---
 package/ipset/ipset.mk |    2 ++
 1 file changed, 2 insertions(+)
package/ipset/ipset.mk +0 -0
index d3dbc67..b1518f4 100644

package/ipset/ipset.mk IPSET_AUTORECONF = YES · line 18

Quoted 6 lines
package/ipset/ipset.mk +2 -0
@@ -13,4 +13,6 @@ IPSET_AUTORECONF = YES
 IPSET_LICENSE = GPLv2
 IPSET_LICENSE_FILES = COPYING
 
+IPSET_CONF_ENV = ax_cv_cflags_gcc_option__Winline=""
+
 $(eval $(autotools-package))

Instead of squashing each type of compiler warning, why not remove -Werror entirely? It's not that useful when you only want to build the package.

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
#2 lore raw

PATCH 1/1 package/ipset: Fix compile error

In reply to Bernd Kuhls

Dear Bernd Kuhls,

Quoted 10 lines · Bernd Kuhls

Error occured with an allyespackageconfig setup:

In file included from print.c:19:0:
print.c: In function 'ipset_print_ip':
../include/libipset/data.h:150:1: error: inlining failed in call to 'ipset_data_test': call is unlikely and code size would grow [-Werror=inline]
ipset_data_test(const struct ipset_data *data, enum ipset_opt opt)
^
print.c:273:21: error: called from here [-Werror=inline]
if (ipset_data_test(data, cidropt)) {

Quoted 4 lines
Signed-off-by Bernd Kuhls <[email protected]>
---
 package/ipset/ipset.mk |    2 ++
 1 file changed, 2 insertions(+)

To fix the same problem, I've applied a slightly different fix, that simply removes -Werror altogether.

See
http://git.buildroot.net/buildroot/commit/?id=a923b44112aa3bfdb42b12cc1bd2712a263c1a0c.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#3 lore raw

PATCH 1/1 package/ipset: Fix compile error

Hi Thomas,

Quoted 18 lines · Thomas Petazzoni

Dear Bernd Kuhls,

Quoted 10 lines · Bernd Kuhls

Error occured with an allyespackageconfig setup:

In file included from print.c:19:0:
print.c: In function 'ipset_print_ip':
../include/libipset/data.h:150:1: error: inlining failed in call to 'ipset_data_test': call is unlikely and code size would grow [-Werror=inline]
ipset_data_test(const struct ipset_data *data, enum ipset_opt opt)
^
print.c:273:21: error: called from here [-Werror=inline]
if (ipset_data_test(data, cidropt)) {

Quoted 4 lines
Signed-off-by Bernd Kuhls <[email protected]>
---
 package/ipset/ipset.mk |    2 ++
 1 file changed, 2 insertions(+)
Quoted 5 lines

To fix the same problem, I've applied a slightly different fix, that simply removes -Werror altogether.

See
http://git.buildroot.net/buildroot/commit/?id=a923b44112aa3bfdb42b12cc1bd2712a263c1a0c.

The presence of /usr/local/include directory in the include path still needs to be fixes by itself. See
http://autobuild.buildroot.net/results/4f5/4f55c2415281c6204500efe28fe9e24c8ef73863/build-end.log.
This comes from the AM_CPPFLAGS variable that is set in Make_global.am.

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
#4 lore raw

PATCH 1/1 package/ipset: Fix compile error

Dear Baruch Siach,

Quoted 10 lines · Baruch Siach
Quoted 5 lines

To fix the same problem, I've applied a slightly different fix, that simply removes -Werror altogether.

See
http://git.buildroot.net/buildroot/commit/?id=a923b44112aa3bfdb42b12cc1bd2712a263c1a0c.

The presence of /usr/local/include directory in the include path still needs to be fixes by itself. See
http://autobuild.buildroot.net/results/4f5/4f55c2415281c6204500efe28fe9e24c8ef73863/build-end.log.
This comes from the AM_CPPFLAGS variable that is set in Make_global.am.

Ah, right. Could you send a patch for this?

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#5 lore raw

PATCH 1/1 package/ipset: Fix compile error

Hi Thomas,

Quoted 7 lines · Thomas Petazzoni
Quoted 6 lines · Baruch Siach
Quoted 5 lines

To fix the same problem, I've applied a slightly different fix, that simply removes -Werror altogether.

See
http://git.buildroot.net/buildroot/commit/?id=a923b44112aa3bfdb42b12cc1bd2712a263c1a0c.

Quoted 6 lines
Quoted 4 lines

The presence of /usr/local/include directory in the include path still needs to be fixes by itself. See
http://autobuild.buildroot.net/results/4f5/4f55c2415281c6204500efe28fe9e24c8ef73863/build-end.log.
This comes from the AM_CPPFLAGS variable that is set in Make_global.am.

Ah, right. Could you send a patch for this?

I hope I'll have some time for this later this week.

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -