Skip to contentSkip to conversation

generic-board: make compile-time noise for non-generic boards

PATCH Superseded Masahiro Yamada 3 participants 3 messages Oct 19, 2014 Kbuild

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Masahiro Yamada

author
#0 lore raw

PATCH 1/1 generic-board: make compile-time noise for non-generic boards

Commit 0f605c1501f6 (Start the deprecation process for generic board) added a run-time warning message. Let's be noisier for non-generic boards to inform the dead line of the conversion.

Signed-off-by Masahiro Yamada <[email protected]>
Cc Tom Rini <[email protected]>
Cc Simon Glass <[email protected]>

---

 Makefile | 6 ++++++
 1 file changed, 6 insertions(+)
Makefile +6 -0
index 99097e1..f439d82 100644
@@ -775,6 +775,12 @@ quiet_cmd_pad_cat = CAT     $@
 cmd_pad_cat = $(cmd_objcopy) && $(append) || rm -f $@
 
 all:		$(ALL-y)
+ifneq ($(CONFIG_SYS_GENERIC_BOARD),y)
+	@echo >&2 "==================== WARNING ====================="
+	@echo >&2 "Please convert this board to generic board."
+	@echo >&2 "Otherwise it will be removed by the end of 2014."
+	@echo >&2 "=================================================="
+endif
 
 PHONY += dtbs
 dtbs dts/dt.dtb: checkdtc u-boot
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 generic-board: make compile-time noise for non-generic boards

Quoted 7 lines · Masahiro Yamada

Commit 0f605c1501f6 (Start the deprecation process for generic board) added a run-time warning message. Let's be noisier for non-generic boards to inform the dead line of the conversion.

Signed-off-by Masahiro Yamada <[email protected]>
Cc Tom Rini <[email protected]>
Cc Simon Glass <[email protected]>

By all means,

Acked-by Marek Vasut <[email protected]>

I hope you enjoyed your stay in Germany and had fun. It was really nice meeting you again :)

Best regards,
Marek Vasut

#2 lore raw
In reply to Masahiro Yamada
Quoted 3 lines · Masahiro Yamada

Commit 0f605c1501f6 (Start the deprecation process for generic board) added a run-time warning message. Let's be noisier for non-generic boards to inform the dead line of the conversion.

...

Quoted 7 lines
Makefile +0 -0
index 99097e1..f439d82 100644
@@ -775,6 +775,12 @@ quiet_cmd_pad_cat = CAT     $@
 cmd_pad_cat = $(cmd_objcopy) && $(append) || rm -f $@

Makefile quiet_cmd_pad_cat = CAT $@ · line 786

Quoted 10 lines
Makefile +6 -0
 all:		$(ALL-y)
+ifneq ($(CONFIG_SYS_GENERIC_BOARD),y)
+	@echo >&2 "==================== WARNING ====================="
+	@echo >&2 "Please convert this board to generic board."
+	@echo >&2 "Otherwise it will be removed by the end of 2014."
+	@echo >&2 "=================================================="
+endif
 
 PHONY += dtbs
 dtbs dts/dt.dtb: checkdtc u-boot

Maybe it should also mention doc/README.generic-board in the warning, or some other indication where to find more information?

live well,
vagrant
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141019/3b047ab4/attachment.pgp>