Skip to contentSkip to conversation

arm64: Add KEYS_COMPAT to Kconfig & enable

PATCH New Michael Spang 2 participants 3 messages Oct 14, 2014 – Apr 20, 2015 arm64

lore
Share & tools
lore

Michael Spang

author
#0 lore raw

PATCH 1/1 arm64: Add KEYS_COMPAT to Kconfig & enable

This enables the keyctl compat syscall.

Signed-off-by Michael Spang <[email protected]>
---
 arch/arm64/Kconfig | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm64/Kconfig +5 -0
index ac9afde..35c3103 100644
@@ -461,6 +461,11 @@ source "arch/arm64/Kconfig.debug"
 
 source "security/Kconfig"
 
+config KEYS_COMPAT
+	bool
+	depends on COMPAT && KEYS
+	default y
+
 source "crypto/Kconfig"
 if CRYPTO
 source "arch/arm64/crypto/Kconfig"
Signature · 1 line
2.1.0.rc2.206.gedb03e5
#1 lore raw

PATCH 1/1 arm64: Add KEYS_COMPAT to Kconfig & enable

Quoted 12 lines · Michael Spang

This enables the keyctl compat syscall.

Signed-off-by Michael Spang <[email protected]>
---
 arch/arm64/Kconfig | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm64/Kconfig +0 -0
index ac9afde..35c3103 100644

arch/arm64/Kconfig source "arch/arm64/Kconfig.debug" · line 467

Quoted 7 lines
arch/arm64/Kconfig +4 -0
@@ -461,6 +461,11 @@ source "arch/arm64/Kconfig.debug"
 
 source "security/Kconfig"
 
+config KEYS_COMPAT
+	bool
+	depends on COMPAT && KEYS
+	default y

I'm curious as to why this requires a Kconfig option, whilst other compat system calls do not. The core code is already using COMPAT_SYSCALL_DEFINE, so why can't the architecture just plumb the compat syscall table and be done with it?

Failing that, the pattern used elsewhere involves __ARCH_WANT_COMPAT_* #defines.

Will

author
#2 lore raw

PATCH 1/1 arm64: Add KEYS_COMPAT to Kconfig & enable

Quoted 26 lines · Will Deacon
Quoted 12 lines · Michael Spang

This enables the keyctl compat syscall.

Signed-off-by Michael Spang <[email protected]>
---
 arch/arm64/Kconfig | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm64/Kconfig +0 -0
index ac9afde..35c3103 100644

arch/arm64/Kconfig source "arch/arm64/Kconfig.debug" · line 467

Quoted 7 lines
arch/arm64/Kconfig +4 -0
@@ -461,6 +461,11 @@ source "arch/arm64/Kconfig.debug"
 
 source "security/Kconfig"
 
+config KEYS_COMPAT
+     bool
+     depends on COMPAT && KEYS
+     default y

I'm curious as to why this requires a Kconfig option, whilst other compat system calls do not. The core code is already using COMPAT_SYSCALL_DEFINE, so why can't the architecture just plumb the compat syscall table and be done with it?

Quoted 2 lines

Failing that, the pattern used elsewhere involves __ARCH_WANT_COMPAT_* #defines.

I am not actually sure why it is the way it is. All the other archs just set the option exactly like this.

I've just resent it with only a minor adjustment.

Cheers!
Michael