package/boost: enable building of boost_log

PATCH New Yannick Kiekens 3 participants 6 messages Oct 20, 2014 – Mar 15, 2015

lore

Share & tools

lore

Yannick Kiekens

author

2014-10-20 13:27 UTC #0 lore raw

PATCH 1/1 package/boost: enable building of boost_log

Signed-off-by Yannick Kiekens <[email protected]>

---
 package/boost/Config.in | 3 +++
 package/boost/boost.mk  | 4 ++--
 2 files changed, 5 insertions(+), 2 deletions(-)

package/boost/Config.in +3 -0

index a15b849..5ac1d0e 100644
@@ -85,6 +85,9 @@ config BR2_PACKAGE_BOOST_LOCALE
 comment "boost-locale needs a toolchain w/ wchar"
 	depends on !BR2_USE_WCHAR
 
+config BR2_PACKAGE_BOOST_LOG
+        bool "boost-log"
+
 config BR2_PACKAGE_BOOST_MATH
 	bool "boost-math"

package/boost/boost.mk +2 -2

index 46a98e8..06969b4 100644
@@ -25,8 +25,7 @@ HOST_BOOST_FLAGS = --without-icu \
 
 # atomic library compile only with upstream version, wait for next release
 # coroutine breaks on some weak toolchains and it's new for 1.54+
-# log breaks with some toolchain combinations and it's new for 1.54+
-BOOST_WITHOUT_FLAGS = atomic coroutine log
+BOOST_WITHOUT_FLAGS = atomic coroutine
 
 BOOST_WITHOUT_FLAGS += $(if $(BR2_PACKAGE_BOOST_CHRONO),,chrono)
 BOOST_WITHOUT_FLAGS += $(if $(BR2_PACKAGE_BOOST_CONTEXT),,context)

@@ -37,6 +36,7 @@ BOOST_WITHOUT_FLAGS += $(if $(BR2_PACKAGE_BOOST_GRAPH),,graph)
 BOOST_WITHOUT_FLAGS += $(if $(BR2_PACKAGE_BOOST_GRAPH_PARALLEL),,graph_parallel)
 BOOST_WITHOUT_FLAGS += $(if $(BR2_PACKAGE_BOOST_IOSTREAMS),,iostreams)
 BOOST_WITHOUT_FLAGS += $(if $(BR2_PACKAGE_BOOST_LOCALE),,locale)
+BOOST_WITHOUT_FLAGS += $(if $(BR2_PACKAGE_BOOST_LOG),,log)
 BOOST_WITHOUT_FLAGS += $(if $(BR2_PACKAGE_BOOST_MATH),,math)
 BOOST_WITHOUT_FLAGS += $(if $(BR2_PACKAGE_BOOST_MPI),,mpi)
 BOOST_WITHOUT_FLAGS += $(if $(BR2_PACKAGE_BOOST_PROGRAM_OPTIONS),,program_options)

Signature · 1 line

1.9.1

Yann E. MORIN

2014-10-20 17:02 UTC #1 lore raw

PATCH 1/1 package/boost: enable building of boost_log

Yannick, All,

On 2014-10-20 15:27 +0200, Yannick Kiekens spake thusly:

Quoted 25 lines

Signed-off-by Yannick Kiekens <[email protected]>

---
 package/boost/Config.in | 3 +++
 package/boost/boost.mk  | 4 ++--
 2 files changed, 5 insertions(+), 2 deletions(-)

package/boost/Config.in +3 -0

index a15b849..5ac1d0e 100644
@@ -85,6 +85,9 @@ config BR2_PACKAGE_BOOST_LOCALE
 comment "boost-locale needs a toolchain w/ wchar"
 	depends on !BR2_USE_WCHAR
 
+config BR2_PACKAGE_BOOST_LOG
+        bool "boost-log"
+
 config BR2_PACKAGE_BOOST_MATH
 	bool "boost-math"

package/boost/boost.mk +0 -0

index 46a98e8..06969b4 100644

package/boost/boost.mk HOST_BOOST_FLAGS = --without-icu \ · line 28

Quoted 4 lines

package/boost/boost.mk +0 -1

@@ -25,8 +25,7 @@ HOST_BOOST_FLAGS = --without-icu \
 
 # atomic library compile only with upstream version, wait for next release
 # coroutine breaks on some weak toolchains and it's new for 1.54+
-# log breaks with some toolchain combinations and it's new for 1.54+

As you remove a comment that warns that log is broken in some cases, it would be nice if you were to explain why this comment no longer applies.

For example, you could format your commit log as thus (reason totally made up for the sake of the example, adapt):

package/boost: enable building of boost_log

In the current version of boost, boost_log is now considered stable and maintained. The failures caused by "some toolchain combinations" no longer occur.

Signed-off-by [YOU]

---
Tested with these toolchains:
- uClibc, arm, static only
- uClibc, x86_64

Note the '---' line: you can add such a line in your commit log, and it will appear as-is in the mail you send. However, git is smart enough so that when the maintainer applies the patch, git removes it.

Otherwise, I'm no boost expert, but the patch looks OK.

Regards,
Yann E. MORIN.

Quoted 20 lines

package/boost/boost.mk +2 -1

-BOOST_WITHOUT_FLAGS = atomic coroutine log
+BOOST_WITHOUT_FLAGS = atomic coroutine
 
 BOOST_WITHOUT_FLAGS += $(if $(BR2_PACKAGE_BOOST_CHRONO),,chrono)
 BOOST_WITHOUT_FLAGS += $(if $(BR2_PACKAGE_BOOST_CONTEXT),,context)

@@ -37,6 +36,7 @@ BOOST_WITHOUT_FLAGS += $(if $(BR2_PACKAGE_BOOST_GRAPH),,graph)
 BOOST_WITHOUT_FLAGS += $(if $(BR2_PACKAGE_BOOST_GRAPH_PARALLEL),,graph_parallel)
 BOOST_WITHOUT_FLAGS += $(if $(BR2_PACKAGE_BOOST_IOSTREAMS),,iostreams)
 BOOST_WITHOUT_FLAGS += $(if $(BR2_PACKAGE_BOOST_LOCALE),,locale)
+BOOST_WITHOUT_FLAGS += $(if $(BR2_PACKAGE_BOOST_LOG),,log)
 BOOST_WITHOUT_FLAGS += $(if $(BR2_PACKAGE_BOOST_MATH),,math)
 BOOST_WITHOUT_FLAGS += $(if $(BR2_PACKAGE_BOOST_MPI),,mpi)
 BOOST_WITHOUT_FLAGS += $(if $(BR2_PACKAGE_BOOST_PROGRAM_OPTIONS),,program_options)

Signature · 6 lines

1.9.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Signature · 6 lines

.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

Yann E. MORIN

2014-10-20 17:07 UTC #2 lore raw

PATCH 1/1 package/boost: enable building of boost_log

Yannick, All,

On 2014-10-20 19:02 +0200, Yann E. MORIN spake thusly:

Quoted 1 line

On 2014-10-20 15:27 +0200, Yannick Kiekens spake thusly:

[--SNIP--]

Quoted 24 lines

package/boost/boost.mk HOST_BOOST_FLAGS = --without-icu \ · line 28
Quoted 9 lines
package/boost/boost.mk +0 -1
index 46a98e8..06969b4 100644
@@ -25,8 +25,7 @@ HOST_BOOST_FLAGS = --without-icu \
 
 # atomic library compile only with upstream version, wait for next release
 # coroutine breaks on some weak toolchains and it's new for 1.54+
-# log breaks with some toolchain combinations and it's new for 1.54+
As you remove a comment that warns that log is broken in some cases, it would be nice if you were to explain why this comment no longer applies.
For example, you could format your commit log as thus (reason totally made up for the sake of the example, adapt):
package/boost: enable building of boost_log
In the current version of boost, boost_log is now considered stable and maintained. The failures caused by "some toolchain combinations" no longer occur.
Signed-off-by [YOU]

Quoted 8 lines

---
Tested with these toolchains:
- uClibc, arm, static only
- uClibc, x86_64
Note the '---' line: you can add such a line in your commit log, and it will appear as-is in the mail you send. However, git is smart enough so that when the maintainer applies the patch, git removes it.

Sorry, I meant:
[...] git removes it, and whatever follows (but keeps the patch, of course).

Regards,
Yann E. MORIN.

Signature · 6 lines

.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

Yannick Kiekens

author

2014-10-21 07:15 UTC #3 lore raw

PATCH 1/1 package/boost: enable building of boost_log

Quoted 39 lines · Yann E. MORIN

Yannick, All,
On 2014-10-20 19:02 +0200, Yann E. MORIN spake thusly:
Quoted 1 line
On 2014-10-20 15:27 +0200, Yannick Kiekens spake thusly:
[--SNIP--]
Quoted 7 lines
package/boost/boost.mk HOST_BOOST_FLAGS = --without-icu \ · line 26
Quoted 7 lines
package/boost/boost.mk +0 -0
index 46a98e8..06969b4 100644
@@ -25,8 +25,7 @@ HOST_BOOST_FLAGS = --without-icu \
 
 # atomic library compile only with upstream version, wait for next
release
Quoted 17 lines
package/boost/boost.mk HOST_BOOST_FLAGS = --without-icu \ · line 28
Quoted 2 lines
package/boost/boost.mk +0 -1
 # coroutine breaks on some weak toolchains and it's new for 1.54+
-# log breaks with some toolchain combinations and it's new for 1.54+
As you remove a comment that warns that log is broken in some cases, it would be nice if you were to explain why this comment no longer applies.
For example, you could format your commit log as thus (reason totally made up for the sake of the example, adapt):
package/boost: enable building of boost_log
In the current version of boost, boost_log is now considered stable and maintained. The failures caused by "some toolchain combinations" no longer occur.
Signed-off-by [YOU]
Quoted 8 lines
---
Tested with these toolchains:
- uClibc, arm, static only
- uClibc, x86_64
Note the '---' line: you can add such a line in your commit log, and it will appear as-is in the mail you send. However, git is smart enough so that when the maintainer applies the patch, git removes it.

Quoted 8 lines

Sorry, I meant:
[...] git removes it, and whatever follows (but keeps the patch, of course).
Regards,
Yann E. MORIN.

?We use boost_log at work on x86_64 and armv7, we never had trouble with it. It is possible boost_log 1.56 still does not work on some toolchain combinations?, as mentioned in git
commit 611dfe6cb55ed72d7df3b7c102f4a723248a4037

?I could reformat the patch to whitelist boost_log on known configurations Any opnion on that?

Regards,
Yannick Kiekens?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20141021/5b9320a5/attachment.html>

Thomas Petazzoni

2014-10-21 09:56 UTC #4 lore raw

PATCH 1/1 package/boost: enable building of boost_log

Dear Yannick Kiekens,

Quoted 7 lines · Yannick Kiekens

?We use boost_log at work on x86_64 and armv7, we never had trouble with it. It is possible boost_log 1.56 still does not work on some toolchain combinations?, as mentioned in git
commit 611dfe6cb55ed72d7df3b7c102f4a723248a4037
?I could reformat the patch to whitelist boost_log on known configurations Any opnion on that?

Can you try looking at
http://autobuild.buildroot.net/results/c26/c26498f1a4e6bcbc3a2dfce6a51fa7d21b72f21f/build-end.log,
which is the issue reported in commit
611dfe6cb55ed72d7df3b7c102f4a723248a4037 ?

Best regards,

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Thomas Petazzoni

Applied

2015-03-15 16:49 UTC #5 lore raw

PATCH 1/1 package/boost: enable building of boost_log

In reply to Yannick Kiekens

Dear Yannick Kiekens,

Quoted 5 lines · Yannick Kiekens

Signed-off-by Yannick Kiekens <[email protected]>

---
 package/boost/Config.in | 3 +++
 package/boost/boost.mk  | 4 ++--
 2 files changed, 5 insertions(+), 2 deletions(-)

Applied, thanks!

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com