Skip to contentSkip to conversation

libupnpp: new package

PATCH Superseded Jörg Krause 2 participants 6 messages Oct 20, 2014

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 libupnpp: new package

---
 package/Config.in            |  1 +
 package/libupnpp/Config.in   | 20 ++++++++++++++++++++
 package/libupnpp/libupnpp.mk | 14 ++++++++++++++
 3 files changed, 35 insertions(+)
 create mode 100644 package/libupnpp/Config.in
 create mode 100644 package/libupnpp/libupnpp.mk
package/Config.in +1 -0
index 89b46dc..4626f00 100644
@@ -816,6 +816,7 @@ menu "Networking"
 	source "package/libtirpc/Config.in"
 	source "package/libtorrent/Config.in"
 	source "package/libupnp/Config.in"
+	source "package/libupnpp/Config.in"
 	source "package/libvncserver/Config.in"
 	source "package/libwebsockets/Config.in"
 	source "package/neon/Config.in"
package/libupnpp/Config.in new file +20 -0
new file mode 100644
index 0000000..5a79452
@@ -0,0 +1,20 @@
+config BR2_PACKAGE_LIBUPNPP
+	bool "libupnpp"
+	select BR2_PACKAGE_EXPAT
+	select BR2_PACKAGE_LIBCURL
+	select BR2_PACKAGE_LIBUPNP
+	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_LARGEFILE # libupnp
+	depends on BR2_TOOLCHAIN_HAS_THREADS # libupnp
+	depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2014R1 # Too old gcc
+	depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2013R1 # Ditto
+	depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2 # Ditto
+	help
+	  The libupnpp C++ library wraps libupnp for easier use by upmpdcli and
+	  upplay.
+
+	  http://www.lesbonscomptes.com/upmpdcli/
+
+comment "upmpdcli needs a toolchain w/ C++, largefile, threads"
+	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_LARGEFILE || \
+		!BR2_TOOLCHAIN_HAS_THREADS
package/libupnpp/libupnpp.mk new file +14 -0
new file mode 100644
index 0000000..d46de14
@@ -0,0 +1,14 @@
+################################################################################
+#
+# libupnpp
+#
+################################################################################
+
+LIBUPNPP_VERSION = 0.8.5
+LIBUPNPP_SITE = http://www.lesbonscomptes.com/upmpdcli/downloads
+LIBUPNPP_LICENSE = GPLv2+
+LIBUPNPP_LICENSE_FILES = COPYING
+LIBUPNPP_INSTALL_STAGING = YES
+LIBUPNPP_DEPENDENCIES = expat libcurl libupnp
+
+$(eval $(autotools-package))
Signature · 1 line
2.1.2
#1 lore raw

PATCH 2/2 package/upmpdcli: bump to version 0.8.5

New version of upmpdcli now depends on libupnpp, which was ectracted from the source and now exists in its own package.

---
 package/upmpdcli/Config.in   | 8 +++-----
 package/upmpdcli/upmpdcli.mk | 4 ++--
 2 files changed, 5 insertions(+), 7 deletions(-)
package/upmpdcli/Config.in +3 -5
index f28c775..84649d2 100644
@@ -1,12 +1,10 @@
 config BR2_PACKAGE_UPMPDCLI
 	bool "upmpdcli"
-	select BR2_PACKAGE_EXPAT
-	select BR2_PACKAGE_LIBCURL
-	select BR2_PACKAGE_LIBUPNP
 	select BR2_PACKAGE_LIBMPDCLIENT
+	select BR2_PACKAGE_LIBUPNPP
 	depends on BR2_INSTALL_LIBSTDCPP
-	depends on BR2_LARGEFILE # libupnp
-	depends on BR2_TOOLCHAIN_HAS_THREADS # libupnp
+	depends on BR2_LARGEFILE # libupnpp -> libupnp
+	depends on BR2_TOOLCHAIN_HAS_THREADS # libupnpp -> libupnp
 	depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2014R1 # Too old gcc
 	depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2013R1 # Ditto
 	depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2 # Ditto
package/upmpdcli/upmpdcli.mk +2 -2
index 547752a..a47c456 100644
@@ -4,11 +4,11 @@
 #
 ################################################################################
 
-UPMPDCLI_VERSION = 0.8.3
+UPMPDCLI_VERSION = 0.8.5
 UPMPDCLI_SITE = http://www.lesbonscomptes.com/upmpdcli/downloads
 UPMPDCLI_LICENSE = GPLv2+
 UPMPDCLI_LICENSE_FILES = COPYING
-UPMPDCLI_DEPENDENCIES = expat libcurl libupnp libmpdclient
+UPMPDCLI_DEPENDENCIES = libmpdclient libupnpp
 
 # Upmpdcli only runs if user upmpdcli exists
 define UPMPDCLI_USERS
Signature · 1 line
2.1.2
#2 lore raw

PATCH 2/2 package/upmpdcli: bump to version 0.8.5

J?rg, All,

On 2014-10-20 15:50 +0200, J?rg Krause spake thusly:

Quoted 19 lines

New version of upmpdcli now depends on libupnpp, which was ectracted from the source and now exists in its own package.

---
 package/upmpdcli/Config.in   | 8 +++-----
 package/upmpdcli/upmpdcli.mk | 4 ++--
 2 files changed, 5 insertions(+), 7 deletions(-)
package/upmpdcli/Config.in +0 -3
index f28c775..84649d2 100644
@@ -1,12 +1,10 @@
 config BR2_PACKAGE_UPMPDCLI
 	bool "upmpdcli"
-	select BR2_PACKAGE_EXPAT
-	select BR2_PACKAGE_LIBCURL
-	select BR2_PACKAGE_LIBUPNP

package/upmpdcli/Config.in line 10

Quoted 10 lines
package/upmpdcli/Config.in +3 -2
 	select BR2_PACKAGE_LIBMPDCLIENT
+	select BR2_PACKAGE_LIBUPNPP
 	depends on BR2_INSTALL_LIBSTDCPP
-	depends on BR2_LARGEFILE # libupnp
-	depends on BR2_TOOLCHAIN_HAS_THREADS # libupnp
+	depends on BR2_LARGEFILE # libupnpp -> libupnp
+	depends on BR2_TOOLCHAIN_HAS_THREADS # libupnpp -> libupnp
 	depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2014R1 # Too old gcc
 	depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2013R1 # Ditto
 	depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2 # Ditto

Ah, the dependencies in libupnpp comes from here... Are you sure they are still needed in libupnpp?

For this patch:

Regards,
Yann E. MORIN.

Quoted 25 lines
package/upmpdcli/upmpdcli.mk +2 -2
index 547752a..a47c456 100644
@@ -4,11 +4,11 @@
 #
 ################################################################################
 
-UPMPDCLI_VERSION = 0.8.3
+UPMPDCLI_VERSION = 0.8.5
 UPMPDCLI_SITE = http://www.lesbonscomptes.com/upmpdcli/downloads
 UPMPDCLI_LICENSE = GPLv2+
 UPMPDCLI_LICENSE_FILES = COPYING
-UPMPDCLI_DEPENDENCIES = expat libcurl libupnp libmpdclient
+UPMPDCLI_DEPENDENCIES = libmpdclient libupnpp
 
 # Upmpdcli only runs if user upmpdcli exists
 define UPMPDCLI_USERS
Signature · 6 lines
2.1.2

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#3 lore raw

PATCH 1/2 libupnpp: new package

In reply to Jörg Krause

J?rg, All,

On 2014-10-20 15:50 +0200, J?rg Krause spake thusly:

Quoted 1 line

[--SNIP--]

Quoted 7 lines
package/libupnpp/Config.in new file +1 -0
new file mode 100644
index 0000000..5a79452
@@ -0,0 +1,20 @@
+config BR2_PACKAGE_LIBUPNPP

package/libupnpp/Config.in line 11

Quoted 10 lines
package/libupnpp/Config.in new file +10 -0
+	bool "libupnpp"
+	select BR2_PACKAGE_EXPAT
+	select BR2_PACKAGE_LIBCURL
+	select BR2_PACKAGE_LIBUPNP
+	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_LARGEFILE # libupnp
+	depends on BR2_TOOLCHAIN_HAS_THREADS # libupnp
+	depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2014R1 # Too old gcc
+	depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2013R1 # Ditto
+	depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2 # Ditto

Nice! It proves you did quite some testing! :-)

package/libupnpp/Config.in line 18

Quoted 7 lines
package/libupnpp/Config.in new file +7 -0
+	help
+	  The libupnpp C++ library wraps libupnp for easier use by upmpdcli and
+	  upplay.
+
+	  http://www.lesbonscomptes.com/upmpdcli/
+
+comment "upmpdcli needs a toolchain w/ C++, largefile, threads"

'upmpdcli', really?

Otherwise, looks good. With the above mishap fixed, you can add my:

Regards,
Yann E. MORIN.

Quoted 29 lines
package/libupnpp/Config.in new file +2 -0
+	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_LARGEFILE || \
+		!BR2_TOOLCHAIN_HAS_THREADS
package/libupnpp/libupnpp.mk new file +14 -0
new file mode 100644
index 0000000..d46de14
@@ -0,0 +1,14 @@
+################################################################################
+#
+# libupnpp
+#
+################################################################################
+
+LIBUPNPP_VERSION = 0.8.5
+LIBUPNPP_SITE = http://www.lesbonscomptes.com/upmpdcli/downloads
+LIBUPNPP_LICENSE = GPLv2+
+LIBUPNPP_LICENSE_FILES = COPYING
+LIBUPNPP_INSTALL_STAGING = YES
+LIBUPNPP_DEPENDENCIES = expat libcurl libupnp
+
+$(eval $(autotools-package))
Signature · 6 lines
2.1.2

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#4 lore raw

PATCH 1/2 libupnpp: new package

J?rg, All,

On 2014-10-20 19:43 +0200, Yann E. MORIN spake thusly:

Quoted 14 lines

On 2014-10-20 15:50 +0200, J?rg Krause spake thusly:

Quoted 1 line

[--SNIP--]

Quoted 11 lines
package/libupnpp/Config.in new file +5 -0
new file mode 100644
index 0000000..5a79452
@@ -0,0 +1,20 @@
+config BR2_PACKAGE_LIBUPNPP
+	bool "libupnpp"
+	select BR2_PACKAGE_EXPAT
+	select BR2_PACKAGE_LIBCURL
+	select BR2_PACKAGE_LIBUPNP
Quoted 8 lines

package/libupnpp/Config.in line 11

Quoted 6 lines
package/libupnpp/Config.in new file +6 -0
+	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_LARGEFILE # libupnp
+	depends on BR2_TOOLCHAIN_HAS_THREADS # libupnp
+	depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2014R1 # Too old gcc
+	depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2013R1 # Ditto
+	depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2 # Ditto

Nice! It proves you did quite some testing! :-)

I withdraw that comment: the dependencies were copied as-is from upmpdcli. Are they still required for libupnpp?

Quoted 10 lines

package/libupnpp/Config.in line 18

Quoted 7 lines
package/libupnpp/Config.in new file +7 -0
+	help
+	  The libupnpp C++ library wraps libupnp for easier use by upmpdcli and
+	  upplay.
+
+	  http://www.lesbonscomptes.com/upmpdcli/
+
+comment "upmpdcli needs a toolchain w/ C++, largefile, threads"

'upmpdcli', really?

Quoted 3 lines

Otherwise, looks good. With the above mishap fixed, you can add my:

Sorry, I withdraw my rev tag, because of the above. That's what you get by not reviewing the whole series before replying to a patch... Sorry... :-(

J"org, that does not mean this is faulty, I just wnat to have an answer to the above before I can give my rev tag.

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#5 lore raw

PATCH 1/2 libupnpp: new package

Yann, All,

Quoted 24 lines · Yann E. MORIN

J?rg, All,

On 2014-10-20 19:43 +0200, Yann E. MORIN spake thusly:

Quoted 13 lines

On 2014-10-20 15:50 +0200, J?rg Krause spake thusly:

Quoted 1 line

[--SNIP--]

Quoted 10 lines
package/libupnpp/Config.in new file +4 -0
new file mode 100644
index 0000000..5a79452
@@ -0,0 +1,20 @@
+config BR2_PACKAGE_LIBUPNPP
+	bool "libupnpp"
+	select BR2_PACKAGE_EXPAT
+	select BR2_PACKAGE_LIBCURL
Quoted 8 lines

package/libupnpp/Config.in line 11

Quoted 7 lines
package/libupnpp/Config.in new file +7 -0
+	select BR2_PACKAGE_LIBUPNP
+	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_LARGEFILE # libupnp
+	depends on BR2_TOOLCHAIN_HAS_THREADS # libupnp
+	depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2014R1 # Too old gcc
+	depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2013R1 # Ditto
+	depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2 # Ditto

Nice! It proves you did quite some testing! :-)

Quoted 2 lines

I withdraw that comment: the dependencies were copied as-is from upmpdcli. Are they still required for libupnpp?

I've checked this. They are still required. gcc 4.3.5 does not support C++11 keyword auto.

Quoted 9 lines
Quoted 9 lines

package/libupnpp/Config.in line 18

Quoted 8 lines
package/libupnpp/Config.in new file +7 -0
+	help
+	  The libupnpp C++ library wraps libupnp for easier use by upmpdcli and
+	  upplay.
+
+	  http://www.lesbonscomptes.com/upmpdcli/
+
+comment "upmpdcli needs a toolchain w/ C++, largefile, threads"

'upmpdcli', really?

Copy & paste error. Fixed!

Quoted 11 lines
Quoted 4 lines

Otherwise, looks good. With the above mishap fixed, you can add my:

Sorry, I withdraw my rev tag, because of the above. That's what you get by not reviewing the whole series before replying to a patch... Sorry... :-(

J"org, that does not mean this is faulty, I just wnat to have an answer to the above before I can give my rev tag.

I will submit a fixed patch.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20141020/dfec6f2b/attachment.html>