Skip to contentSkip to conversation

eudev: add input group

PATCH New Gustavo Zacarias 5 participants 6 messages Oct 20, 2014 – Oct 21, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 eudev: add input group

It's used by 50-default-udev.rules for input-class devices.

---
 package/eudev/eudev.mk | 5 +++++
 1 file changed, 5 insertions(+)
package/eudev/eudev.mk +5 -0
index fd935a7..d29f762 100644
@@ -42,4 +42,9 @@ define EUDEV_INSTALL_INIT_SYSV
 	$(INSTALL) -m 0755 package/eudev/S10udev $(TARGET_DIR)/etc/init.d/S10udev
 endef
 
+# Required by default rules for input devices
+define EUDEV_USERS
+	'' -1 input -1 * - - - input group
+endef
+
 $(eval $(autotools-package))
Signature · 1 line
2.0.4
#1 lore raw

PATCH 1/1 eudev: add input group

Dear Gustavo Zacarias,

Quoted 6 lines · Gustavo Zacarias

It's used by 50-default-udev.rules for input-class devices.

---
 package/eudev/eudev.mk | 5 +++++
 1 file changed, 5 insertions(+)

I've seen the same issue a couple of days ago.

Does systemd needs a similar fix?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 eudev: add input group

Quoted 10 lines · Thomas Petazzoni

Dear Gustavo Zacarias,

Quoted 6 lines · Gustavo Zacarias

It's used by 50-default-udev.rules for input-class devices.

---
 package/eudev/eudev.mk | 5 +++++
 1 file changed, 5 insertions(+)
Quoted 5 lines

I've seen the same issue a couple of days ago.

Does systemd needs a similar fix?

I think so.

It is not that much about systemd, but more about udev rules that would try to set the ownership to some group that does not exist.

Regards,

Signature · 1 line
Samuel
#3 lore raw

PATCH 1/1 eudev: add input group

In reply to Thomas Petazzoni

Hi!

Quoted 10 lines · Thomas Petazzoni

Dear Gustavo Zacarias,

Quoted 6 lines · Gustavo Zacarias

It's used by 50-default-udev.rules for input-class devices.

---
 package/eudev/eudev.mk | 5 +++++
 1 file changed, 5 insertions(+)
Quoted 5 lines

I've seen the same issue a couple of days ago.

Does systemd needs a similar fix?

Yes it does.

In my setup, I modified system/skeleton/etc/group to add "input:x:31:"

I'll send a patch similar to the eudev one.

Best regards
ELB

#4 lore raw

PATCH 1/1 eudev: add input group

Quoted 11 lines · Eric Le Bihan
Quoted 5 lines

I've seen the same issue a couple of days ago.

Does systemd needs a similar fix?

Yes it does.

In my setup, I modified system/skeleton/etc/group to add "input:x:31:"

I'll send a patch similar to the eudev one.

Hold off on applying the patch, mkusers doesn't handle making groups without users gracefully:

...scripts/mkusers: line 369: [: too many arguments ...scripts/mkusers: line 376: [: too many arguments ...scripts/mkusers: line 400: [: input: integer expression expected ...scripts/mkusers: line 408: [: input: integer expression expected

I can respin adding an input user to match, another option is to handle the scenario in mkusers.
Regards.

#5 lore raw

PATCH 1/1 eudev: add input group

Gustavo, All,

On 2014-10-21 10:15 -0300, Gustavo Zacarias spake thusly:

Quoted 17 lines · Eric Le Bihan
Quoted 5 lines
Quoted 5 lines

I've seen the same issue a couple of days ago.

Quoted 7 lines
Quoted 1 line

Does systemd needs a similar fix?

Yes it does.

In my setup, I modified system/skeleton/etc/group to add "input:x:31:"

I'll send a patch similar to the eudev one.

Hold off on applying the patch, mkusers doesn't handle making groups without users gracefully:

Quoted 7 lines

...scripts/mkusers: line 369: [: too many arguments ...scripts/mkusers: line 376: [: too many arguments ...scripts/mkusers: line 400: [: input: integer expression expected ...scripts/mkusers: line 408: [: input: integer expression expected

I can respin adding an input user to match, another option is to handle the scenario in mkusers.

I can look at handling this in mkusers, certainly.

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'