Skip to contentSkip to conversation

util-linux: do not disable non existing directories

PATCH New Peter Seiderer 2 participants 3 messages Oct 20, 2014

lore
Share & tools
lore

Peter Seiderer

author
#0 lore raw

PATCH 1/1 util-linux: do not disable non existing directories

Legacy disabled sub directories mount-deprecated and fdisks do not longer exist in util-linux-2.25.1 source package.

Signed-off-by Peter Seiderer <[email protected]>
---
 package/util-linux/util-linux.mk | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
package/util-linux/util-linux.mk +2 -3
index ebbab61..7586ab3 100644
@@ -102,9 +102,8 @@ HOST_UTIL_LINUX_CONF_OPTS += \
 ifeq ($(BR2_PACKAGE_UTIL_LINUX_BINARIES),)
 define UTIL_LINUX_DISABLE_TOOLS
 	$(SED) '/schedutils/d' -e '/text-utils/d' -e '/term-utils/d' \
-		-e '/login-utils/d' -e '/mount-deprecated/d' \
-		-e '/sys-utils/d' -e '/misc-utils/d' -e '/disk-utils/d' \
-		-e '/fdisks/d' $(@D)/Makefile.am
+		-e '/login-utils/d' -e '/sys-utils/d' -e '/misc-utils/d' \
+		-e '/disk-utils/d' $(@D)/Makefile.am
 endef
 UTIL_LINUX_PRE_PATCH_HOOKS += UTIL_LINUX_DISABLE_TOOLS
 endif
Signature · 1 line
1.8.1.4
#1 lore raw

PATCH 1/1 util-linux: do not disable non existing directories

Dear Peter Seiderer,

Quoted 14 lines · Peter Seiderer

Legacy disabled sub directories mount-deprecated and fdisks do not longer exist in util-linux-2.25.1 source package.

Signed-off-by Peter Seiderer <[email protected]>
---
 package/util-linux/util-linux.mk | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
package/util-linux/util-linux.mk +0 -0
index ebbab61..7586ab3 100644
@@ -102,9 +102,8 @@ HOST_UTIL_LINUX_CONF_OPTS += \
 ifeq ($(BR2_PACKAGE_UTIL_LINUX_BINARIES),)

package/util-linux/util-linux.mk HOST_UTIL_LINUX_CONF_OPTS += \ · line 109

Quoted 10 lines
package/util-linux/util-linux.mk +2 -3
 define UTIL_LINUX_DISABLE_TOOLS
 	$(SED) '/schedutils/d' -e '/text-utils/d' -e '/term-utils/d' \
-		-e '/login-utils/d' -e '/mount-deprecated/d' \
-		-e '/sys-utils/d' -e '/misc-utils/d' -e '/disk-utils/d' \
-		-e '/fdisks/d' $(@D)/Makefile.am
+		-e '/login-utils/d' -e '/sys-utils/d' -e '/misc-utils/d' \
+		-e '/disk-utils/d' $(@D)/Makefile.am
 endef
 UTIL_LINUX_PRE_PATCH_HOOKS += UTIL_LINUX_DISABLE_TOOLS
 endif

I haven't looked at the details, but can't we use --disable-all-programs, like we do for the host variant of util-linux ?

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#2 lore raw

PATCH 1/1 util-linux: do not disable non existing directories

Hello Thomas,

Quoted 28 lines

Gesendet: Montag, 20. Oktober 2014 um 23:19 Uhr
Von: "Thomas Petazzoni" <[email protected]>
An: "Peter Seiderer" <[email protected]>
Cc: buildroot at busybox.net
Betreff: Re: [Buildroot] [PATCH] util-linux: do not disable non existing directories

Dear Peter Seiderer,

Quoted 19 lines · Peter Seiderer

Legacy disabled sub directories mount-deprecated and fdisks do not longer exist in util-linux-2.25.1 source package.

Signed-off-by Peter Seiderer <[email protected]>
---
 package/util-linux/util-linux.mk | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
package/util-linux/util-linux.mk +0 -3
index ebbab61..7586ab3 100644
@@ -102,9 +102,8 @@ HOST_UTIL_LINUX_CONF_OPTS += \
 ifeq ($(BR2_PACKAGE_UTIL_LINUX_BINARIES),)
 define UTIL_LINUX_DISABLE_TOOLS
 	$(SED) '/schedutils/d' -e '/text-utils/d' -e '/term-utils/d' \
-		-e '/login-utils/d' -e '/mount-deprecated/d' \
-		-e '/sys-utils/d' -e '/misc-utils/d' -e '/disk-utils/d' \
-		-e '/fdisks/d' $(@D)/Makefile.am
Quoted 8 lines

package/util-linux/util-linux.mk HOST_UTIL_LINUX_CONF_OPTS += \ · line 109

Quoted 5 lines
package/util-linux/util-linux.mk +2 -0
+		-e '/login-utils/d' -e '/sys-utils/d' -e '/misc-utils/d' \
+		-e '/disk-utils/d' $(@D)/Makefile.am
 endef
 UTIL_LINUX_PRE_PATCH_HOOKS += UTIL_LINUX_DISABLE_TOOLS
 endif

I haven't looked at the details, but can't we use --disable-all-programs, like we do for the host variant of util-linux ?

Will take a look at it...., but needs some time...

Regards,
Peter

Quoted 9 lines

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com