package/sysvinit: remove inline comment from root remount
PATCH 1/1 package/sysvinit: remove inline comment from root remount
It breaks the root rw remount as explained in bug #7442. Thanks to joymarquis at hotmail.com for pointing it out.
--- package/sysvinit/inittab | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/sysvinit/inittab +1 -1
@@ -5,7 +5,7 @@ id:1:initdefault: proc::sysinit:/bin/mount -t proc proc /proc -rwmo::sysinit:/bin/mount -o remount,rw / # REMOUNT_ROOTFS_RW +rwmo::sysinit:/bin/mount -o remount,rw / dpts::sysinit:/bin/mkdir -p /dev/pts dshm::sysinit:/bin/mkdir -p /dev/shm moun::sysinit:/bin/mount -a
Signature · 1 line
2.0.4
Yann E. MORIN
NAKPATCH 1/1 package/sysvinit: remove inline comment from root remount
Gustavo, All,
On 2014-10-20 16:18 -0300, Gustavo Zacarias spake thusly:
Quoted 4 lines
It breaks the root rw remount as explained in bug #7442. Thanks to joymarquis at hotmail.com for pointing it out.
Signed-off-by Gustavo Zacarias <[email protected]>
NAK, because that's what is used to decide whether to remount root RW or not (from system/system.mk ):
ifeq ($(BR2_TARGET_GENERIC_REMOUNT_ROOTFS_RW),y)
# Find commented line, if any, and remove leading '#'s
define SYSTEM_REMOUNT_RW
$(SED) '/^#.*# REMOUNT_ROOTFS_RW$$/s~^#\+~~' $(TARGET_DIR)/etc/inittab
endef
else
# Find uncommented line, if any, and add a leading '#'
define SYSTEM_REMOUNT_RW
$(SED) '/^[^#].*# REMOUNT_ROOTFS_RW$$/s~^~#~' $(TARGET_DIR)/etc/inittab
endef
endif
TARGET_FINALIZE_HOOKS += SYSTEM_REMOUNT_RWWe must find another solution.
Regards,
Yann E. MORIN.
Quoted 24 lines
--- package/sysvinit/inittab | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)package/sysvinit/inittab +1
-1@@ -5,7 +5,7 @@ id:1:initdefault: proc::sysinit:/bin/mount -t proc proc /proc -rwmo::sysinit:/bin/mount -o remount,rw / # REMOUNT_ROOTFS_RW +rwmo::sysinit:/bin/mount -o remount,rw / dpts::sysinit:/bin/mkdir -p /dev/pts dshm::sysinit:/bin/mkdir -p /dev/shm moun::sysinit:/bin/mount -aSignature · 6 lines
2.0.4 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 1/1 package/sysvinit: remove inline comment from root remount
Quoted 24 lines · Yann E. MORIN
Gustavo, All,
On 2014-10-20 16:18 -0300, Gustavo Zacarias spake thusly:
Quoted 4 lines
It breaks the root rw remount as explained in bug #7442. Thanks to joymarquis at hotmail.com for pointing it out.
Signed-off-by Gustavo Zacarias <[email protected]>NAK, because that's what is used to decide whether to remount root RW or not (from
system/system.mk):ifeq ($(BR2_TARGET_GENERIC_REMOUNT_ROOTFS_RW),y) # Find commented line, if any, and remove leading '#'s define SYSTEM_REMOUNT_RW $(SED) '/^#.*# REMOUNT_ROOTFS_RW$$/s~^#\+~~' $(TARGET_DIR)/etc/inittab endef else # Find uncommented line, if any, and add a leading '#' define SYSTEM_REMOUNT_RW $(SED) '/^[^#].*# REMOUNT_ROOTFS_RW$$/s~^~#~' $(TARGET_DIR)/etc/inittab endef endif TARGET_FINALIZE_HOOKS += SYSTEM_REMOUNT_RW
Quoted 1 line
We must find another solution.
Searching for the comment isn't pretty, i'd just:
rwmo::sysinit:/bin/mount -o remount,rw / (sysvinit) null::sysinit:/bin/mount -o remount,rw / (skeleton)
And nuke them when the root must be RO by searching for "mount -o remount,rw /".
But really well done that should all move to an initscript at the S00 order that handles ALL of the filesystems at once in a predictable way via /etc/fstab, there's no excuse.
Regards.