staging: Fix checkpatch issue with brackets in rtw_ap.c
PATCH 1/1 staging: Fix checkpatch issue with brackets in rtw_ap.c
Fix checkpatch error message with opening bracket of if statement, not being on the same line as a if statement in rtw_ap.c
--- drivers/staging/rtl8723au/core/rtw_ap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/rtl8723au/core/rtw_ap.c +1 -2
@@ -1567,8 +1567,7 @@ void bss_cap_update_on_sta_join23a(struct rtw_adapter *padapter, struct sta_info } } -if (rtw_ht_operation_update (padapter) >0 ) - { +if (rtw_ht_operation_update (padapter) >0 ) {update_beacon23a (padapter,WLAN_EID_HT_CAPABILITY ,NULL , false);update_beacon23a (padapter,WLAN_EID_HT_OPERATION ,NULL , true); }
Signature · 1 line
1.9.1
PATCH 1/1 staging: Fix checkpatch issue with brackets in rtw_ap.c
Quoted 7 lines · Nicholas Krause
Fix checkpatch error message with opening bracket of if statement, not being on the same line as a if statement in
rtw_ap.cSigned-off-by Nicholas Krause <[email protected]>--- drivers/staging/rtl8723au/core/rtw_ap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
I will say, it does appear you finally got a patch right. Only issue I have is that you corrected only one of the many instances of the same problem in this file.
If you are going to correct one instance, might as well fix them all.
Quoted 23 lines
drivers/staging/rtl8723au/core/rtw_ap.c +1
-3@@ -1567,8 +1567,7 @@ void bss_cap_update_on_sta_join23a(struct rtw_adapter *padapter, struct sta_info } } -if (rtw_ht_operation_update (padapter) >0 ) - { +if (rtw_ht_operation_update (padapter) >0 ) {update_beacon23a (padapter,WLAN_EID_HT_CAPABILITY ,NULL , false);update_beacon23a (padapter,WLAN_EID_HT_OPERATION ,NULL , true); } --1.9.1
_______________________________________________
Kernelnewbies mailing list
Kernelnewbies at kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Signature · 2 lines
Cheers, Jeff
PATCH 1/1 staging: Fix checkpatch issue with brackets in rtw_ap.c
Quoted 10 lines · Jeff Kirsher
Quoted 7 lines · Nicholas Krause
Fix checkpatch error message with opening bracket of if statement, not being on the same line as a if statement in
rtw_ap.cSigned-off-by Nicholas Krause <[email protected]>--- drivers/staging/rtl8723au/core/rtw_ap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)I will say, it does appear you finally got a patch right. Only issue
i agree to that. Finally Nick has sent a patch which is not having any style error, applies properly , doesnot change the logic.
Quoted 3 lines
I have is that you corrected only one of the many instances of the same problem in this file.
If you are going to correct one instance, might as well fix them all.
don't you think if he tries to fix them all at one go, he will again mess up everything ?
thanks
sudip
Quoted 35 lines
Quoted 24 lines
drivers/staging/rtl8723au/core/rtw_ap.c +1
-3@@ -1567,8 +1567,7 @@ void bss_cap_update_on_sta_join23a(struct rtw_adapter *padapter, struct sta_info } } -if (rtw_ht_operation_update (padapter) >0 ) - { +if (rtw_ht_operation_update (padapter) >0 ) {update_beacon23a (padapter,WLAN_EID_HT_CAPABILITY ,NULL , false);update_beacon23a (padapter,WLAN_EID_HT_OPERATION ,NULL , true); } --1.9.1
_______________________________________________
Kernelnewbies mailing list
Kernelnewbies at kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbiesSignature · 7 lines
Cheers, Jeff _______________________________________________ Kernelnewbies mailing list Kernelnewbies at kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
PATCH 1/1 staging: Fix checkpatch issue with brackets in rtw_ap.c
Good to hear, I will try tomorrow to send it a correct patch fixing out the issues like the one found in this patch in the same file. I am pretty certain I known how to do a patch how. Nick
Quoted 54 lines · Sudip Mukherjee
Quoted 10 lines · Jeff Kirsher
Quoted 7 lines · Nicholas Krause
Fix checkpatch error message with opening bracket of if statement, not being on the same line as a if statement in
rtw_ap.cSigned-off-by Nicholas Krause <[email protected]>--- drivers/staging/rtl8723au/core/rtw_ap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)I will say, it does appear you finally got a patch right. Only issue
i agree to that. Finally Nick has sent a patch which is not having any style error, applies properly , doesnot change the logic.
Quoted 3 lines
I have is that you corrected only one of the many instances of the same problem in this file.
If you are going to correct one instance, might as well fix them all.don't you think if he tries to fix them all at one go, he will again mess up everything ?
thanks
sudipQuoted 35 lines
Quoted 24 lines
drivers/staging/rtl8723au/core/rtw_ap.c +1
-3@@ -1567,8 +1567,7 @@ void bss_cap_update_on_sta_join23a(struct rtw_adapter *padapter, struct sta_info } } -if (rtw_ht_operation_update (padapter) >0 ) - { +if (rtw_ht_operation_update (padapter) >0 ) {update_beacon23a (padapter,WLAN_EID_HT_CAPABILITY ,NULL , false);update_beacon23a (padapter,WLAN_EID_HT_OPERATION ,NULL , true); } --1.9.1
_______________________________________________
Kernelnewbies mailing list
Kernelnewbies at kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbiesSignature · 7 lines
Cheers, Jeff _______________________________________________ Kernelnewbies mailing list Kernelnewbies at kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
PATCH 1/1 staging: Fix checkpatch issue with brackets in rtw_ap.c
Quoted 3 lines · nick
Good to hear, I will try tomorrow to send it a correct patch fixing out the issues like the one found in this patch in the same file. I am pretty certain I known how to do a patch how. Nick
just make sure that you do only kind of change in one patch. For different types of changes , you need to send more than one patch in series .
Quoted 56 lines · Sudip Mukherjee
Quoted 54 lines · Jeff Kirsher
Quoted 10 lines · Nicholas Krause
Quoted 7 lines
Fix checkpatch error message with opening bracket of if statement, not being on the same line as a if statement in
rtw_ap.cSigned-off-by Nicholas Krause <[email protected]>--- drivers/staging/rtl8723au/core/rtw_ap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)I will say, it does appear you finally got a patch right. Only issue
i agree to that. Finally Nick has sent a patch which is not having any style error, applies properly , doesnot change the logic.
Quoted 3 lines
I have is that you corrected only one of the many instances of the same problem in this file.
If you are going to correct one instance, might as well fix them all.don't you think if he tries to fix them all at one go, he will again mess up everything ?
thanks
sudipQuoted 35 lines
Quoted 20 lines
drivers/staging/rtl8723au/core/rtw_ap.c +1
-3@@ -1567,8 +1567,7 @@ void bss_cap_update_on_sta_join23a(struct rtw_adapter *padapter, struct sta_info } } -if (rtw_ht_operation_update (padapter) >0 ) - { +if (rtw_ht_operation_update (padapter) >0 ) {update_beacon23a (padapter,WLAN_EID_HT_CAPABILITY ,NULL , false);update_beacon23a (padapter,WLAN_EID_HT_OPERATION ,NULL , true); } --1.9.1
Quoted 4 lines
_______________________________________________
Kernelnewbies mailing list
Kernelnewbies at kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies--
Cheers,
Jeff_______________________________________________
Kernelnewbies mailing list
Kernelnewbies at kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
PATCH 1/1 staging: Fix checkpatch issue with brackets in rtw_ap.c
In reply to nickQuoted 3 lines · nick
Good to hear, I will try tomorrow to send it a correct patch fixing out the issues like the one found in this patch in the same file. I am pretty certain I known how to do a patch how. Nick
Take your time Nick, please do not rush it. You have shown that when you rush things, nothing but bad things happen.
Quoted 52 lines · Sudip Mukherjee
Quoted 50 lines · Jeff Kirsher
Quoted 10 lines · Nicholas Krause
Quoted 7 lines
Fix checkpatch error message with opening bracket of if statement, not being on the same line as a if statement in
rtw_ap.cSigned-off-by Nicholas Krause <[email protected]>--- drivers/staging/rtl8723au/core/rtw_ap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)I will say, it does appear you finally got a patch right. Only issue
i agree to that. Finally Nick has sent a patch which is not having any style error, applies properly , doesnot change the logic.
Quoted 3 lines
I have is that you corrected only one of the many instances of the same problem in this file.
If you are going to correct one instance, might as well fix them all.don't you think if he tries to fix them all at one go, he will again mess up everything ?
thanks
sudipQuoted 31 lines
Quoted 24 lines
drivers/staging/rtl8723au/core/rtw_ap.c +1
-3@@ -1567,8 +1567,7 @@ void bss_cap_update_on_sta_join23a(struct rtw_adapter *padapter, struct sta_info } } -if (rtw_ht_operation_update (padapter) >0 ) - { +if (rtw_ht_operation_update (padapter) >0 ) {update_beacon23a (padapter,WLAN_EID_HT_CAPABILITY ,NULL , false);update_beacon23a (padapter,WLAN_EID_HT_OPERATION ,NULL , true); } --1.9.1
_______________________________________________
Kernelnewbies mailing list
Kernelnewbies at kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbiesSignature · 2 lines
Cheers, Jeff
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
_______________________________________________
Kernelnewbies mailing list
Kernelnewbies at kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
Url : http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20141021/4d65de01/attachment-0001.bin
PATCH 1/1 staging: Fix checkpatch issue with brackets in rtw_ap.c
In reply to Sudip MukherjeeQuoted 15 lines · Sudip Mukherjee
Quoted 1 line · Jeff Kirsher
On Tue, Oct 21, 2014 at 10:34 AM, Nicholas Krause
Quoted 9 lines · <[email protected]> wrote:
Quoted 7 lines
Fix checkpatch error message with opening bracket of if statement, not being on the same line as a if statement in
rtw_ap.cSigned-off-by Nicholas Krause <[email protected]>--- drivers/staging/rtl8723au/core/rtw_ap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)I will say, it does appear you finally got a patch right. Only
issue
i agree to that. Finally Nick has sent a patch which is not having any style error, applies properly , doesnot change the logic.
Quoted 6 lines
Quoted 3 lines
I have is that you corrected only one of the many instances of the same problem in this file.
If you are going to correct one instance, might as well fix themall.
don't you think if he tries to fix them all at one go, he will again mess up everything ?
Possibly... trust me, I am not jumping on the pro-nick band wagon here.
After many months of failed attempts, I am not holding my breath.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
Url : http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20141021/289f186a/attachment.bin