Skip to contentSkip to conversation

mfd: AXP20x: Add support for AXP202 and AXP209

PATCH Superseded Carlo Caione 5 participants 14 messages Jun 29, 2014 – Dec 3, 2014

Subsystems (7)

v7 of 8 Superseded Latest is v8 →

lore
Share & tools
lore
#0 lore raw

v7 cover mfd: AXP20x: Add support for AXP202 and AXP209

During the merging of v6 several patches were left out. This v7 comprises all the patches that are still pending.

//--

AXP209 and AXP202 are the PMUs (Power Management Unit) used by A10, A13 and A20 SoCs and developed by X-Powers, a sister company of Allwinner. AXP20x comprises an adaptive USB-Compatible PWM charger, 2 BUCK DC-DC converters, 5 LDOs, multiple 12-bit ADCs of voltage, current and temperature as well as 4 configurable GPIOs.

This set of patches introduces the core driver and support for two different subsystems:
- Regulators
- PEK (Power Enable Key)

Changes since v1:

- Added a new standalone patch for defconfig

- MFD core:
* Removed axp,system-power-controller property

- Bindings documentation:
* Corrected description for dcdc-workmode property
* Removed unused axp20x-pek compatible

- Input misc PEK driver:
* Fixed seconds in lower case

- Regulators subsystem:
* Fixed axp20x_set_suspend_voltage()
* Switched to using multi-bit control for regulators
* When "regulators" node is not found driver doesn't quit
* Driver is now using devm_regulator_register()
* Added module_platform_driver() instead of subsys_initcall()

- DT:
* Added new DTSI for AXP209
* Added support for cubietruck and olinuxino-micro

Changes since v2:

- Added a new patch for multi_v7_defconfig to enable MFD core and subsystems

- DT:
* Dropped axp,system-power-controller property from DTS
* Moved compatible and interrupt-related properties from the DTSI file to the DTS board files

- Regulators subsystem:
* Deleted useless struct axp20x_regulators
* Added a warning when out of specs values are used for the dcdc frequency

- MFD core:
* Fixed coding style
* Removed IDs from device table for i2c

- Bindings documentation:
* Several corrections and fixes

Changes since v3:

- Removed x-powers-axp209.dtsi file
- Rewritten bindings document

- MFD core:
* Fixed casting
* Better comments / documentation

- Input misc PEK driver:
* Timings are now expressed in ms and the sysfs appies the closest possible value
* No more useless pretty-printing
* Removed devm_request_threaded_irq in favour of devm_request_any_context_irq
* Moved from input attributes to platform device attributes

- Regulators subsystem:
* Removed suspend mode (axp20x_set_suspend_voltage)
* Added regulators input supply

- DT:
* DTs doesn't include anymore the dtsi
* Added input supplies for regulators

Changes since v4:

- Removed regulator patches already applied / acked by Mark Brown

- Input misc PEK driver:
* Don't print anymore the "us" unit
* Added cleanup for attributes when unbindind the device
* Fixed error code returned when device_create_file() fails

- DT:
* Enable all the regulators on at boot-time
* Removed min and max microvolts for all the regulators but DCDC2
* Moved the axp_ipsout regulator outside the MFD node

- MFD core:
* The supply regulators are now specified in the MFD driver using regulator_bulk_register_supply_alias() and the .parent_supplies in the MFD cell

Changes since v5:
- Added ACKs
- Fixed compilation warning (reported by Hans De Goede)
- Vendor-prefixes are now sorted
- Removed DT patch

Carlo Caione (6):
mfd: AXP20x: Add bindings documentation
dt-bindings: add vendor-prefix for X-Powers
input: misc: Add driver for AXP20x Power Enable Key
input: misc: Add ABI docs for AXP20x PEK
ARM: sunxi: Add AXP20x support in defconfig
ARM: sunxi: Add AXP20x support multi_v7_defconfig

 .../ABI/testing/sysfs-driver-input-axp-pek         |  11 +
 Documentation/devicetree/bindings/mfd/axp20x.txt   |  93 +++++++
 .../devicetree/bindings/vendor-prefixes.txt        |   1 +
 arch/arm/configs/multi_v7_defconfig                |   3 +
 arch/arm/configs/sunxi_defconfig                   |   3 +
 drivers/input/misc/Kconfig                         |  11 +
 drivers/input/misc/Makefile                        |   1 +
 drivers/input/misc/axp20x-pek.c                    | 281 +++++++++++++++++++++
 8 files changed, 404 insertions(+)
 create mode 100644 Documentation/ABI/testing/sysfs-driver-input-axp-pek
 create mode 100644 Documentation/devicetree/bindings/mfd/axp20x.txt
 create mode 100644 drivers/input/misc/axp20x-pek.c
Signature · 1 line
1.9.1
#1 lore raw

PATCH v7 1/6 mfd: AXP20x: Add bindings documentation

Bindings documentation for the AXP20x driver. In this file also sub-nodes are documented.

---
 Documentation/devicetree/bindings/mfd/axp20x.txt | 93 ++++++++++++++++++++++++
 1 file changed, 93 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mfd/axp20x.txt
Documentation/devicetree/bindings/mfd/axp20x.txt new file +93 -0
new file mode 100644
index 0000000..cc9e01b
@@ -0,0 +1,93 @@
+AXP202/AXP209 device tree bindings
+
+The axp20x family current members :-
+axp202 (X-Powers)
+axp209 (X-Powers)
+
+Required properties:
+- compatible: "x-powers,axp202" or "x-powers,axp209"
+- reg: The I2C slave address for the AXP chip
+- interrupt-parent: The parent interrupt controller
+- interrupts: Interrupt specifiers for interrupt sources
+- interrupt-controller: axp20x has its own internal IRQs
+- #interrupt-cells: Should be set to 1
+- acin-supply: The input supply for LDO1
+- vin2-supply: The input supply for DCDC2
+- vin3-supply: The input supply for DCDC3
+- ldo24in-supply: The input supply for LDO2, LDO4
+- ldo3in-supply: The input supply for LDO3
+- ldo5in-supply: The input supply for LDO5
+
+- regulators: A node that houses a sub-node for each regulator. The regulators are
+	      bound using their name as listed here: dcdc2, dcdc3, ldo1, ldo2,
+	      ldo3, ldo4, ldo5.  The bindings details of individual regulator
+	      device can be found in:
+	      Documentation/devicetree/bindings/regulator/regulator.txt with
+	      the exception of x-powers,dcdc-freq
+- x-powers,dcdc-freq: defines the work frequency of DC-DC in KHz
+		      (range: 750-1875). Default: 1.5MHz
+
+Optional properties for DCDCs:
+- x-powers,dcdc-workmode: 1 for PWM mode, 0 for AUTO mode
+			  Default: AUTO mode
+
+Example:
+
+axp209: pmic at 34 {
+	compatible = "x-powers,axp209";
+	reg = <0x34>;
+	interrupt-parent = <&nmi_intc>;
+	interrupts = <0 8>;
+
+	interrupt-controller;
+	#interrupt-cells = <1>;
+
+	acin-supply = <&axp_ipsout_reg>;
+	vin2-supply = <&axp_ipsout_reg>;
+	vin3-supply = <&axp_ipsout_reg>;
+	ldo24in-supply = <&axp_ipsout_reg>;
+	ldo3in-supply = <&axp_ipsout_reg>;
+	ldo5in-supply = <&axp_ipsout_reg>;
+
+	regulators {
+		x-powers,dcdc-freq = <1500>;
+
+		axp_vcore_reg: dcdc2 {
+			regulator-min-microvolt = <700000>;
+			regulator-max-microvolt = <2275000>;
+			regulator-always-on;
+		};
+
+		axp_ddr_reg: dcdc3 {
+			regulator-min-microvolt = <700000>;
+			regulator-max-microvolt = <3500000>;
+			regulator-always-on;
+		};
+
+		axp_rtc_reg: ldo1 {
+			regulator-always-on;
+		};
+
+		axp_analog_reg: ldo2 {
+			regulator-min-microvolt = <1800000>;
+			regulator-max-microvolt = <3300000>;
+			regulator-always-on;
+		};
+
+		axp_pll_reg: ldo3 {
+			regulator-min-microvolt = <700000>;
+			regulator-max-microvolt = <3500000>;
+		};
+
+		axp_hdmi_reg: ldo4 {
+			regulator-min-microvolt = <1250000>;
+			regulator-max-microvolt = <3300000>;
+		};
+
+		axp_mic_reg: ldo5 {
+			regulator-min-microvolt = <1800000>;
+			regulator-max-microvolt = <3300000>;
+		};
+	};
+};
+
Signature · 1 line
1.9.1
#2 lore raw

PATCH v7 1/6 mfd: AXP20x: Add bindings documentation

Quoted 17 lines · Carlo Caione

Bindings documentation for the AXP20x driver. In this file also sub-nodes are documented.

---
 Documentation/devicetree/bindings/mfd/axp20x.txt | 93 ++++++++++++++++++++++++
 1 file changed, 93 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mfd/axp20x.txt
Documentation/devicetree/bindings/mfd/axp20x.txt new file +1 -0
new file mode 100644
index 0000000..cc9e01b
@@ -0,0 +1,93 @@
+AXP202/AXP209 device tree bindings

Documentation/devicetree/bindings/mfd/axp20x.txt line 11

Quoted 10 lines
Documentation/devicetree/bindings/mfd/axp20x.txt new file +10 -0
+
+The axp20x family current members :-
+axp202 (X-Powers)
+axp209 (X-Powers)
+
+Required properties:
+- compatible: "x-powers,axp202" or "x-powers,axp209"
+- reg: The I2C slave address for the AXP chip
+- interrupt-parent: The parent interrupt controller
+- interrupts: Interrupt specifiers for interrupt sources

How many, what are they?

Quoted 11 lines
Documentation/devicetree/bindings/mfd/axp20x.txt new file +11 -0
+- interrupt-controller: axp20x has its own internal IRQs
+- #interrupt-cells: Should be set to 1
+- acin-supply: The input supply for LDO1
+- vin2-supply: The input supply for DCDC2
+- vin3-supply: The input supply for DCDC3
+- ldo24in-supply: The input supply for LDO2, LDO4
+- ldo3in-supply: The input supply for LDO3
+- ldo5in-supply: The input supply for LDO5
+
+- regulators: A node that houses a sub-node for each regulator. The regulators are
+	      bound using their name as listed here: dcdc2, dcdc3, ldo1, ldo2,

Documentation/devicetree/bindings/mfd/axp20x.txt line 32

Quoted 10 lines
Documentation/devicetree/bindings/mfd/axp20x.txt new file +10 -0
+	      ldo3, ldo4, ldo5.  The bindings details of individual regulator
+	      device can be found in:
+	      Documentation/devicetree/bindings/regulator/regulator.txt with
+	      the exception of x-powers,dcdc-freq
+- x-powers,dcdc-freq: defines the work frequency of DC-DC in KHz
+		      (range: 750-1875). Default: 1.5MHz
+
+Optional properties for DCDCs:
+- x-powers,dcdc-workmode: 1 for PWM mode, 0 for AUTO mode
+			  Default: AUTO mode

When would I want to select PWM mode, and why should this be in the DT?

Thanks,
Mark.

#3 lore raw

[linux-sunxi] Re: [PATCH v7 1/6] mfd: AXP20x: Add bindings documentation

Hi Mark,

I'm (hopefully) picking up the work for this series.

Quoted 22 lines · Mark Rutland
Quoted 21 lines · Carlo Caione

Bindings documentation for the AXP20x driver. In this file also sub-nodes are documented.

---
 Documentation/devicetree/bindings/mfd/axp20x.txt | 93 ++++++++++++++++++++++++
 1 file changed, 93 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mfd/axp20x.txt
Documentation/devicetree/bindings/mfd/axp20x.txt new file +5 -0
new file mode 100644
index 0000000..cc9e01b
@@ -0,0 +1,93 @@
+AXP202/AXP209 device tree bindings
+
+The axp20x family current members :-
+axp202 (X-Powers)
+axp209 (X-Powers)
Quoted 8 lines

Documentation/devicetree/bindings/mfd/axp20x.txt line 11

Quoted 6 lines
Documentation/devicetree/bindings/mfd/axp20x.txt new file +6 -0
+
+Required properties:
+- compatible: "x-powers,axp202" or "x-powers,axp209"
+- reg: The I2C slave address for the AXP chip
+- interrupt-parent: The parent interrupt controller
+- interrupts: Interrupt specifiers for interrupt sources

How many, what are they?

Now reads: SoC external interrupt / NMI connected to the PMIC's IRQ pin

Quoted 15 lines
Quoted 15 lines
Documentation/devicetree/bindings/mfd/axp20x.txt new file +15 -0
+- interrupt-controller: axp20x has its own internal IRQs
+- #interrupt-cells: Should be set to 1
+- acin-supply: The input supply for LDO1
+- vin2-supply: The input supply for DCDC2
+- vin3-supply: The input supply for DCDC3
+- ldo24in-supply: The input supply for LDO2, LDO4
+- ldo3in-supply: The input supply for LDO3
+- ldo5in-supply: The input supply for LDO5
+
+- regulators: A node that houses a sub-node for each regulator. The regulators are
+           bound using their name as listed here: dcdc2, dcdc3, ldo1, ldo2,
+           ldo3, ldo4, ldo5.  The bindings details of individual regulator
+           device can be found in:
+           Documentation/devicetree/bindings/regulator/regulator.txt with
+           the exception of x-powers,dcdc-freq
Quoted 8 lines

Documentation/devicetree/bindings/mfd/axp20x.txt line 32

Quoted 6 lines
Documentation/devicetree/bindings/mfd/axp20x.txt new file +6 -0
+- x-powers,dcdc-freq: defines the work frequency of DC-DC in KHz
+                   (range: 750-1875). Default: 1.5MHz
+
+Optional properties for DCDCs:
+- x-powers,dcdc-workmode: 1 for PWM mode, 0 for AUTO mode
+                       Default: AUTO mode

When would I want to select PWM mode, and why should this be in the DT?

Expanded description:

"""
The DCDC regulators work in a mixed PWM/PFM mode, using PFM under light loads and switching to PWM for heavier loads. Forcing PWM mode trades efficiency under light loads for lower output noise. This probably makes sense for HiFi audio related applications that aren't battery constrained. """

As I'm not an electronics person, I really can't say under what circumstances one would force the PMIC into PWM mode. The expanded description is an educated guess based on research on the internet about PWM and PFM.

I think it makes sense to put this in the DT. The vendor building the board/DT is in the best position to know the constraints and requirements of the board, and can decide whether the trade off makes sense. As for the boards/DTs already out there, we can just leave it in auto mode.

Regards
ChenYu

#4 lore raw

PATCH v7 2/6 dt-bindings: add vendor-prefix for X-Powers

In reply to Carlo Caione
---
 Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/vendor-prefixes.txt +1 -0
index 46a311e..0d5a80c 100644
@@ -140,6 +140,7 @@ voipac	Voipac Technologies s.r.o.
 winbond Winbond Electronics corp.
 wlf	Wolfson Microelectronics
 wm	Wondermedia Technologies, Inc.
+x-powers	X-Powers
 xes	Extreme Engineering Solutions (X-ES)
 xlnx	Xilinx
 zyxel	ZyXEL Communications Corp.
Signature · 1 line
1.9.1
#5 lore raw

PATCH v7 3/6 input: misc: Add driver for AXP20x Power Enable Key

In reply to Carlo Caione

This patch add support for the Power Enable Key found on MFD AXP202 and AXP209. Besides the basic support for the button, the driver adds two entries in sysfs to configure the time delay for power on/off.

---
 drivers/input/misc/Kconfig      |  11 ++
 drivers/input/misc/Makefile     |   1 +
 drivers/input/misc/axp20x-pek.c | 281 ++++++++++++++++++++++++++++++++++++++++
 3 files changed, 293 insertions(+)
 create mode 100644 drivers/input/misc/axp20x-pek.c
drivers/input/misc/Kconfig +11 -0
index 2ff4425..3fa6229 100644
@@ -393,6 +393,17 @@ config INPUT_RETU_PWRBUTTON
 	  To compile this driver as a module, choose M here. The module will
 	  be called retu-pwrbutton.
 
+config INPUT_AXP20X_PEK
+	tristate "X-Powers AXP20X power button driver"
+	depends on MFD_AXP20X
+	help
+	  Say Y here if you want to enable power key reporting via the
+	  AXP20X PMIC.
+
+	  To compile this driver as a module, choose M here. The module will
+	  be called axp20x-pek.
+
+
 config INPUT_TWL4030_PWRBUTTON
 	tristate "TWL4030 Power button Driver"
 	depends on TWL4030_CORE
drivers/input/misc/Makefile +1 -0
index 4955ad3..a25ad18 100644
@@ -50,6 +50,7 @@ obj-$(CONFIG_INPUT_POWERMATE)		+= powermate.o
 obj-$(CONFIG_INPUT_PWM_BEEPER)		+= pwm-beeper.o
 obj-$(CONFIG_INPUT_RB532_BUTTON)	+= rb532_button.o
 obj-$(CONFIG_INPUT_RETU_PWRBUTTON)	+= retu-pwrbutton.o
+obj-$(CONFIG_INPUT_AXP20X_PEK)		+= axp20x-pek.o
 obj-$(CONFIG_INPUT_GPIO_ROTARY_ENCODER)	+= rotary_encoder.o
 obj-$(CONFIG_INPUT_SGI_BTNS)		+= sgi_btns.o
 obj-$(CONFIG_INPUT_SIRFSOC_ONKEY)	+= sirfsoc-onkey.o
drivers/input/misc/axp20x-pek.c new file +281 -0

281 lines not on this page · raw message

Signature · 1 line
1.9.1
#6 lore raw

PATCH v7 3/6 input: misc: Add driver for AXP20x Power Enable Key

Quoted 12 lines · Carlo Caione

This patch add support for the Power Enable Key found on MFD AXP202 and AXP209. Besides the basic support for the button, the driver adds two entries in sysfs to configure the time delay for power on/off.

---
 drivers/input/misc/Kconfig      |  11 ++
 drivers/input/misc/Makefile     |   1 +
 drivers/input/misc/axp20x-pek.c | 281 ++++++++++++++++++++++++++++++++++++++++
 3 files changed, 293 insertions(+)
 create mode 100644 drivers/input/misc/axp20x-pek.c

[...]

drivers/input/misc/axp20x-pek.c line 176

Quoted 9 lines
drivers/input/misc/axp20x-pek.c new file +9 -0
+static int axp20x_pek_probe(struct platform_device *pdev)
+{
+       struct axp20x_pek *axp20x_pek;
+       struct axp20x_dev *axp20x;
+       struct input_dev *idev;
+       int error;
+
+       axp20x_pek = devm_kzalloc(&pdev->dev, sizeof(struct axp20x_pek),
+                                 GFP_KERNEL);

You can use sizeof(*axp20x_pek) here.

[...]

drivers/input/misc/axp20x-pek.c line 277

Quoted 9 lines
drivers/input/misc/axp20x-pek.c new file +9 -0
+static struct platform_driver axp20x_pek_driver = {
+       .probe          = axp20x_pek_probe,
+       .remove         = axp20x_pek_remove,
+       .driver         = {
+               .name           = "axp20x-pek",
+               .owner          = THIS_MODULE,
+       },
+};
+module_platform_driver(axp20x_pek_driver);

So this requires platform data rather than a DTB? Or have I missed something?

Thanks,
Mark.

#7 lore raw

PATCH v7 3/6 input: misc: Add driver for AXP20x Power Enable Key

Quoted 4 lines · Mark Rutland
Quoted 4 lines
drivers/input/misc/axp20x-pek.c new file +4 -0
+static struct platform_driver axp20x_pek_driver = {
+       .probe          = axp20x_pek_probe,
+       .remove         = axp20x_pek_remove,
+       .driver         = {
Quoted 8 lines

drivers/input/misc/axp20x-pek.c line 277

Quoted 5 lines
drivers/input/misc/axp20x-pek.c new file +5 -0
+               .name           = "axp20x-pek",
+               .owner          = THIS_MODULE,
+       },
+};
+module_platform_driver(axp20x_pek_driver);

So this requires platform data rather than a DTB? Or have I missed something?

It is not loaded by DTB but by the MFD core driver (axp20x). So I assume this is still a platform device.

Regards,

Signature · 1 line
Carlo Caione
#8 lore raw

PATCH v7 4/6 input: misc: Add ABI docs for AXP20x PEK

In reply to Carlo Caione

Add ABI entries for the PEK found on PMU X-Powers AXP202 and AXP209.

---
 Documentation/ABI/testing/sysfs-driver-input-axp-pek | 11 +++++++++++
 1 file changed, 11 insertions(+)
 create mode 100644 Documentation/ABI/testing/sysfs-driver-input-axp-pek
Documentation/ABI/testing/sysfs-driver-input-axp-pek new file +11 -0
new file mode 100644
index 0000000..080563b
@@ -0,0 +1,11 @@
+What:		/sys/class/input/input(x)/startup
+Date:		March 2014
+Contact:	Carlo Caione <[email protected]>
+Description:	Startup time in us. Board is powered on if the button is pressed
+		for more than <startup_time>
+
+What:		/sys/class/input/input(x)/shutdown
+Date:		March 2014
+Contact:	Carlo Caione <[email protected]>
+Description:	Shutdown time in us. Board is powered off if the button is pressed
+		for more than <shutdown_time>
Signature · 1 line
1.9.1
#9 lore raw

PATCH v7 5/6 ARM: sunxi: Add AXP20x support in defconfig

In reply to Carlo Caione
---
 arch/arm/configs/sunxi_defconfig | 3 +++
 1 file changed, 3 insertions(+)
arch/arm/configs/sunxi_defconfig +3 -0
index 7209bfd..acf465f 100644
@@ -54,6 +54,8 @@ CONFIG_STMMAC_ETH=y
 # CONFIG_INPUT_MOUSEDEV is not set
 # CONFIG_INPUT_KEYBOARD is not set
 # CONFIG_INPUT_MOUSE is not set
+CONFIG_INPUT_MISC=y
+CONFIG_INPUT_AXP20X_PEK=y
 CONFIG_SERIAL_8250=y
 CONFIG_SERIAL_8250_CONSOLE=y
 CONFIG_SERIAL_8250_NR_UARTS=8
@@ -77,6 +79,7 @@ CONFIG_SUNXI_WATCHDOG=y
 CONFIG_MFD_AXP20X=y
 CONFIG_REGULATOR_VIRTUAL_CONSUMER=y
 CONFIG_REGULATOR_GPIO=y
+CONFIG_REGULATOR_AXP20X=y
 CONFIG_USB=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_EHCI_HCD_PLATFORM=y
Signature · 1 line
1.9.1
#10 lore raw

PATCH v7 6/6 ARM: sunxi: Add AXP20x support multi_v7_defconfig

In reply to Carlo Caione
---
 arch/arm/configs/multi_v7_defconfig | 3 +++
 1 file changed, 3 insertions(+)
arch/arm/configs/multi_v7_defconfig +3 -0
index be1a345..d79418e 100644
@@ -159,6 +159,7 @@ CONFIG_KEYBOARD_CROS_EC=y
 CONFIG_MOUSE_PS2_ELANTECH=y
 CONFIG_INPUT_MISC=y
 CONFIG_INPUT_MPU3050=y
+CONFIG_INPUT_AXP20X_PEK=y
 CONFIG_SERIO_AMBAKMI=y
 CONFIG_SERIAL_8250=y
 CONFIG_SERIAL_8250_CONSOLE=y
@@ -229,6 +230,7 @@ CONFIG_WATCHDOG=y
 CONFIG_ORION_WATCHDOG=y
 CONFIG_SUNXI_WATCHDOG=y
 CONFIG_MFD_AS3722=y
+CONFIG_MFD_AXP20X=y
 CONFIG_MFD_CROS_EC=y
 CONFIG_MFD_CROS_EC_SPI=y
 CONFIG_MFD_MAX8907=y
@@ -240,6 +242,7 @@ CONFIG_MFD_TPS65910=y
 CONFIG_REGULATOR_VIRTUAL_CONSUMER=y
 CONFIG_REGULATOR_AB8500=y
 CONFIG_REGULATOR_AS3722=y
+CONFIG_REGULATOR_AXP20X=y
 CONFIG_REGULATOR_GPIO=y
 CONFIG_REGULATOR_MAX8907=y
 CONFIG_REGULATOR_PALMAS=y
Signature · 1 line
1.9.1
#11 lore raw

v7 cover mfd: AXP20x: Add support for AXP202 and AXP209

In reply to Carlo Caione
Quoted 2 lines · On Sun, 29 Jun 2014 20:23:51 +0200 Carlo Caione wrote:

During the merging of v6 several patches were left out. This v7 comprises all the patches that are still pending.

Any progress on this or reason why these are stuck?

Quoted 132 lines

//--

AXP209 and AXP202 are the PMUs (Power Management Unit) used by A10, A13 and A20 SoCs and developed by X-Powers, a sister company of Allwinner. AXP20x comprises an adaptive USB-Compatible PWM charger, 2 BUCK DC-DC converters, 5 LDOs, multiple 12-bit ADCs of voltage, current and temperature as well as 4 configurable GPIOs.

This set of patches introduces the core driver and support for two different subsystems:
- Regulators
- PEK (Power Enable Key)

Changes since v1:

- Added a new standalone patch for defconfig

- MFD core:
* Removed axp,system-power-controller property

- Bindings documentation:
* Corrected description for dcdc-workmode property
* Removed unused axp20x-pek compatible

- Input misc PEK driver:
* Fixed seconds in lower case

- Regulators subsystem:
* Fixed axp20x_set_suspend_voltage()
* Switched to using multi-bit control for regulators
* When "regulators" node is not found driver doesn't quit
* Driver is now using devm_regulator_register()
* Added module_platform_driver() instead of subsys_initcall()

- DT:
* Added new DTSI for AXP209
* Added support for cubietruck and olinuxino-micro

Changes since v2:

- Added a new patch for multi_v7_defconfig to enable MFD core and subsystems

- DT:
* Dropped axp,system-power-controller property from DTS
* Moved compatible and interrupt-related properties from the DTSI file to the DTS board files

- Regulators subsystem:
* Deleted useless struct axp20x_regulators
* Added a warning when out of specs values are used for the dcdc frequency

- MFD core:
* Fixed coding style
* Removed IDs from device table for i2c

- Bindings documentation:
* Several corrections and fixes

Changes since v3:

- Removed x-powers-axp209.dtsi file
- Rewritten bindings document

- MFD core:
* Fixed casting
* Better comments / documentation

- Input misc PEK driver:
* Timings are now expressed in ms and the sysfs appies the closest possible value
* No more useless pretty-printing
* Removed devm_request_threaded_irq in favour of devm_request_any_context_irq
* Moved from input attributes to platform device attributes

- Regulators subsystem:
* Removed suspend mode (axp20x_set_suspend_voltage)
* Added regulators input supply

- DT:
* DTs doesn't include anymore the dtsi
* Added input supplies for regulators

Changes since v4:

- Removed regulator patches already applied / acked by Mark Brown

- Input misc PEK driver:
* Don't print anymore the "us" unit
* Added cleanup for attributes when unbindind the device
* Fixed error code returned when device_create_file() fails

- DT:
* Enable all the regulators on at boot-time
* Removed min and max microvolts for all the regulators but DCDC2
* Moved the axp_ipsout regulator outside the MFD node

- MFD core:
* The supply regulators are now specified in the MFD driver using regulator_bulk_register_supply_alias() and the .parent_supplies in the MFD cell

Changes since v5:
- Added ACKs
- Fixed compilation warning (reported by Hans De Goede)
- Vendor-prefixes are now sorted
- Removed DT patch

Carlo Caione (6):
mfd: AXP20x: Add bindings documentation
dt-bindings: add vendor-prefix for X-Powers
input: misc: Add driver for AXP20x Power Enable Key
input: misc: Add ABI docs for AXP20x PEK
ARM: sunxi: Add AXP20x support in defconfig
ARM: sunxi: Add AXP20x support multi_v7_defconfig

 .../ABI/testing/sysfs-driver-input-axp-pek         |  11 +
 Documentation/devicetree/bindings/mfd/axp20x.txt   |  93 +++++++
 .../devicetree/bindings/vendor-prefixes.txt        |   1 +
 arch/arm/configs/multi_v7_defconfig                |   3 +
 arch/arm/configs/sunxi_defconfig                   |   3 +
 drivers/input/misc/Kconfig                         |  11 +
 drivers/input/misc/Makefile                        |   1 +
 drivers/input/misc/axp20x-pek.c                    | 281 +++++++++++++++++++++
 8 files changed, 404 insertions(+)
 create mode 100644 Documentation/ABI/testing/sysfs-driver-input-axp-pek
 create mode 100644 Documentation/devicetree/bindings/mfd/axp20x.txt
 create mode 100644 drivers/input/misc/axp20x-pek.c
#12 lore raw

v7 cover mfd: AXP20x: Add support for AXP202 and AXP209

Quoted 5 lines · Bruno Pr?mont
Quoted 2 lines · On Sun, 29 Jun 2014 20:23:51 +0200 Carlo Caione wrote:

During the merging of v6 several patches were left out. This v7 comprises all the patches that are still pending.

Any progress on this or reason why these are stuck?

No one bothered resubmitting it.

If you have some time to work on this, it would be great if you could pick up the work, if not, I'll do it.

Maxime

Signature · 10 lines
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141022/edef747b/attachment.sig>
#13 lore raw
Quoted 11 lines · Maxime Ripard
Quoted 5 lines · Bruno Pr?mont
Quoted 2 lines · On Sun, 29 Jun 2014 20:23:51 +0200 Carlo Caione wrote:

During the merging of v6 several patches were left out. This v7 comprises all the patches that are still pending.

Any progress on this or reason why these are stuck?

No one bothered resubmitting it.

If you have some time to work on this, it would be great if you could pick up the work, if not, I'll do it.

Wow, I totally forgot about those patches. Sorry for that. If you are willing to work on the patches go ahead, otherwise I'll find a bit of time myself.

Signature · 1 line
Carlo Caione