Skip to contentSkip to conversation

drm/crtc: Fix two typos

PATCH In review Chuck Ebbert 3 participants 3 messages Oct 8, 2014 – Oct 22, 2014

lore
Share & tools
lore

Chuck Ebbert

author
#0 lore raw

PATCH 1/1 drm/crtc: Fix two typos

Fix:

ioclt -> ioctl in comment
wrong variable name in debug message

Signed-off-by Chuck Ebbert <[email protected]>

---

gpu/drm/drm_crtc.c renamed from gpu/drm/drm_crtc.c.orig +2 -2
@@ -2913,7 +2913,7 @@ EXPORT_SYMBOL(drm_mode_legacy_fb_format)
  * @file_priv: drm file for the ioctl call
  *
  * Add a new FB to the specified CRTC, given a user request. This is the
- * original addfb ioclt which only supported RGB formats.
+ * original addfb ioctl which only supported RGB formats.
  *
  * Called by the user via ioctl.
  *

@@ -3033,7 +3033,7 @@ static int framebuffer_check(const struc
 	num_planes = drm_format_num_planes(r->pixel_format);
 
 	if (r->width == 0 || r->width % hsub) {
-		DRM_DEBUG_KMS("bad framebuffer width %u\n", r->height);
+		DRM_DEBUG_KMS("bad framebuffer width %u\n", r->width);
 		return -EINVAL;
 	}
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Chuck Ebbert

Fix:

ioclt -> ioctl in comment
wrong variable name in debug message

Signed-off-by Chuck Ebbert <[email protected]>
Reviewed-by Ville Syrjälä <[email protected]>
Quoted 26 lines

---

gpu/drm/drm_crtc.c renamed from gpu/drm/drm_crtc.c.orig +2 -2
@@ -2913,7 +2913,7 @@ EXPORT_SYMBOL(drm_mode_legacy_fb_format)
  * @file_priv: drm file for the ioctl call
  *
  * Add a new FB to the specified CRTC, given a user request. This is the
- * original addfb ioclt which only supported RGB formats.
+ * original addfb ioctl which only supported RGB formats.
  *
  * Called by the user via ioctl.
  *

@@ -3033,7 +3033,7 @@ static int framebuffer_check(const struc
 	num_planes = drm_format_num_planes(r->pixel_format);
 
 	if (r->width == 0 || r->width % hsub) {
-		DRM_DEBUG_KMS("bad framebuffer width %u\n", r->height);
+		DRM_DEBUG_KMS("bad framebuffer width %u\n", r->width);
 		return -EINVAL;
 	}

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Signature · 2 lines
Ville Syrjälä
Intel OTC
#2 lore raw
Quoted 6 lines · Ville Syrjälä
Quoted 5 lines · Chuck Ebbert

Fix:

ioclt -> ioctl in comment
wrong variable name in debug message

Quoted 8 lines
Quoted 1 line
Signed-off-by Chuck Ebbert <[email protected]>
Reviewed-by Ville Syrjälä <[email protected]>

gpu/drm/drm_crtc.c

Quoted 4 lines

---

gpu/drm/drm_crtc.c renamed from gpu/drm/drm_crtc.c.orig +0 -0

This diff was manually generated and failed to apply using the usual tooling. Please generate patches using git format-patch and send it using git send-email, they get all the details right.

I've fixed it up while applying.
-Daniel

Quoted 30 lines
Quoted 22 lines
gpu/drm/drm_crtc.c renamed from gpu/drm/drm_crtc.c.orig +2 -2
@@ -2913,7 +2913,7 @@ EXPORT_SYMBOL(drm_mode_legacy_fb_format)
  * @file_priv: drm file for the ioctl call
  *
  * Add a new FB to the specified CRTC, given a user request. This is the
- * original addfb ioclt which only supported RGB formats.
+ * original addfb ioctl which only supported RGB formats.
  *
  * Called by the user via ioctl.
  *

@@ -3033,7 +3033,7 @@ static int framebuffer_check(const struc
 	num_planes = drm_format_num_planes(r->pixel_format);
 
 	if (r->width == 0 || r->width % hsub) {
-		DRM_DEBUG_KMS("bad framebuffer width %u\n", r->height);
+		DRM_DEBUG_KMS("bad framebuffer width %u\n", r->width);
 		return -EINVAL;
 	}

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Signature · 6 lines
Ville Syrjälä
Intel OTC
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch