Skip to contentSkip to conversation

asus-nb-wmi: Add wapf4 quirk for the X550VB

PATCH Superseded Stanislaw Gruszka 2 participants 4 messages Oct 22, 2014 – Oct 28, 2014

Subsystems (2)
x86 platform drivers ASUS notebooks and eeepc ACPI/WMI extras drivers
lore
Share & tools
lore

Stanislaw Gruszka

author
#0 lore raw

PATCH 1/1 asus-nb-wmi: Add wapf4 quirk for the X550VB

As reported here: http://bugzilla.redhat.com/show_bug.cgi?id=1089731#c23
the X550VB needs wapf=4 too.

Signed-off-by Stanislaw Gruszka <[email protected]>
---
 drivers/platform/x86/asus-nb-wmi.c | 9 +++++++++
 1 file changed, 9 insertions(+)
drivers/platform/x86/asus-nb-wmi.c +9 -0
index 3a4951f..c1a6cd6 100644
@@ -182,6 +182,15 @@ static const struct dmi_system_id asus_quirks[] = {
 	},
 	{
 		.callback = dmi_matched,
+		.ident = "ASUSTeK COMPUTER INC. X550VB",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "X550VB"),
+		},
+		.driver_data = &quirk_asus_wapf4,
+	},
+	{
+		.callback = dmi_matched,
 		.ident = "ASUSTeK COMPUTER INC. X55A",
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
Signature · 1 line
1.8.3.1
#1 lore raw

On Wed, Oct 22, 2014 at 02:32:52PM +0200, Stanislaw Gruszka wrote:

Hi Stanislaw,

Quoted 3 lines

As reported here: http://bugzilla.redhat.com/show_bug.cgi?id=1089731#c23
the X550VB needs wapf=4 too.

Please provide a self sufficient changelog, that, independent of a bugzilla link, provides enough information to understand what the problem is, and why this is the correct fix.

Thanks,

Signature · 2 lines
Darren Hart
Intel Open Source Technology Center
author
#2 lore raw

PATCH v2 1/1 asus-nb-wmi: Add wapf4 quirk for the X550VB

X550VB as many others Asus laptops need wapf4 quirk to make RFKILL switch be functional. Otherwise system boots with wireless card disabled and is only possible to enable it by suspend/resume.

Bug report:
http://bugzilla.redhat.com/show_bug.cgi?id=1089731#c23

Reported-and-tested-by Vratislav Podzimek <[email protected]>
Signed-off-by Stanislaw Gruszka <[email protected]>

---
v1 -> v2: update changelog

 drivers/platform/x86/asus-nb-wmi.c | 9 +++++++++
 1 file changed, 9 insertions(+)
drivers/platform/x86/asus-nb-wmi.c +9 -0
index 3a4951f..c1a6cd6 100644
@@ -182,6 +182,15 @@ static const struct dmi_system_id asus_quirks[] = {
 	},
 	{
 		.callback = dmi_matched,
+		.ident = "ASUSTeK COMPUTER INC. X550VB",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "X550VB"),
+		},
+		.driver_data = &quirk_asus_wapf4,
+	},
+	{
+		.callback = dmi_matched,
 		.ident = "ASUSTeK COMPUTER INC. X55A",
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
Signature · 1 line
1.8.3.1
Applied
#3 lore raw
Quoted 9 lines · Stanislaw Gruszka

X550VB as many others Asus laptops need wapf4 quirk to make RFKILL switch be functional. Otherwise system boots with wireless card disabled and is only possible to enable it by suspend/resume.

Bug report:
http://bugzilla.redhat.com/show_bug.cgi?id=1089731#c23

Reported-and-tested-by Vratislav Podzimek <[email protected]>
Signed-off-by Stanislaw Gruszka <[email protected]>

Queued, thanks Stanislaw.

Signature · 2 lines
Darren Hart
Intel Open Source Technology Center