Skip to contentSkip to conversation

package/cdrkit: standardize site URL

PATCH New Karoly Kasza 3 participants 7 messages Oct 22, 2014 – Oct 23, 2014

lore
Share & tools
lore

Karoly Kasza

author
#0 lore raw

PATCH 1/1 package/cdrkit: standardize site URL

Standardize download site URL using the Debian mirror.

Signed-off-by Karoly Kasza <[email protected]>
---
 package/cdrkit/cdrkit.mk |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/cdrkit/cdrkit.mk +1 -1
index 3f2b429..e1392b6 100644
@@ -6,7 +6,7 @@
 
 CDRKIT_VERSION = 1.1.11
 CDRKIT_SOURCE = cdrkit_$(CDRKIT_VERSION).orig.tar.gz
-CDRKIT_SITE = http://snapshot.debian.org/archive/debian/20101018T151929Z/pool/main/c/cdrkit/
+CDRKIT_SITE = $(BR2_DEBIAN_MIRROR)/debian/pool/main/c/cdrkit
 CDRKIT_DEPENDENCIES = libcap bzip2 zlib
 CDRKIT_LICENSE = GPLv2
 CDRKIT_LICENSE_FILES = COPYING
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/1 package/cdrkit: standardize site URL

Dear Karoly Kasza,

Quoted 12 lines · Karoly Kasza

Standardize download site URL using the Debian mirror.

Signed-off-by Karoly Kasza <[email protected]>
---
 package/cdrkit/cdrkit.mk |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/cdrkit/cdrkit.mk +0 -0
index 3f2b429..e1392b6 100644

package/cdrkit/cdrkit.mk line 12

Quoted 8 lines
package/cdrkit/cdrkit.mk +1 -1
@@ -6,7 +6,7 @@
 
 CDRKIT_VERSION = 1.1.11
 CDRKIT_SOURCE = cdrkit_$(CDRKIT_VERSION).orig.tar.gz
-CDRKIT_SITE = http://snapshot.debian.org/archive/debian/20101018T151929Z/pool/main/c/cdrkit/
+CDRKIT_SITE = $(BR2_DEBIAN_MIRROR)/debian/pool/main/c/cdrkit
 CDRKIT_DEPENDENCIES = libcap bzip2 zlib
 CDRKIT_LICENSE = GPLv2
 CDRKIT_LICENSE_FILES = COPYING

Yeah, well, actually, I believe using snapshot.debian.org is a better idea, since it guarantees that files won't be moved. While using $(BR2_DEBIAN_MIRROR) means that we point to locations where tarballs will disappear at some point. At least, we've seen that in the past.

So maybe we should rather get rid of BR2_DEBIAN_MIRROR and make sure all packages downloading their source from Debian use snapshot.debian.org instead.

Thoughts?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#2 lore raw

PATCH 1/1 package/cdrkit: standardize site URL

Hi Thomas,

I tried to standardize this package, but what you are telling makes sense. If you and Yann both agree to use snapshot.debian.org instead, than reject this patch
and I will send a patchset, that completely removes BR2_DEBIAN_MIRROR from Buildroot,
and changes all occurrences to snapshot.debian.org, is that OK with you?

Best regards,
Karoly

Quoted 42 lines · Thomas Petazzoni

Dear Karoly Kasza,

Quoted 12 lines · Karoly Kasza

Standardize download site URL using the Debian mirror.

Signed-off-by Karoly Kasza <[email protected]>
---
 package/cdrkit/cdrkit.mk |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/cdrkit/cdrkit.mk +0 -0
index 3f2b429..e1392b6 100644

package/cdrkit/cdrkit.mk line 9

Quoted 4 lines
package/cdrkit/cdrkit.mk +0 -1
@@ -6,7 +6,7 @@
 
 CDRKIT_VERSION = 1.1.11
 CDRKIT_SOURCE = cdrkit_$(CDRKIT_VERSION).orig.tar.gz
-CDRKIT_SITE =

http://snapshot.debian.org/archive/debian/20101018T151929Z/pool/main/c/cdrkit/

package/cdrkit/cdrkit.mk line 12

Quoted 4 lines
package/cdrkit/cdrkit.mk +1 -0
+CDRKIT_SITE = $(BR2_DEBIAN_MIRROR)/debian/pool/main/c/cdrkit
 CDRKIT_DEPENDENCIES = libcap bzip2 zlib
 CDRKIT_LICENSE = GPLv2
 CDRKIT_LICENSE_FILES = COPYING

Yeah, well, actually, I believe using snapshot.debian.org is a better idea, since it guarantees that files won't be moved. While using $(BR2_DEBIAN_MIRROR) means that we point to locations where tarballs will disappear at some point. At least, we've seen that in the past.

So maybe we should rather get rid of BR2_DEBIAN_MIRROR and make sure all packages downloading their source from Debian use snapshot.debian.org instead.

Thoughts?

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Signature · 5 lines
?dv,
KK
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20141022/691db296/attachment.html>
#3 lore raw

PATCH 1/1 package/cdrkit: standardize site URL

Dear K?roly Kasza,

Quoted 6 lines · K?roly Kasza

I tried to standardize this package, but what you are telling makes sense. If you and Yann both agree to use snapshot.debian.org instead, than reject this patch
and I will send a patchset, that completely removes BR2_DEBIAN_MIRROR from Buildroot,
and changes all occurrences to snapshot.debian.org, is that OK with you?

It's OK with me, but I'd like to have some feedback from Yann and Peter about this before you spend time fixing all the other packages. Maybe there's some drawback I'm missing about using snapshot.debian.net, and I don't want you to waste time on something that will not be merged.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#4 lore raw

PATCH 1/1 package/cdrkit: standardize site URL

In reply to Thomas Petazzoni
Quoted 29 lines · Thomas Petazzoni

Dear Karoly Kasza,

Quoted 12 lines · Karoly Kasza

Standardize download site URL using the Debian mirror.

Signed-off-by Karoly Kasza <[email protected]>
---
 package/cdrkit/cdrkit.mk |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/cdrkit/cdrkit.mk +0 -0
index 3f2b429..e1392b6 100644

package/cdrkit/cdrkit.mk line 12

Quoted 8 lines
package/cdrkit/cdrkit.mk +1 -1
@@ -6,7 +6,7 @@
 
 CDRKIT_VERSION = 1.1.11
 CDRKIT_SOURCE = cdrkit_$(CDRKIT_VERSION).orig.tar.gz
-CDRKIT_SITE = http://snapshot.debian.org/archive/debian/20101018T151929Z/pool/main/c/cdrkit/
+CDRKIT_SITE = $(BR2_DEBIAN_MIRROR)/debian/pool/main/c/cdrkit
 CDRKIT_DEPENDENCIES = libcap bzip2 zlib
 CDRKIT_LICENSE = GPLv2
 CDRKIT_LICENSE_FILES = COPYING

Yeah, well, actually, I believe using snapshot.debian.org is a better idea, since it guarantees that files won't be moved. While using $(BR2_DEBIAN_MIRROR) means that we point to locations where tarballs will disappear at some point. At least, we've seen that in the past.

Quoted 5 lines

So maybe we should rather get rid of BR2_DEBIAN_MIRROR and make sure all packages downloading their source from Debian use snapshot.debian.org instead.

Thoughts?

We've discussed this before and IIRC nobody was against getting rid of
BR2_DEBIAN_MIRROR. Well, looking back through my mail archives, it looks like you (Thomas) said a couple of times to use snapshot instead of BR2_DEBIAN_MIRROR and nobody objected.

I certainly agree that using snapshot is a better idea. We now have a mix of 17
packages using BR2_DEBIAN_MIRROR and 10 packages using snapshot.debian.org, and AFAIK we never had any problem with the snapshot packages.

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#5 lore raw

PATCH 1/1 package/cdrkit: standardize site URL

Dear Arnout Vandecappelle,

Quoted 8 lines · Arnout Vandecappelle

We've discussed this before and IIRC nobody was against getting rid of
BR2_DEBIAN_MIRROR. Well, looking back through my mail archives, it looks like you (Thomas) said a couple of times to use snapshot instead of BR2_DEBIAN_MIRROR and nobody objected.

I certainly agree that using snapshot is a better idea. We now have a mix of 17
packages using BR2_DEBIAN_MIRROR and 10 packages using snapshot.debian.org, and AFAIK we never had any problem with the snapshot packages.

I agree. So Karoly, feel free to work on a patch series moving all packages fetching their source code from Debian to use snapshot.debian.org, and then removing BR2_DEBIAN_MIRROR.

Thanks a lot!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#6 lore raw

PATCH 1/1 package/cdrkit: standardize site URL

Will do!

Regards,
Karoly

Quoted 29 lines · Thomas Petazzoni

Dear Arnout Vandecappelle,

Quoted 2 lines · Arnout Vandecappelle

We've discussed this before and IIRC nobody was against getting rid of
BR2_DEBIAN_MIRROR. Well, looking back through my mail archives, it looks

like

Quoted 1 line

you (Thomas) said a couple of times to use snapshot instead of

BR2_DEBIAN_MIRROR

Quoted 3 lines

and nobody objected.

I certainly agree that using snapshot is a better idea. We now have a

mix of 17

Quoted 1 line

packages using BR2_DEBIAN_MIRROR and 10 packages using

snapshot.debian.org, and

Quoted 1 line

AFAIK we never had any problem with the snapshot packages.

I agree. So Karoly, feel free to work on a patch series moving all packages fetching their source code from Debian to use snapshot.debian.org, and then removing BR2_DEBIAN_MIRROR.

Thanks a lot!

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Signature · 5 lines
?dv,
KK
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20141023/7a9a99f5/attachment.html>