Skip to contentSkip to conversation

omap3: overo: Add foreign expansion board support

PATCH New Stefan Herbrechtsmeier 3 participants 14 messages Sep 16, 2014 – Oct 23, 2014

lore
Share & tools
lore
#0 lore raw

cover omap3: overo: Add foreign expansion board support

At the moment the boot loader use a common configuration for all Gumstix Overo expansion boards. This also includes configuration of all inputs and outputs even if they aren't used by the boot loader. Because the Overo module could be used on foreign expansion boards with different configurations this could lead to problems. Split the configuration into a Overo module and expansion board part. The expansion board configuration is skipped if a foreign expansion board is detected. This enables a foreign expansion board to use the common boot loader without any modifications. It could load a specific device tree by saving the expansion name in the EEPROM.

Additionally fix some errors in the environment configuration and add USB host support.

The series is only tested on a foreign expansion boards. It would be nice if somebody could test it on an expansion board with network support.

Stefan Herbrechtsmeier (5):
omap3: overo: Fix fdtfile test
omap3: overo: Call bootm only after successful nand read
omap3: overo: Move ethernet setup to board_eth_init function
omap3: overo: Separate module and expansion board MUX configuration
omap3: overo: Add usb host support

 board/overo/overo.c           | 137 ++++++++++++++++++++++++++++----------
 board/overo/overo.h           | 150 ++++++++++++++++++++++--------------------
 include/configs/omap3_overo.h |  15 ++++-
 3 files changed, 195 insertions(+), 107 deletions(-)
Signature · 1 line
2.1.0
#1 lore raw

PATCH 1/5 omap3: overo: Fix fdtfile test

Commit 12cc54376768461533b55ada1b0b6d4979f40579 'omap3: overo: Select fdtfile for expansion board' wrongly missed the operator in the fdtfile test. Update the test to only overwrite an empty fdtfile environment variable.

---

 include/configs/omap3_overo.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/omap3_overo.h +1 -1
index e66f306..b17e495 100644
@@ -151,7 +151,7 @@
 			"run mmcboot;" \
 		"fi;" \
 		"if run loadzimage; then " \
-			"if test $fdtfile; then " \
+			"if test -z \"${fdtfile}\"; then " \
 				"setenv fdtfile omap3-${boardname}-${expansionname}.dtb;" \
 			"fi;" \
 			"if run loadfdt; then " \
Signature · 1 line
2.1.0
#2 lore raw

PATCH 1/5 omap3: overo: Fix fdtfile test

Quoted 6 lines · Stefan Herbrechtsmeier

Commit 12cc54376768461533b55ada1b0b6d4979f40579 'omap3: overo: Select fdtfile for expansion board' wrongly missed the operator in the fdtfile test. Update the test to only overwrite an empty fdtfile environment variable.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141010/e0503efc/attachment.pgp>
#3 lore raw

PATCH 2/5 omap3: overo: Call bootm only after successful nand read

In reply to Stefan Herbrechtsmeier

---

 include/configs/omap3_overo.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
include/configs/omap3_overo.h +3 -2
index b17e495..d042eea 100644
@@ -131,8 +131,9 @@
 		"bootz ${loadaddr} - ${fdtaddr}\0" \
 	"nandboot=echo Booting from nand ...; " \
 		"run nandargs; " \
-		"nand read ${loadaddr} linux; " \
-		"bootm ${loadaddr}\0" \
+		"if nand read ${loadaddr} linux; then " \
+			"bootm ${loadaddr};" \
+		"fi;\0" \
 
 #define CONFIG_BOOTCOMMAND \
 	"mmc dev ${mmcdev}; if mmc rescan; then " \
Signature · 1 line
2.1.0
#4 lore raw

PATCH 2/5 omap3: overo: Call bootm only after successful nand read

Quoted 1 line · Stefan Herbrechtsmeier

Applied to u-boot-ti/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141023/42ec153e/attachment.pgp>
#5 lore raw

PATCH 3/5 omap3: overo: Move ethernet setup to board_eth_init function

In reply to Stefan Herbrechtsmeier

Move ethernet setup to the board_eth_init function and select the available network devices via expansion id.

---

 board/overo/overo.c | 76 +++++++++++++++++++++++++++++++++--------------------
 1 file changed, 47 insertions(+), 29 deletions(-)
board/overo/overo.c +47 -29
index 13220c5..caffb50 100644
@@ -58,21 +58,6 @@ static struct {
 	char env_setting[64];
 } expansion_config;
 
-#if defined(CONFIG_CMD_NET)
-static void setup_net_chip(void);
-#endif
-
-/* GPMC definitions for LAN9221 chips on Tobi expansion boards */
-static const u32 gpmc_lan_config[] = {
-    NET_LAN9221_GPMC_CONFIG1,
-    NET_LAN9221_GPMC_CONFIG2,
-    NET_LAN9221_GPMC_CONFIG3,
-    NET_LAN9221_GPMC_CONFIG4,
-    NET_LAN9221_GPMC_CONFIG5,
-    NET_LAN9221_GPMC_CONFIG6,
-    /*CONFIG7- computed as params */
-};
-
 /*
  * Routine: board_init
  * Description: Early hardware init.
@@ -241,10 +226,6 @@ int misc_init_r(void)
 	twl4030_power_init();
 	twl4030_led_init(TWL4030_LED_LEDEN_LEDAON | TWL4030_LED_LEDEN_LEDBON);
 
-#if defined(CONFIG_CMD_NET)
-	setup_net_chip();
-#endif
-
 	printf("Board revision: %d\n", get_board_revision());
 
 	switch (get_sdio2_config()) {
@@ -280,9 +261,6 @@ int misc_init_r(void)
 		printf("Recognized Tobi Duo expansion board (rev %d %s)\n",
 			expansion_config.revision,
 			expansion_config.fab_revision);
-		/* second lan chip */
-		enable_gpmc_cs_config(gpmc_lan_config, &gpmc_cfg->cs[4],
-		    0x2B000000, GPMC_SIZE_16M);
 		break;
 	case GUMSTIX_PALO35:
 		printf("Recognized Palo35 expansion board (rev %d %s)\n",
@@ -388,7 +366,18 @@ void set_muxconf_regs(void)
 	MUX_OVERO();
 }
 
-#if defined(CONFIG_CMD_NET)
+#if defined(CONFIG_CMD_NET) && !defined(CONFIG_SPL_BUILD)
+/* GPMC definitions for LAN9221 chips on Tobi expansion boards */
+static const u32 gpmc_lan_config[] = {
+	NET_LAN9221_GPMC_CONFIG1,
+	NET_LAN9221_GPMC_CONFIG2,
+	NET_LAN9221_GPMC_CONFIG3,
+	NET_LAN9221_GPMC_CONFIG4,
+	NET_LAN9221_GPMC_CONFIG5,
+	NET_LAN9221_GPMC_CONFIG6,
+	/*CONFIG7- computed as params */
+};
+
 /*
  * Routine: setup_net_chip
  * Description: Setting up the configuration GPMC registers specific to the
@@ -398,10 +387,6 @@ static void setup_net_chip(void)
 {
 	struct ctrl *ctrl_base = (struct ctrl *)OMAP34XX_CTRL_BASE;
 
-	/* first lan chip */
-	enable_gpmc_cs_config(gpmc_lan_config, &gpmc_cfg->cs[5], 0x2C000000,
-			GPMC_SIZE_16M);
-
 	/* Enable off mode for NWE in PADCONF_GPMC_NWE register */
 	writew(readw(&ctrl_base ->gpmc_nwe) | 0x0E00, &ctrl_base->gpmc_nwe);
 	/* Enable off mode for NOE in PADCONF_GPMC_NADV_ALE register */
@@ -409,7 +394,14 @@ static void setup_net_chip(void)
 	/* Enable off mode for ALE in PADCONF_GPMC_NADV_ALE register */
 	writew(readw(&ctrl_base->gpmc_nadv_ale) | 0x0E00,
 		&ctrl_base->gpmc_nadv_ale);
+}
 
+/*
+ * Routine: reset_net_chip
+ * Description: Reset the Ethernet hardware.
+ */
+static void reset_net_chip(void)
+{
 	/* Make GPIO 64 as output pin and send a magic pulse through it */
 	if (!gpio_request(64, "")) {
 		gpio_direction_output(64, 0);
@@ -420,16 +412,42 @@ static void setup_net_chip(void)
 		gpio_set_value(64, 1);
 	}
 }
-#endif
 
 int board_eth_init(bd_t *bis)
 {
+	unsigned int expansion_id;
 	int rc = 0;
+
 #ifdef CONFIG_SMC911X
-	rc = smc911x_initialize(0, CONFIG_SMC911X_BASE);
+	expansion_id = get_expansion_id();
+	switch (expansion_id) {
+	case GUMSTIX_TOBI_DUO:
+		/* second lan chip */
+		enable_gpmc_cs_config(gpmc_lan_config, &gpmc_cfg->cs[4],
+				      0x2B000000, GPMC_SIZE_16M);
+		/* no break */
+	case GUMSTIX_TOBI:
+	case GUMSTIX_CHESTNUT43:
+	case GUMSTIX_STAGECOACH:
+	case GUMSTIX_NO_EEPROM:
+	case GUMSTIX_EMPTY_EEPROM:
+		/* first lan chip */
+		enable_gpmc_cs_config(gpmc_lan_config, &gpmc_cfg->cs[5],
+				      0x2C000000, GPMC_SIZE_16M);
+
+		setup_net_chip();
+		reset_net_chip();
+
+		rc = smc911x_initialize(0, CONFIG_SMC911X_BASE);
+		break;
+	default:
+		break;
+	}
 #endif
+
 	return rc;
 }
+#endif
 
 #if defined(CONFIG_GENERIC_MMC) && !defined(CONFIG_SPL_BUILD)
 int board_mmc_init(bd_t *bis)
Signature · 1 line
2.1.0
#6 lore raw

PATCH 3/5 omap3: overo: Move ethernet setup to board_eth_init function

Quoted 4 lines · Stefan Herbrechtsmeier

Move ethernet setup to the board_eth_init function and select the available network devices via expansion id.

Applied to u-boot-ti/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141023/4cbf1ae7/attachment.pgp>
#7 lore raw

PATCH 4/5 omap3: overo: Separate module and expansion board MUX configuration

In reply to Stefan Herbrechtsmeier

Separate overo module and expansion board MUX configuration. This allows an foreign expansion board to use the boot loader without any adaption. It only needs to save the expansion name in the EEPROM to load a specific device tree.

---

 board/overo/overo.c |  27 ++++++++--
 board/overo/overo.h | 150 +++++++++++++++++++++++++++-------------------------
 2 files changed, 102 insertions(+), 75 deletions(-)
board/overo/overo.c +23 -4
index caffb50..488246b 100644
@@ -31,6 +31,8 @@ DECLARE_GLOBAL_DATA_PTR;
 #define EXPANSION_EEPROM_I2C_BUS	2
 #define EXPANSION_EEPROM_I2C_ADDRESS	0x51
 
+#define GUMSTIX_EMPTY_EEPROM		0x0
+
 #define GUMSTIX_SUMMIT			0x01000200
 #define GUMSTIX_TOBI			0x02000200
 #define GUMSTIX_TOBI_DUO		0x03000200
@@ -56,7 +58,7 @@ static struct {
 	char fab_revision[8];
 	char env_var[16];
 	char env_setting[64];
-} expansion_config;
+} expansion_config = {0x0};
 
 /*
  * Routine: board_init
@@ -198,6 +200,9 @@ int get_sdio2_config(void)
  */
 unsigned int get_expansion_id(void)
 {
+	if (expansion_config.device_vendor != 0x0)
+		return expansion_config.device_vendor;
+
 	i2c_set_bus_num(EXPANSION_EEPROM_I2C_BUS);
 
 	/* return GUMSTIX_NO_EEPROM if eeprom doesn't respond */
@@ -247,6 +252,7 @@ int misc_init_r(void)
 		printf("Recognized Summit expansion board (rev %d %s)\n",
 			expansion_config.revision,
 			expansion_config.fab_revision);
+		MUX_GUMSTIX();
 		setenv("defaultdisplay", "dvi");
 		setenv("expansionname", "summit");
 		break;
@@ -254,6 +260,7 @@ int misc_init_r(void)
 		printf("Recognized Tobi expansion board (rev %d %s)\n",
 			expansion_config.revision,
 			expansion_config.fab_revision);
+		MUX_GUMSTIX();
 		setenv("defaultdisplay", "dvi");
 		setenv("expansionname", "tobi");
 		break;
@@ -261,17 +268,20 @@ int misc_init_r(void)
 		printf("Recognized Tobi Duo expansion board (rev %d %s)\n",
 			expansion_config.revision,
 			expansion_config.fab_revision);
+		MUX_GUMSTIX();
 		break;
 	case GUMSTIX_PALO35:
 		printf("Recognized Palo35 expansion board (rev %d %s)\n",
 			expansion_config.revision,
 			expansion_config.fab_revision);
+		MUX_GUMSTIX();
 		setenv("defaultdisplay", "lcd35");
 		break;
 	case GUMSTIX_PALO43:
 		printf("Recognized Palo43 expansion board (rev %d %s)\n",
 			expansion_config.revision,
 			expansion_config.fab_revision);
+		MUX_GUMSTIX();
 		setenv("defaultdisplay", "lcd43");
 		setenv("expansionname", "palo43");
 		break;
@@ -279,6 +289,7 @@ int misc_init_r(void)
 		printf("Recognized Chestnut43 expansion board (rev %d %s)\n",
 			expansion_config.revision,
 			expansion_config.fab_revision);
+		MUX_GUMSTIX();
 		setenv("defaultdisplay", "lcd43");
 		setenv("expansionname", "chestnut43");
 		break;
@@ -286,11 +297,13 @@ int misc_init_r(void)
 		printf("Recognized Pinto expansion board (rev %d %s)\n",
 			expansion_config.revision,
 			expansion_config.fab_revision);
+		MUX_GUMSTIX();
 		break;
 	case GUMSTIX_GALLOP43:
 		printf("Recognized Gallop43 expansion board (rev %d %s)\n",
 			expansion_config.revision,
 			expansion_config.fab_revision);
+		MUX_GUMSTIX();
 		setenv("defaultdisplay", "lcd43");
 		setenv("expansionname", "gallop43");
 		break;
@@ -298,6 +311,7 @@ int misc_init_r(void)
 		printf("Recognized Alto35 expansion board (rev %d %s)\n",
 			expansion_config.revision,
 			expansion_config.fab_revision);
+		MUX_GUMSTIX();
 		MUX_ALTO35();
 		setenv("defaultdisplay", "lcd35");
 		setenv("expansionname", "alto35");
@@ -306,21 +320,25 @@ int misc_init_r(void)
 		printf("Recognized Stagecoach expansion board (rev %d %s)\n",
 			expansion_config.revision,
 			expansion_config.fab_revision);
+		MUX_GUMSTIX();
 		break;
 	case GUMSTIX_THUMBO:
 		printf("Recognized Thumbo expansion board (rev %d %s)\n",
 			expansion_config.revision,
 			expansion_config.fab_revision);
+		MUX_GUMSTIX();
 		break;
 	case GUMSTIX_TURTLECORE:
 		printf("Recognized Turtlecore expansion board (rev %d %s)\n",
 			expansion_config.revision,
 			expansion_config.fab_revision);
+		MUX_GUMSTIX();
 		break;
 	case GUMSTIX_ARBOR43C:
 		printf("Recognized Arbor43C expansion board (rev %d %s)\n",
 			expansion_config.revision,
 			expansion_config.fab_revision);
+		MUX_GUMSTIX();
 		MUX_ARBOR43C();
 		setenv("defaultdisplay", "lcd43");
 		break;
@@ -328,16 +346,17 @@ int misc_init_r(void)
 		printf("Recognized Ettus Research USRP-E (rev %d %s)\n",
 			expansion_config.revision,
 			expansion_config.fab_revision);
+		MUX_GUMSTIX();
 		MUX_USRP_E();
 		setenv("defaultdisplay", "dvi");
 		break;
 	case GUMSTIX_NO_EEPROM:
-		puts("No EEPROM on expansion board\n");
+	case GUMSTIX_EMPTY_EEPROM:
+		puts("No or empty EEPROM on expansion board\n");
+		MUX_GUMSTIX();
 		setenv("expansionname", "tobi");
 		break;
 	default:
-		if (expansion_id == 0x0)
-			setenv("expansionname", "tobi");
 		printf("Unrecognized expansion board 0x%08x\n", expansion_id);
 		break;
 	}
board/overo/overo.h +79 -71

212 lines not on this page · raw message

Signature · 1 line
2.1.0
#8 lore raw

PATCH 4/5 omap3: overo: Separate module and expansion board MUX configuration

Quoted 6 lines · Stefan Herbrechtsmeier

Separate overo module and expansion board MUX configuration. This allows an foreign expansion board to use the boot loader without any adaption. It only needs to save the expansion name in the EEPROM to load a specific device tree.

Applied to u-boot-ti/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141023/9017c30e/attachment.pgp>
#9 lore raw

PATCH 5/5 omap3: overo: Add usb host support

In reply to Stefan Herbrechtsmeier

---

 board/overo/overo.c           | 34 ++++++++++++++++++++++++++++++++++
 include/configs/omap3_overo.h |  8 ++++++++
 2 files changed, 42 insertions(+)
board/overo/overo.c +34 -0
index 488246b..66146ee 100644
@@ -25,6 +25,11 @@
 #include <asm/mach-types.h>
 #include "overo.h"
 
+#ifdef CONFIG_USB_EHCI
+#include <usb.h>
+#include <asm/ehci-omap.h>
+#endif
+
 DECLARE_GLOBAL_DATA_PTR;
 
 #define TWL4030_I2C_BUS			0
@@ -474,3 +479,32 @@ int board_mmc_init(bd_t *bis)
 	return omap_mmc_init(0, 0, 0, -1, -1);
 }
 #endif
+
+#if defined(CONFIG_USB_EHCI) &&  !defined(CONFIG_SPL_BUILD)
+static struct omap_usbhs_board_data usbhs_bdata = {
+	.port_mode[0] = OMAP_USBHS_PORT_MODE_UNUSED,
+	.port_mode[1] = OMAP_EHCI_PORT_MODE_PHY,
+	.port_mode[2] = OMAP_USBHS_PORT_MODE_UNUSED
+};
+
+#define GUMSTIX_GPIO_USBH_CPEN		168
+int ehci_hcd_init(int index, enum usb_init_type init,
+		  struct ehci_hccr **hccr, struct ehci_hcor **hcor)
+{
+	/* Enable USB power */
+	if (!gpio_request(GUMSTIX_GPIO_USBH_CPEN, "usbh_cpen"))
+		gpio_direction_output(GUMSTIX_GPIO_USBH_CPEN, 1);
+
+	return omap_ehci_hcd_init(index, &usbhs_bdata, hccr, hcor);
+}
+
+int ehci_hcd_stop(void)
+{
+	/* Disable USB power */
+	gpio_set_value(GUMSTIX_GPIO_USBH_CPEN, 0);
+	gpio_free(GUMSTIX_GPIO_USBH_CPEN);
+
+	return omap_ehci_hcd_stop();
+}
+
+#endif /* CONFIG_USB_EHCI */
include/configs/omap3_overo.h +8 -0
index d042eea..c58636a 100644
@@ -35,6 +35,13 @@
 /* TWL4030 LED */
 #define CONFIG_TWL4030_LED
 
+/* USB EHCI */
+#define CONFIG_USB_EHCI
+#define CONFIG_USB_EHCI_OMAP
+#define CONFIG_USB_STORAGE
+#define CONFIG_OMAP_EHCI_PHY1_RESET_GPIO	183
+#define CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS	3
+
 /* Initialize GPIOs by default */
 #define CONFIG_OMAP3_GPIO_2	/* GPIO32..63 is in GPIO Bank 2 */
 #define CONFIG_OMAP3_GPIO_3	/* GPIO64..95 is in GPIO Bank 3 */
@@ -44,6 +51,7 @@
 
 /* commands to include */
 #define CONFIG_CMD_CACHE
+#define CONFIG_CMD_USB
 #undef CONFIG_CMD_FPGA		/* FPGA configuration Support	*/
 #undef CONFIG_CMD_IMI		/* iminfo			*/
 #undef CONFIG_CMD_NFS		/* NFS support			*/
Signature · 1 line
2.1.0
#10 lore raw

PATCH 5/5 omap3: overo: Add usb host support

Quoted 1 line · Stefan Herbrechtsmeier

Applied to u-boot-ti/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141023/dd474e2b/attachment.pgp>
#11 lore raw

cover omap3: overo: Add foreign expansion board support

In reply to Stefan Herbrechtsmeier

Am 16.09.2014 um 17:51 schrieb Stefan Herbrechtsmeier:

Quoted 25 lines

At the moment the boot loader use a common configuration for all Gumstix Overo expansion boards. This also includes configuration of all inputs and outputs even if they aren't used by the boot loader. Because the Overo module could be used on foreign expansion boards with different configurations this could lead to problems. Split the configuration into a Overo module and expansion board part. The expansion board configuration is skipped if a foreign expansion board is detected. This enables a foreign expansion board to use the common boot loader without any modifications. It could load a specific device tree by saving the expansion name in the EEPROM.

Additionally fix some errors in the environment configuration and add USB host support.

The series is only tested on a foreign expansion boards. It would be nice if somebody could test it on an expansion board with network support.

Stefan Herbrechtsmeier (5):
omap3: overo: Fix fdtfile test
omap3: overo: Call bootm only after successful nand read
omap3: overo: Move ethernet setup to board_eth_init function
omap3: overo: Separate module and expansion board MUX configuration
omap3: overo: Add usb host support

Quoted 5 lines
  board/overo/overo.c           | 137 ++++++++++++++++++++++++++++----------
  board/overo/overo.h           | 150 ++++++++++++++++++++++--------------------
  include/configs/omap3_overo.h |  15 ++++-
  3 files changed, 195 insertions(+), 107 deletions(-)

Any comments would be appreciated.

#12 lore raw

cover omap3: overo: Add foreign expansion board support

In reply to Stefan Herbrechtsmeier
Quoted 25 lines · Stefan Herbrechtsmeier

At the moment the boot loader use a common configuration for all Gumstix Overo expansion boards. This also includes configuration of all inputs and outputs even if they aren't used by the boot loader. Because the Overo module could be used on foreign expansion boards with different configurations this could lead to problems. Split the configuration into a Overo module and expansion board part. The expansion board configuration is skipped if a foreign expansion board is detected. This enables a foreign expansion board to use the common boot loader without any modifications. It could load a specific device tree by saving the expansion name in the EEPROM.

Additionally fix some errors in the environment configuration and add USB host support.

The series is only tested on a foreign expansion boards. It would be nice if somebody could test it on an expansion board with network support.

Stefan Herbrechtsmeier (5):
omap3: overo: Fix fdtfile test
omap3: overo: Call bootm only after successful nand read
omap3: overo: Move ethernet setup to board_eth_init function
omap3: overo: Separate module and expansion board MUX configuration
omap3: overo: Add usb host support

Quoted 4 lines
 board/overo/overo.c           | 137 ++++++++++++++++++++++++++++----------
 board/overo/overo.h           | 150 ++++++++++++++++++++++--------------------
 include/configs/omap3_overo.h |  15 ++++-
 3 files changed, 195 insertions(+), 107 deletions(-)

For the record, I plan to take 2, 3, 4 and 5 for the next merge but 1/5 is clearly a bugfix. Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141010/d24b0315/attachment.pgp>
#13 lore raw

cover omap3: overo: Add foreign expansion board support

Thanks Tom.

And Stefan: I apologize for my delayed review on these. --Ash

Quoted 43 lines · Tom Rini
Quoted 25 lines · Stefan Herbrechtsmeier

At the moment the boot loader use a common configuration for all Gumstix Overo expansion boards. This also includes configuration of all inputs and outputs even if they aren't used by the boot loader. Because the Overo module could be used on foreign expansion boards with different configurations this could lead to problems. Split the configuration into a Overo module and expansion board part. The expansion board configuration is skipped if a foreign expansion board is detected. This enables a foreign expansion board to use the common boot loader without any modifications. It could load a specific device tree by saving the expansion name in the EEPROM.

Additionally fix some errors in the environment configuration and add USB host support.

The series is only tested on a foreign expansion boards. It would be nice if somebody could test it on an expansion board with network support.

Stefan Herbrechtsmeier (5):
omap3: overo: Fix fdtfile test
omap3: overo: Call bootm only after successful nand read
omap3: overo: Move ethernet setup to board_eth_init function
omap3: overo: Separate module and expansion board MUX configuration
omap3: overo: Add usb host support

Quoted 4 lines
 board/overo/overo.c           | 137 ++++++++++++++++++++++++++++----------
 board/overo/overo.h           | 150 ++++++++++++++++++++++--------------------
 include/configs/omap3_overo.h |  15 ++++-
 3 files changed, 195 insertions(+), 107 deletions(-)

For the record, I plan to take 2, 3, 4 and 5 for the next merge but 1/5 is clearly a bugfix. Thanks!

--
Tom

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot