m88ts2022: return the err code in its probe function when error occurs.

PATCH New Nibble Max 1 participant 1 message Oct 23, 2014 Media (V4L/DVB)

Share & tools

Nibble Max

author

2014-10-23 13:36 UTC #0 lore raw

PATCH 1/1 m88ts2022: return the err code in its probe function when error occurs.

if "chip_id" is wrong or "dev->cfg.clock_out" is invalid, the i2c model is still loaded. It will cause "kernel NULL pointer dereference" oops when the i2c model remove. returning the err code will prevent the i2c model load.

Signed-off-by Nibble Max <[email protected]>

---
 drivers/media/tuners/m88ts2022.c | 2 ++
 1 file changed, 2 insertions(+)

drivers/media/tuners/m88ts2022.c +2 -0

index caa5423..066e543 100644
@@ -488,6 +488,7 @@ static int m88ts2022_probe(struct i2c_client *client,
 	case 0x83:
 		break;
 	default:
+		ret = -ENODEV;
 		goto err;
 	}

@@ -505,6 +506,7 @@ static int m88ts2022_probe(struct i2c_client *client,
 		u8tmp = 0x6c;
 		break;
 	default:
+		ret = -EINVAL;
 		goto err;
 	}

Signature · 1 line

1.9.1