Skip to contentSkip to conversation

coreutils: add optionals, use single binary

PATCH New Gustavo Zacarias 2 participants 2 messages Oct 25, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 coreutils: add optionals, use single binary

Add proper support for optional libraries: acl, attr, gmp & libcap.

Also build the single binary as pointed out by P?draig Brady for some neat space savings.
Use the shebang (default) method since it allows us to move binaries into other directories to suit our needs whereas for symlink that wouldn't be so easy.

---
 package/coreutils/coreutils.mk | 26 +++++++++++++++++++++++++-
 1 file changed, 25 insertions(+), 1 deletion(-)
package/coreutils/coreutils.mk +25 -1
index 54c7892..1a25a3a 100644
@@ -20,6 +20,30 @@ ifeq ($(BR2_PACKAGE_BUSYBOX),y)
 COREUTILS_DEPENDENCIES = busybox
 endif
 
+ifeq ($(BR2_PACKAGE_ACL),y)
+COREUTILS_DEPENDENCIES += acl
+else
+COREUTILS_CONF_OPTS += --disable-acl
+endif
+
+ifeq ($(BR2_PACKAGE_ATTR),y)
+COREUTILS_DEPENDENCIES += attr
+else
+COREUTILS_CONF_OPTS += --disable-xattr
+endif
+
+ifeq ($(BR2_PACKAGE_GMP),y)
+COREUTILS_DEPENDENCIES += gmp
+else
+COREUTILS_CONF_OPTS += --without-gmp
+endif
+
+ifeq ($(BR2_PACKAGE_LIBCAP),y)
+COREUTILS_DEPENDENCIES += libcap
+else
+COREUTILS_CONF_OPTS += --disable-libcap
+endif
+
 COREUTILS_BIN_PROGS = cat chgrp chmod chown cp date dd df dir echo false \
 	ln ls mkdir mknod mv pwd rm rmdir vdir sleep stty sync touch true \
 	uname join
@@ -61,7 +85,7 @@ COREUTILS_CONF_ENV = ac_cv_c_restrict=no \
 		utils_cv_localtime_cache=no \
 		PERL=missing
 
-COREUTILS_CONF_OPTS = --disable-rpath
+COREUTILS_CONF_OPTS = --disable-rpath --enable-single-binary=shebangs
 
 define COREUTILS_POST_INSTALL
 	# some things go in root rather than usr
Signature · 1 line
2.0.4
#1 lore raw

PATCH 1/1 coreutils: add optionals, use single binary

Dear Gustavo Zacarias,

Quoted 7 lines · Gustavo Zacarias

Add proper support for optional libraries: acl, attr, gmp & libcap.

Also build the single binary as pointed out by P?draig Brady for some neat space savings.
Use the shebang (default) method since it allows us to move binaries into other directories to suit our needs whereas for symlink that wouldn't be so easy.

Indeed, very nice space saving.

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com