Skip to contentSkip to conversation

package/libcap: Fix build error with kernel headers < 3.6

PATCH Superseded Bernd Kuhls 2 participants 2 messages Oct 26, 2014

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Bernd Kuhls

author
#0 lore raw

PATCH 1/1 package/libcap: Fix build error with kernel headers < 3.6

Fixes
http://autobuild.buildroot.net/results/cce/cceb1ccacec36fb7ef41bb7cdb13b3014813b599/

XATTR_NAME_CAPS appears in kernel headers since 3.7:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/log/include/uapi/linux/xattr.h?id=v3.7

Before it was an internal define of the kernel:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/include/linux/xattr.h?id=607ca46e97a1b6594b29647d98a32d545c24bdff

Signed-off-by Bernd Kuhls <[email protected]>
---
 package/libcap/Config.in |    4 ++++
 1 file changed, 4 insertions(+)
package/libcap/Config.in +4 -0
index 5b0c827..a019928 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_LIBCAP
 	bool "libcap"
+	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_7
 	help
 	  This library implements the user-space interfaces to the
 	  POSIX 1003.1e capabilities available in Linux kernels. These

@@ -22,3 +23,6 @@ config BR2_PACKAGE_LIBCAP_TOOLS
 	  CONFIG_EXT2_FS_XATTR and CONFIG_EXT2_FS_SECURITY for ext2).
 
 endif
+
+comment "libcap needs headers >= 3.7"
+	depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_7
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/1 package/libcap: Fix build error with kernel headers < 3.6

Dear Bernd Kuhls,

Quoted 26 lines · Bernd Kuhls

Fixes
http://autobuild.buildroot.net/results/cce/cceb1ccacec36fb7ef41bb7cdb13b3014813b599/

XATTR_NAME_CAPS appears in kernel headers since 3.7:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/log/include/uapi/linux/xattr.h?id=v3.7

Before it was an internal define of the kernel:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/include/linux/xattr.h?id=607ca46e97a1b6594b29647d98a32d545c24bdff

Signed-off-by Bernd Kuhls <[email protected]>
---
 package/libcap/Config.in |    4 ++++
 1 file changed, 4 insertions(+)
package/libcap/Config.in +1 -0
index 5b0c827..a019928 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_LIBCAP
 	bool "libcap"
+	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_7
 	help
 	  This library implements the user-space interfaces to the
 	  POSIX 1003.1e capabilities available in Linux kernels. These

package/libcap/Config.in config BR2_PACKAGE_LIBCAP_TOOLS · line 28

Quoted 6 lines
package/libcap/Config.in +3 -0
@@ -22,3 +23,6 @@ config BR2_PACKAGE_LIBCAP_TOOLS
 	  CONFIG_EXT2_FS_XATTR and CONFIG_EXT2_FS_SECURITY for ext2).
 
 endif
+
+comment "libcap needs headers >= 3.7"
+	depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_7

When you add a new dependency to a package, it needs to be propagated to the reverse dependencies of that package:

package/cdrkit/Config.in:       select BR2_PACKAGE_LIBCAP
package/lxc/Config.in:  select BR2_PACKAGE_LIBCAP
package/squid/Config.in:        select BR2_PACKAGE_LIBCAP
package/systemd/Config.in:      select BR2_PACKAGE_LIBCAP

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com