sched:add check of shallowest_idle_cpu before search for least_loaded_cpu
PATCH v2 1/1 sched:add check of shallowest_idle_cpu before search for least_loaded_cpu
Idle cpu is idler than non-idle cpu, so we needn't search for least_loaded_cpu after we have found an idle cpu.
---
kernel/sched/fair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/sched/fair.c +1 -1
@@ -4446,7 +4446,7 @@ find_idlest_cpu(struct sched_group *group, struct task_struct *p, int this_cpu) latest_idle_timestamp = rq->idle_stamp; shallowest_idle_cpu = i; } - }else { + }else if (shallowest_idle_cpu ==-1 ) { load =weighted_cpuload (i);if (load < min_load || (load == min_load && i == this_cpu)) { min_load = load;
--
1.8.0.1
Peter Zijlstra
maintainerPlease as to try again:
Applying patch patches/yao_dongdong-sched_add_check_of_shallowest_idle_cpu_before_search_for_least_loaded_cpu.patch
patching file kernel/sched/fair.c
Hunk #1 FAILED at 4446.
1 out of 1 hunk FAILED -- rejects in file kernel/sched/fair.c
Patch patches/yao_dongdong-sched_add_check_of_shallowest_idle_cpu_before_search_for_least_loaded_cpu.patch does not apply (enforce with -f) quilt returned 1, with 0 fuzz and 1 rejects
use quilt -f? y/n [y]: y
Applying patch patches/yao_dongdong-sched_add_check_of_shallowest_idle_cpu_before_search_for_least_loaded_cpu.patch
patching file kernel/sched/fair.c
Hunk #1 FAILED at 4446.
1 out of 1 hunk FAILED -- saving rejects to file kernel/sched/fair.c.rej
Applied patch patches/yao_dongdong-sched_add_check_of_shallowest_idle_cpu_before_search_for_least_loaded_cpu.patch (forced; needs refresh) reject patch patches/yao_dongdong-sched_add_check_of_shallowest_idle_cpu_before_search_for_least_loaded_cpu.patch file kernel/sched/fair.c hunk 1 line 4 [a]uto[m]erge,edit [f]ile [p]atch [r]ej,[n]ext,[d]elete: [amfdprn]: m
rej started:
[a]uto[m]erge,edit [f]ile [p]atch [r]ej,[n]ext,[d]elete: [amfdprn]: kernel/sched/fair.c: 1 matched, 0 conflicts remain
npatches/yao_dongdong-sched_add_check_of_shallowest_idle_cpu_before_search_for_least_loaded_cpu.patch done [s]top, [n]ext, [r]efresh [snr]: r
WARNING: Use a single space after Signed-off-by:
#13:
ERROR: code indent should use tabs where possible
#25: FILE: kernel/sched/fair.c:4644:
+ } else if (shallowest_idle_cpu == -1) {$
WARNING: please, no spaces at the start of a line
#25: FILE: kernel/sched/fair.c:4644:
+ } else if (shallowest_idle_cpu == -1) {$
total: 1 errors, 2 warnings, 8 lines checked
NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or
scripts/cleanfile
Quoted 32 lines · Peter Zijlstra
Please as to try again:
Applying patch
patches/yao_dongdong-sched_add_check_of_shallowest_idle_cpu_before_search_for_least_loaded_cpu.patch
patching filekernel/sched/fair.c
Hunk #1 FAILED at 4446.
1 out of 1 hunk FAILED -- rejects in filekernel/sched/fair.c
Patchpatches/yao_dongdong-sched_add_check_of_shallowest_idle_cpu_before_search_for_least_loaded_cpu.patchdoes not apply (enforce with -f) quilt returned 1, with 0 fuzz and 1 rejects
use quilt -f? y/n [y]: y
Applying patchpatches/yao_dongdong-sched_add_check_of_shallowest_idle_cpu_before_search_for_least_loaded_cpu.patch
patching filekernel/sched/fair.c
Hunk #1 FAILED at 4446.
1 out of 1 hunk FAILED -- saving rejects to filekernel/sched/fair.c.rej
Applied patchpatches/yao_dongdong-sched_add_check_of_shallowest_idle_cpu_before_search_for_least_loaded_cpu.patch(forced; needs refresh) reject patchpatches/yao_dongdong-sched_add_check_of_shallowest_idle_cpu_before_search_for_least_loaded_cpu.patchfilekernel/sched/fair.chunk 1 line 4 [a]uto[m]erge,edit [f]ile [p]atch [r]ej,[n]ext,[d]elete: [amfdprn]: m
rej started:
[a]uto[m]erge,edit [f]ile [p]atch [r]ej,[n]ext,[d]elete: [amfdprn]:kernel/sched/fair.c: 1 matched, 0 conflicts remain
npatches/yao_dongdong-sched_add_check_of_shallowest_idle_cpu_before_search_for_least_loaded_cpu.patchdone [s]top, [n]ext, [r]efresh [snr]: r
WARNING: Use a single space after Signed-off-by:
#13:Signed-off-by [email protected]ERROR: code indent should use tabs where possible
#25: FILE:kernel/sched/fair.c:4644:
+ } else if (shallowest_idle_cpu== -1) {$WARNING: please, no spaces at the start of a line
#25: FILE:kernel/sched/fair.c:4644:
+ } else if (shallowest_idle_cpu== -1) {$
Quoted 7 lines
total: 1 errors, 2 warnings, 8 lines checked
NOTE: whitespace errors detected, you may wish to use
scripts/cleanpatchor
scripts/cleanfile.
I 'm sorry, and i will fix and resend another one.
Thanks,
Yao Dongdong