Skip to contentSkip to conversation

libgtk3: fix undefined reference to get_xkb()

PATCH Superseded Eric Le Bihan 2 participants 3 messages Oct 27, 2014

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Eric Le Bihan

author
#0 lore raw

PATCH 1/1 libgtk3: fix undefined reference to get_xkb()

When configuring Gtk+ with --disable-xkb, the build fails because of an undefined reference to get_xkb().

This issue as been reported upstream [1]. This patch fixes it.

Fixes 513d79b97bb8ad0e5cd431c47c706b5ec87a9882
Fixes 0c3f1df92481852622445478d2239371fc818f41

[1] https://bugzilla.gnome.org/show_bug.cgi?id=739070

Signed-off-by Eric Le Bihan <[email protected]>
---
 ...3-0004-Fix-undefined-reference-to-get_xkb.patch | 33 ++++++++++++++++++++++
 1 file changed, 33 insertions(+)
 create mode 100644 package/libgtk3/libgtk3-0004-Fix-undefined-reference-to-get_xkb.patch
package/libgtk3/libgtk3-0004-Fix-undefined-reference-to-get_xkb.patch new file +33 -0
new file mode 100644
index 0000000..c2f4b4f
@@ -0,0 +1,33 @@
+From b64a04250b1f35923434158beb6ddb5726b41eac Mon Sep 17 00:00:00 2001
+From: Eric Le Bihan <[email protected]>
+Date: Mon, 27 Oct 2014 10:34:38 +0100
+Subject: [PATCH 1/1] Fix undefined reference to get_xkb()
+
+When configuring Gtk+ with --disable-xkb, the build fails because of an
+undefined reference to get_xkb().
+
+This patch fixes this issue.
+
+Signed-off-by: Eric Le Bihan <[email protected]>
+---
+ gdk/x11/gdkkeys-x11.c | 2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git a/gdk/x11/gdkkeys-x11.c b/gdk/x11/gdkkeys-x11.c
+index c45a971..6a5481b 100644
+--- a/gdk/x11/gdkkeys-x11.c
++++ b/gdk/x11/gdkkeys-x11.c
+@@ -1498,8 +1498,10 @@ gdk_x11_keymap_map_virtual_modifiers (GdkKeymap       *keymap,
+   int i, j;
+   gboolean retval;
+ 
++#ifdef HAVE_XKB
+   if (KEYMAP_USE_XKB (keymap))
+     get_xkb (keymap_x11);
++#endif
+ 
+   retval = TRUE;
+ 
+-- 
+1.9.1
+
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 libgtk3: fix undefined reference to get_xkb()

Dear Eric Le Bihan,

Quoted 7 lines · Eric Le Bihan

When configuring Gtk+ with --disable-xkb, the build fails because of an undefined reference to get_xkb().

This issue as been reported upstream [1]. This patch fixes it.

Fixes 513d79b97bb8ad0e5cd431c47c706b5ec87a9882
Fixes 0c3f1df92481852622445478d2239371fc818f41

Are these commit IDs, or autobuilder result IDs? If the latter, then it should be full URL to the autobuilder result.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#2 lore raw

PATCH 1/1 libgtk3: fix undefined reference to get_xkb()

Hi!

Quoted 6 lines · Thomas Petazzoni

Dear Eric Le Bihan,

Quoted 3 lines · Eric Le Bihan

When configuring Gtk+ with --disable-xkb, the build fails because of an undefined reference to get_xkb().

Quoted 7 lines
Quoted 4 lines

This issue as been reported upstream [1]. This patch fixes it.

Fixes 513d79b97bb8ad0e5cd431c47c706b5ec87a9882
Fixes 0c3f1df92481852622445478d2239371fc818f41

Are these commit IDs, or autobuilder result IDs? If the latter, then it should be full URL to the autobuilder result.

D'Oh! I will a new version with the correct URLs.

Best regards
ELB