Skip to contentSkip to conversation

trinity: Disable for Microblaze architecture

PATCH New Vicente Olivert Riera 2 participants 5 messages Oct 27, 2014 – Oct 28, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 trinity: Disable for Microblaze architecture

This package doesn't support the Microblaze architecture. The full list of supported architectures is in the trinity website, and Microblaze is not among them.

Fixes:

	http://autobuild.buildroot.net/results/ea7/ea788f1f0ed5ee4e9b1bf0c8a0d1304e7467dc77/
---
 package/trinity/Config.in |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
package/trinity/Config.in +1 -0
index de9c467..9882573 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_TRINITY
 	bool "trinity"
+	depends on !BR2_microblazeel && !BR2_microblazeeb
 	help
 	  A Linux System call fuzz tester
 
Signature · 1 line
1.7.1
#1 lore raw

PATCH 1/1 trinity: Disable for Microblaze architecture

Dear Vicente Olivert Riera,

Quoted 3 lines · Vicente Olivert Riera

This package doesn't support the Microblaze architecture. The full list of supported architectures is in the trinity website, and Microblaze is not among them.

Then what we want is not something like the patch you propose, but instead a patch using positive logic to enable Trinity only on the architecture that are known to work.

The website says: "Trinity supports Alpha, Aarch64, ARM, i386, IA-64, MIPS, PowerPC-64, S390, S390x, SPARC-64, x86-64.". So it means that not only Microblaze is going to cause issue, but also Blackfin, ARC, Xtensa, SPARC 32 bits, and probably some others I forgot.

Can you respin the patch with something like:

	depends BR2_... || BR2_... || BR2_...

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 trinity: Disable for Microblaze architecture

Dear Thomas Petazzoni,

Quoted 16 lines · Thomas Petazzoni

Dear Vicente Olivert Riera,

Quoted 3 lines · Vicente Olivert Riera

This package doesn't support the Microblaze architecture. The full list of supported architectures is in the trinity website, and Microblaze is not among them.

Then what we want is not something like the patch you propose, but instead a patch using positive logic to enable Trinity only on the architecture that are known to work.

The website says: "Trinity supports Alpha, Aarch64, ARM, i386, IA-64, MIPS, PowerPC-64, S390, S390x, SPARC-64, x86-64.". So it means that not only Microblaze is going to cause issue, but also Blackfin, ARC, Xtensa, SPARC 32 bits, and probably some others I forgot.

Quoted 7 lines

Can you respin the patch with something like:

	depends BR2_... || BR2_... || BR2_...

Thanks!

Thomas

Done: http://patchwork.ozlabs.org/patch/403703/

I have marked the former patch as superseded.

Best regards,

Signature · 5 lines
Vicente Olivert Riera
Graduate Software Engineer, MIPS Processor IP
Imagination Technologies Limited
t: +44 (0)113 2429814
www.imgtec.com
#3 lore raw

PATCH 1/1 trinity: Disable for Microblaze architecture

Dear Vicente Olivert Riera,

Quoted 1 line · Vicente Olivert Riera

Done: http://patchwork.ozlabs.org/patch/403703/

This is exactly the same patch as before. What happened ? :-)

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#4 lore raw

PATCH 1/1 trinity: Disable for Microblaze architecture

Dear Thomas Petazzoni,

Quoted 7 lines · Thomas Petazzoni

Dear Vicente Olivert Riera,

Quoted 1 line · Vicente Olivert Riera

Done: http://patchwork.ozlabs.org/patch/403703/

This is exactly the same patch as before. What happened ? :-)

git add... :-(

I have sent the right patch now.

Thanks!

Signature · 5 lines
Vicente Olivert Riera
Graduate Software Engineer, MIPS Processor IP
Imagination Technologies Limited
t: +44 (0)113 2429814
www.imgtec.com