gic: fixed compilation error in GICv2 wait for interrupt macro
PATCH 1/1 gic: fixed compilation error in GICv2 wait for interrupt macro
a hexadicemal value was missing the "0x" prefix which caused assembler error
--- arch/arm/include/asm/macro.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/include/asm/macro.h +1 -1
@@ -193,7 +193,7 @@ lr .req x30 0 : wfi ldr \wreg2, [\xreg1, GICC_AIAR] str \wreg2, [\xreg1, GICC_AEOIR] - and \wreg2, \wreg2, #3ff + and \wreg2, \wreg2, #0x3ff cbnz \wreg2, 0b .endm #endif
Signature · 1 line
1.8.1.2
PATCH 1/1 gic: fixed compilation error in GICv2 wait for interrupt macro
Hello Yehuda,
Quoted 23 lines · Yehuda Yitschak
a hexadicemal value was missing the "0x" prefix which caused assembler errorSigned-off-by Yehuda Yitschak <[email protected]>--- arch/arm/include/asm/macro.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/include/asm/macro.h +1
-1@@ -193,7 +193,7 @@ lr .req x30 0 : wfi ldr \wreg2, [\xreg1, GICC_AIAR] str \wreg2, [\xreg1, GICC_AEOIR] - and \wreg2, \wreg2, #3ff + and \wreg2, \wreg2, #0x3ff cbnz \wreg2, 0b .endm #endifSignature · 1 line
1.8.1.2
Which board(s) does this error show up in?
Amicalement,
Signature · 1 line
Albert.
PATCH 1/1 gic: fixed compilation error in GICv2 wait for interrupt macro
Hello Albert
Quoted 31 lines
-----Original Message-----
From: Albert ARIBAUD [mailto:albert.u.boot at aribaud.net]
Sent: Monday, October 27, 2014 15:05
To: Yehuda Yitschak
Cc: u-boot at lists.denx.de; arnab.basu at freescale.com;
fenghua at phytium.com.cn; yorksun at freescale.com;
scottwood at freescale.com
Subject: Re: [PATCH] gic: fixed compilation error in GICv2 wait for interrupt macroHello Yehuda,
Quoted 17 lines · Yehuda Yitschak
a hexadicemal value was missing the "0x" prefix which caused assembler errorSigned-off-by Yehuda Yitschak <[email protected]>--- arch/arm/include/asm/macro.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)(quoted diff) +0
-0
b/arch/arm/include/asm/macro.hindex 541b443..1c8c425 100644arch/arm/include/asm/macro.h +0
-1@@ -193,7 +193,7 @@ lr .req x30 0 : wfi ldr \wreg2, [\xreg1, GICC_AIAR] str \wreg2, [\xreg1, GICC_AEOIR] - and \wreg2, \wreg2, #3ff
Quoted 8 lines
Quoted 6 lines
arch/arm/include/asm/macro.h +1
-1+ and \wreg2, \wreg2, #0x3ff cbnz \wreg2, 0b .endm #endif --1.8.1.2
Which board(s) does this error show up in?
There is no board in u-boot 2014.01 that use GICv2. I guess this is why it went under radar I use mainline u-boot for one of my platforms so I noticed the bug once I rebased to 2014.10
Yehuda
Quoted 4 lines
Amicalement,
--
Albert.
PATCH 1/1 gic: fixed compilation error in GICv2 wait for interrupt macro
Hello Yehuda,
Quoted 6 lines · Yehuda Yitschak
Hello Albert
Quoted 1 line
Which board(s) does this error show up in?
There is no board in u-boot 2014.01 that use GICv2. I guess this is why it went under radar I use mainline u-boot for one of my platforms so I noticed the bug once I rebased to 2014.10
Thanks for the explanation.
Quoted 1 line
Yehuda
Amicalement,
Signature · 1 line
Albert.
PATCH 1/1 gic: fixed compilation error in GICv2 wait for interrupt macro
In reply to Yehuda YitschakHello Yehuda,
Quoted 23 lines · Yehuda Yitschak
a hexadicemal value was missing the "0x" prefix which caused assembler errorSigned-off-by Yehuda Yitschak <[email protected]>--- arch/arm/include/asm/macro.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/include/asm/macro.h +1
-1@@ -193,7 +193,7 @@ lr .req x30 0 : wfi ldr \wreg2, [\xreg1, GICC_AIAR] str \wreg2, [\xreg1, GICC_AEOIR] - and \wreg2, \wreg2, #3ff + and \wreg2, \wreg2, #0x3ff cbnz \wreg2, 0b .endm #endifSignature · 1 line
1.8.1.2
Applied to u-boot-arm/master (as a preventive bug fix), thanks!
Amicalement,
Signature · 1 line
Albert.