Skip to contentSkip to conversation

common/cmd_io.c: Fix incorrect help for iod/iow

PATCH In review Bin Meng 3 participants 6 messages Oct 20, 2014 – Oct 27, 2014

lore
Share & tools
lore

Bin Meng

author
#0 lore raw

PATCH 1/1 common/cmd_io.c: Fix incorrect help for iod/iow

---
 common/cmd_io.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
common/cmd_io.c +3 -3
index eefac36..c59148f 100644
@@ -70,8 +70,8 @@ int do_io_iow(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[])
 
 /**************************************************/
 U_BOOT_CMD(iod, 2, 0, do_io_iod,
-	   "IO space display", "[.b, .w, .l] address [# of objects]");
+	   "IO space display", "[.b, .w, .l] address");
 
 U_BOOT_CMD(iow, 3, 0, do_io_iow,
-	   "IO space modify (auto-incrementing address)",
-	   "[.b, .w, .l] address");
+	   "IO space modify",
+	   "[.b, .w, .l] address value");
Signature · 1 line
1.8.2.1
#1 lore raw

PATCH 1/1 common/cmd_io.c: Fix incorrect help for iod/iow

Hi Bin,

Quoted 11 lines · Bin Meng
---
 common/cmd_io.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
common/cmd_io.c +0 -0
index eefac36..c59148f 100644
@@ -70,8 +70,8 @@ int do_io_iow(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[])
 

common/cmd_io.c int do_io_iow(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[]) · line 77

Quoted 10 lines
common/cmd_io.c +3 -3
 /**************************************************/
 U_BOOT_CMD(iod, 2, 0, do_io_iod,
-          "IO space display", "[.b, .w, .l] address [# of objects]");
+          "IO space display", "[.b, .w, .l] address");
 
 U_BOOT_CMD(iow, 3, 0, do_io_iow,
-          "IO space modify (auto-incrementing address)",
-          "[.b, .w, .l] address");
+          "IO space modify",
+          "[.b, .w, .l] address value");

Are you using the coreboot support? What board are you using?

Regards,
SImon

author
#2 lore raw

PATCH 1/1 common/cmd_io.c: Fix incorrect help for iod/iow

Hi Simon,

Quoted 3 lines · Simon Glass

Hi Bin,

Are you using the coreboot support? What board are you using?

Not coreboot, but U-Boot directly booting from reset vector on Intel Crown Bay board.

Regards,
Bin

#3 lore raw

PATCH 1/1 common/cmd_io.c: Fix incorrect help for iod/iow

Hi Bin,

Quoted 9 lines · Bin Meng

Hi Simon,

Quoted 3 lines · Simon Glass

Hi Bin,

Are you using the coreboot support? What board are you using?

Not coreboot, but U-Boot directly booting from reset vector on Intel Crown Bay board.

OK I see - interesting! I talked with Wolfgang at the mini-Summit last week about a bare x86 port and he seemed keen on the idea. So I've been taking a look. I was planning to use the Minnowboard Max, but I don't have one yet (and it may be a long wait) so am looking at another board.

Are you planning to post patches? I am getting close to posting patches for booting to a prompt on link. If it helps I've pushed my WIP tree to u-boot-x86/bare-working. It boots to a prompt but does not include SMM, display and resource allocation (among other things).

Why are you using U-Boot?

Regards,
Simon

author
#4 lore raw

PATCH 1/1 common/cmd_io.c: Fix incorrect help for iod/iow

Hi Simon,

Quoted 7 lines · Simon Glass

Hi Bin,

OK I see - interesting! I talked with Wolfgang at the mini-Summit last week about a bare x86 port and he seemed keen on the idea. So I've been taking a look. I was planning to use the Minnowboard Max, but I don't have one yet (and it may be a long wait) so am looking at another board.

Glad to see we are going to have the bare x86 support again :)

Quoted 4 lines

Are you planning to post patches? I am getting close to posting patches for booting to a prompt on link. If it helps I've pushed my WIP tree to u-boot-x86/bare-working. It boots to a prompt but does not include SMM, display and resource allocation (among other things).

Yes, I would like to post patches when they are ready. Right now my patches are against the U-Boot v2014.07 release. One issue is that I am using Intel FSP for the memory and chipset initialization, which I am not sure if some IP review is needed. But given coreboot already adopts Intel FSP, I think it would be good.

Quoted 1 line

Why are you using U-Boot?

Small footprint, extreme fast boot speed, and a user friendly shell. Just cool for an embedded x86 platform.

Regards,
Bin

#5 lore raw
In reply to Bin Meng
Quoted 2 lines · Bin Meng

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141027/2f1263b8/attachment.pgp>