Skip to contentSkip to conversation

amba-pl011 complains about DMA for bcm2835 where it is not supported

DISCUSSION Piotr Król 2 participants 4 messages Oct 27, 2014 – Oct 28, 2014 TTY layer and serial drivers

lore
Share & tools
lore
#0 lore raw

Hi all,
according to BCM2835 ARM Peripherals spec DMA is optional functionality for ARM PL011 UART and it is not supported on this SoC. It looks like amba-pl011 search for device tree property (dma-names) unconditionally, what leads to error message:

of_dma_request_slave_channel: dma-names property of node '/soc/uart@7e201000' missing or empty uart-pl011 20201000.uart: no DMA platform data

I assume that if it is possible that amba-pl011 can be without DMA we should check if DMA is supported and then try to read properties. Is there any known method for checking dma support ? If yes that I would be glad for any pointers.

Let me know if I should ignore/accept this error message or there is some code fix needed.

Thanks,
Piotr Król
~
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#1 lore raw
Quoted 9 lines · Piotr Król

Hi all,
according to BCM2835 ARM Peripherals spec DMA is optional functionality for ARM PL011 UART and it is not supported on this SoC. It looks like amba-pl011 search for device tree property (dma-names) unconditionally, what leads to error message:

of_dma_request_slave_channel: dma-names property of node '/soc/uart@7e201000' missing or empty uart-pl011 20201000.uart: no DMA platform data

Quoted 7 lines

I assume that if it is possible that amba-pl011 can be without DMA we should check if DMA is supported and then try to read properties. Is there any known method for checking dma support ? If yes that I would be glad for any pointers.

Let me know if I should ignore/accept this error message or there is some code fix needed.

A great many implementations of PL011 do not have DMA support (some have DMA support but its well broken.) The driver has always supported PIO mode, and continues to do so.

Signature · 6 lines
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#2 lore raw
Quoted 15 lines · Russell King - ARM Linux
Quoted 14 lines · Piotr Król

Hi all,
according to BCM2835 ARM Peripherals spec DMA is optional functionality for ARM PL011 UART and it is not supported on this SoC. It looks like amba-pl011 search for device tree property (dma-names) unconditionally, what leads to error message:

of_dma_request_slave_channel: dma-names property of node '/soc/uart@7e201000' missing or empty uart-pl011 20201000.uart: no DMA platform data

I assume that if it is possible that amba-pl011 can be without DMA we should check if DMA is supported and then try to read properties. Is there any known method for checking dma support ? If yes that I would be glad for any pointers.

Quoted 7 lines
Quoted 2 lines

Let me know if I should ignore/accept this error message or there is some code fix needed.

A great many implementations of PL011 do not have DMA support (some have DMA support but its well broken.) The driver has always supported PIO mode, and continues to do so.

Driver works fine but IMHO this error message confuse user. Should I assume that error message is expected and we should not avoid it by trying to check if DMA is supported ?

BTW above error message do not indicate that DMA is not supported but indicates that something is wrong with DT, what in this case is not true.

Thanks,
Piotr Król

--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#3 lore raw
Quoted 24 lines · Piotr Król
Quoted 15 lines · Russell King - ARM Linux
Quoted 14 lines · Piotr Król

Hi all,
according to BCM2835 ARM Peripherals spec DMA is optional functionality for ARM PL011 UART and it is not supported on this SoC. It looks like amba-pl011 search for device tree property (dma-names) unconditionally, what leads to error message:

of_dma_request_slave_channel: dma-names property of node '/soc/uart@7e201000' missing or empty uart-pl011 20201000.uart: no DMA platform data

I assume that if it is possible that amba-pl011 can be without DMA we should check if DMA is supported and then try to read properties. Is there any known method for checking dma support ? If yes that I would be glad for any pointers.

Quoted 7 lines
Quoted 2 lines

Let me know if I should ignore/accept this error message or there is some code fix needed.

A great many implementations of PL011 do not have DMA support (some have DMA support but its well broken.) The driver has always supported PIO mode, and continues to do so.

Quoted 6 lines

Driver works fine but IMHO this error message confuse user. Should I assume that error message is expected and we should not avoid it by trying to check if DMA is supported ?

BTW above error message do not indicate that DMA is not supported but indicates that something is wrong with DT, what in this case is not true.

Unfortunately, the DT lobby believe that their way is the only way, and that drivers should always complain if DT stuff is missing. They seem to loose sight of what behaviour an "optional" property should have. I've seen this happen several times now, and I've commented on patches I saw today which had made driver initialisation /fail/ if various optional properties weren't specified!

Signature · 6 lines
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html