Make the unit size of the first chunk the same as other chunks
Subsystems (2)
PATCH 1/1 Make the unit size of the first chunk the same as other chunks
Since we have already allocated the full unit size for the first chunk, we might as well use it so that the unit size are the same for all chunks. The page first chunk allocator already has this effect because it allocates one page at a time.
--- mm/percpu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
mm/percpu.c +3 -3
@@ -1960,6 +1960,7 @@ int __init pcpu_embed_first_chunk(size_t reserved_size, size_t dyn_size,return PTR_ERR (ai); size_sum = ai->static_size + ai->reserved_size + ai->dyn_size; + ai->dyn_size += ai->unit_size - size_sum; areas_size =PFN_ALIGN (ai->nr_groups *sizeof (void *)); areas =memblock_virt_alloc_nopanic (areas_size,0 );
@@ -2006,9 +2007,8 @@ int __init pcpu_embed_first_chunk(size_t reserved_size, size_t dyn_size,free_fn (ptr, ai->unit_size);continue ; } -/* copy and return the unused part */ +/* copy static data */ memcpy (ptr, __per_cpu_load, ai->static_size); -free_fn (ptr + size_sum, ai->unit_size - size_sum); } }
@@ -2034,7 +2034,7 @@ int __init pcpu_embed_first_chunk(size_t reserved_size, size_t dyn_size, }pr_info ("PERCPU: Embedded %zu pages/cpu @%p s%zu r%zu d%zu u%zu\n" , -PFN_DOWN (size_sum), base, ai->static_size, ai->reserved_size, +PFN_DOWN (ai->unit_size), base, ai->static_size, ai->reserved_size, ai->dyn_size, ai->unit_size); rc =pcpu_setup_first_chunk (ai, base);
Signature · 1 line
1.8.1.2
Tejun Heo
maintainerQuoted 3 lines · Zhihui Zhang
Since we have already allocated the full unit size for the first chunk, we might as well use it so that the unit size are the same for all chunks. The page first chunk allocator already has this effect because it allocates one page at a time.
I'm not following. Where do we allocate the full unit size for the first chunk?
Thanks.
Signature · 1 line
tejun
In pcpu_embed_first_chunk(), we allocate full unit size for each CPU in the first chunk:
1981 /* allocate space for the whole group */
1982 ptr = alloc_fn(cpu, gi->nr_units * ai->unit_size,atom_size);
1983 if (!ptr) {
1984 rc = -ENOMEM;
1985 goto out_free_areas;
1986 }
Later we freed unused part:
2009 /* copy and return the unused part */ 2010 memcpy(ptr, __per_cpu_load, ai->static_size); 2011 free_fn(ptr + size_sum, ai->unit_size - size_sum);
I am trying to make each CPU to have a full unit size in the first chunk, same as in all other chunks. Does this make sense?
-Zhihui
Quoted 12 lines · Tejun Heo
Quoted 3 lines · Zhihui Zhang
Since we have already allocated the full unit size for the first chunk, we might as well use it so that the unit size are the same for all chunks. The page first chunk allocator already has this effect because it allocates one page at a time.
I'm not following. Where do we allocate the full unit size for the first chunk?
Thanks.
--
tejun
Tejun Heo
maintainerQuoted 2 lines · Zhihui Zhang
I am trying to make each CPU to have a full unit size in the first chunk, same as in all other chunks. Does this make sense?
And why are you trying to do that? Unit size may be highly variable. Why would it make sense to reserve memory area according to a value which can fluctuate for reasons completely unrelated to actual percpu memory usage?
Thanks.
Signature · 1 line
tejun
A message that is not in the archive (sent off-list or not yet received): CADFvMY+VUNaLhsJaPjH_DC91uJ8Hdgnaj9D44QEm0qV3Rr2-kA@mail.gmail.com
A message that is not in the archive (sent off-list or not yet received): [email protected]
I see your point. Thanks.
-Zhihui
Quoted 19 lines · Tejun Heo
Plesae restore lkml cc when replying.
Quoted 2 lines · Zhihui Zhang
My patch just increases the dynamic area in the first chunk slightly to cover the round up surplus. On my 64-bit laptop, it is 12288 bytes.
As I wrote before, it's 12288 bytes on your laptop but it can be much larger on other setups.
Quoted 3 lines
It will mostly likely be used, and in fact, a second chunk will be most likely needed as well. So in theory you are right, but in practice, it probably won't matter.
If the initial dynamic reserve is too small, which could be the case given the overall increase in percpu memory, increase
PERCPU_DYNAMIC_EARLY_SIZE.--
tejun