Skip to contentSkip to conversation

arm64/dt: add machine name to kernel call stack dump output

PATCH New Ard Biesheuvel 2 participants 2 messages Oct 28, 2014 arm64

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64/dt: add machine name to kernel call stack dump output

This installs the machine name as recorded by setup_machine_fdt() as dump stack arch description. This results in the string to be included in call stack dumps, as is shown here:

...
Bad mode in Synchronous Abort handler detected, code 0x84000005

  CPU: 0 PID: 1 Comm: swapper/0 Not tainted 3.18.0-rc2+ #548
Quoted 1 line
Hardware name: linux,dummy-virt (DT)

task: ffffffc07c870000 ti: ffffffc07c878000 task.ti: ffffffc07c878000 PC is at 0x0
...

Note that systems that support DMI/SMBIOS may override this later.

---
 arch/arm64/kernel/setup.c | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/kernel/setup.c +1 -0
index a6028490a28f..da5dd36e4353 100644
@@ -312,6 +312,7 @@ static void __init setup_machine_fdt(phys_addr_t dt_phys)
 	}
 
 	machine_name = of_flat_dt_get_machine_name();
+	dump_stack_set_arch_desc("%s (DT)", machine_name);
 }
 
 /*
Signature · 1 line
1.8.3.2
#1 lore raw

PATCH 1/1 arm64/dt: add machine name to kernel call stack dump output

Quoted 3 lines · Ard Biesheuvel

This installs the machine name as recorded by setup_machine_fdt() as dump stack arch description. This results in the string to be included in call stack dumps, as is shown here:

Thanks, I've just added this to ARM as well.

Signature · 2 lines
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.