Skip to contentSkip to conversation

FSL MSI Mapping

DISCUSSION Johannes Thumshirn 4 participants 8 messages Oct 28, 2014 – Nov 3, 2014

lore
Share & tools
lore
#0 lore raw

Hi,

I got notified about your patch to support multiple MSI Vectors on Freescale PowerPC platforms. Is there any reason why it wasn't applied until now? I couldn't find anything about it in the list archives.

I think it would be a real benefit for all to have multiple MSI vecotrs on PowerPCs.

Thanks in advance,
Johannes

#1 lore raw
Quoted 8 lines · Johannes Thumshirn

Hi,

I got notified about your patch to support multiple MSI Vectors on Freescale PowerPC platforms. Is there any reason why it wasn't applied until now? I couldn't find anything about it in the list archives.

I think it would be a real benefit for all to have multiple MSI vecotrs on PowerPCs.

Could you provide a patchwork link to the patch you're talking about?

-Scott

#2 lore raw
Quoted 11 lines · Scott Wood
Quoted 8 lines · Johannes Thumshirn

Hi,

I got notified about your patch to support multiple MSI Vectors on Freescale PowerPC platforms. Is there any reason why it wasn't applied until now? I couldn't find anything about it in the list archives.

I think it would be a real benefit for all to have multiple MSI vecotrs on PowerPCs.

Could you provide a patchwork link to the patch you're talking about?

Unfortunately I couldn't find it in the ppc patchwork, but here are the links to the patch series in the list archives:
https://lists.ozlabs.org/pipermail/linuxppc-dev/2014-February/115484.html
https://lists.ozlabs.org/pipermail/linuxppc-dev/2014-February/115485.html
https://lists.ozlabs.org/pipermail/linuxppc-dev/2014-February/115486.html

Thanks,
Johannes

#3 lore raw
Quoted 11 lines · Johannes Thumshirn
Quoted 10 lines · Scott Wood
Quoted 8 lines · Johannes Thumshirn

Hi,

I got notified about your patch to support multiple MSI Vectors on Freescale PowerPC platforms. Is there any reason why it wasn't applied until now? I couldn't find anything about it in the list archives.

I think it would be a real benefit for all to have multiple MSI vecotrs on PowerPCs.

Quoted 7 lines
Quoted 1 line

Could you provide a patchwork link to the patch you're talking about?

Unfortunately I couldn't find it in the ppc patchwork, but here are the links to the patch series in the list archives:
https://lists.ozlabs.org/pipermail/linuxppc-dev/2014-February/115484.html
https://lists.ozlabs.org/pipermail/linuxppc-dev/2014-February/115485.html
https://lists.ozlabs.org/pipermail/linuxppc-dev/2014-February/115486.html

They were in patchwork with changes requested in patch 1/2:
http://patchwork.ozlabs.org/patch/322497/
http://patchwork.ozlabs.org/patch/322334/

-Scott

#4 lore raw
In reply to Johannes Thumshirn
Quoted 8 lines · Johannes Thumshirn

Hi,

I got notified about your patch to support multiple MSI Vectors on Freescale PowerPC platforms. Is there any reason why it wasn't applied until now? I couldn't find anything about it in the list archives.

I think it would be a real benefit for all to have multiple MSI vecotrs on PowerPCs.

Why would you not use MSI-X ?

cheers

#5 lore raw
Quoted 12 lines · Michael Ellerman
Quoted 8 lines · Johannes Thumshirn

Hi,

I got notified about your patch to support multiple MSI Vectors on Freescale PowerPC platforms. Is there any reason why it wasn't applied until now? I couldn't find anything about it in the list archives.

I think it would be a real benefit for all to have multiple MSI vecotrs on PowerPCs.

Why would you not use MSI-X ?

Simply because our hardware only supports MSI.

#6 lore raw
In reply to Michael Ellerman
Quoted 7 lines · Michael Ellerman
Quoted 6 lines · Johannes Thumshirn

Hi,

I got notified about your patch to support multiple MSI Vectors on Freescale PowerPC platforms. Is there any reason why it wasn't applied until now? I couldn't find anything about it in the list archives.

Quoted 8 lines
Quoted 2 lines

I think it would be a real benefit for all to have multiple MSI vecotrs on PowerPCs.

Why would you not use MSI-X ?

cheers

Does anyone (especially the original author) have any objections if I re-spin the patch series?

#7 lore raw
Quoted 2 lines · Johannes Thumshirn
Quoted 1 line · Michael Ellerman

Why would you not use MSI-X ?

If I'm not mistaken, a PCI-E requirement is to support MSI but MSI-X is optional. And with MSI you can have multiple interrupts per single device (power of two, max 32).
Now imagine you have a FPGA with two (or more) different devices in it and you don't want them to share the IRQ line (for $reason). I bet the HW developer sees MSI and MSI-X and the former is for some reason cheaper compared to MSI-X and it fits the needs. So…

Quoted 3 lines

Does anyone (especially the original author) have any objections if I re-spin the patch series?

I didn't get around to address the review comments so it did not went in and there was no v2. Feel free re-do the series.

Sebastian