Skip to contentSkip to conversation

kbuild: drop clang-specific extra warnings

PATCH New Masahiro Yamada 2 participants 2 messages Oct 30, 2014 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kbuild: drop clang-specific extra warnings

It is true clang has more warnings enabled by default but Jeroen Hofstee are making lots of efforts to eliminate warnings. Let's drop clang-related checks and continue to fix C code.

---

 scripts/Makefile.extrawarn | 10 ----------
 1 file changed, 10 deletions(-)
scripts/Makefile.extrawarn +0 -10
index 6564350..0ec0d24 100644
@@ -26,16 +26,6 @@ warning-1 += $(call cc-option, -Wmissing-include-dirs)
 warning-1 += $(call cc-option, -Wunused-but-set-variable)
 warning-1 += $(call cc-disable-warning, missing-field-initializers)
 
-# Clang
-warning-1 += $(call cc-disable-warning, initializer-overrides)
-warning-1 += $(call cc-disable-warning, unused-value)
-warning-1 += $(call cc-disable-warning, format)
-warning-1 += $(call cc-disable-warning, unknown-warning-option)
-warning-1 += $(call cc-disable-warning, sign-compare)
-warning-1 += $(call cc-disable-warning, format-zero-length)
-warning-1 += $(call cc-disable-warning, uninitialized)
-warning-1 += $(call cc-option, -fcatch-undefined-behavior)
-
 warning-2 := -Waggregate-return
 warning-2 += -Wcast-align
 warning-2 += -Wdisabled-optimization
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 kbuild: drop clang-specific extra warnings

Hello Masahiro,

Quoted 7 lines · Masahiro Yamada

It is true clang has more warnings enabled by default but Jeroen Hofstee are making lots of efforts to eliminate warnings. Let's drop clang-related checks and continue to fix C code.

---

Can you clarify the commit summary and message a bit? "Drop clang warnings" might be read as "don't care about them"; "stop hiding clang warnings during build" will avoid this misreading.

Amicalement,

Signature · 1 line
Albert.