Update Auvitek au0828 quirks

PATCH In review Mauro Carvalho Chehab 3 participants 8 messages Oct 30, 2014

Subsystems (2)

Media (V4L/DVB) Sound

lore

Share & tools

lore

Mauro Carvalho Chehab

author

2014-10-30 11:29 UTC #0 lore raw

v2 cover Update Auvitek au0828 quirks

There are several Auvitek au0828 listed at sound quirks. However, the table there is incomplete. Simplify the table using a macro for au0828 devices and update it to reflect the devices currently

v2: Fix SOB, au0828 driver reference and add a warning at au0828-cards.c.

Mauro Carvalho Chehab (2):
[media] sound: simplify au0828 quirk table
[media] sound: Update au0828 quirks table

 drivers/media/usb/au0828/au0828-cards.c |   5 +
 sound/usb/quirks-table.h                | 166 ++++++++------------------------
 2 files changed, 44 insertions(+), 127 deletions(-)

Signature · 1 line

1.9.3

Mauro Carvalho Chehab

author

2014-10-30 11:28 UTC #1 lore raw

PATCH v2 1/2 sound: simplify au0828 quirk table

Add a macro to simplify au0828 quirk table. That makes easier to check it against the USB IDs at drivers/media/usb/au0828/au0828-cards.c.

Cc [email protected]

Signed-off-by Mauro Carvalho Chehab <[email protected]>

drivers/media/usb/au0828/au0828-cards.c +5 -0

index 9eb77ac2153b..da87f1cc31a9 100644
@@ -36,6 +36,11 @@ static void hvr950q_cs5340_audio(void *priv, int enable)
 		au0828_clear(dev, REG_000, 0x10);
 }
 
+/*
+ * WARNING: There's a quirks table at sound/usb/quirks-table.h
+ * that should also be updated every time a new device with V4L2 support
+ * is added here.
+ */
 struct au0828_board au0828_boards[] = {
 	[AU0828_BOARD_UNKNOWN] = {
 		.name	= "Unknown board",

sound/usb/quirks-table.h +31 ~~-127~~

164 lines not on this page · raw message

Signature · 1 line

1.9.3

Mauro Carvalho Chehab

author

2014-10-30 11:28 UTC #2 lore raw

PATCH v2 2/2 sound: Update au0828 quirks table

In reply to Mauro Carvalho Chehab

The au0828 quirks table is currently not in sync with the au0828 media driver.

Syncronize it and put them on the same order as found at au0828 driver, as all the au0828 devices with analog TV need the same quirks.

Cc [email protected]

Signed-off-by Mauro Carvalho Chehab <[email protected]>

sound/usb/quirks-table.h +9 -1

index 8f3e2bf100eb..83bddbdb90e9 100644
@@ -2827,14 +2827,22 @@ YAMAHA_DEVICE(0x7010, "UB99"),
 }
 
 AU0828_DEVICE(0x2040, 0x7200, "Hauppauge", "HVR-950Q"),
+AU0828_DEVICE(0x2040, 0x7240, "Hauppauge", "HVR-850"),
 AU0828_DEVICE(0x2040, 0x7210, "Hauppauge", "HVR-950Q"),
 AU0828_DEVICE(0x2040, 0x7217, "Hauppauge", "HVR-950Q"),
 AU0828_DEVICE(0x2040, 0x721b, "Hauppauge", "HVR-950Q"),
 AU0828_DEVICE(0x2040, 0x721e, "Hauppauge", "HVR-950Q"),
 AU0828_DEVICE(0x2040, 0x721f, "Hauppauge", "HVR-950Q"),
-AU0828_DEVICE(0x2040, 0x7240, "Hauppauge", "HVR-850"),
 AU0828_DEVICE(0x2040, 0x7280, "Hauppauge", "HVR-950Q"),
 AU0828_DEVICE(0x0fd9, 0x0008, "Hauppauge", "HVR-950Q"),
+AU0828_DEVICE(0x2040, 0x7201, "Hauppauge", "HVR-950Q-MXL"),
+AU0828_DEVICE(0x2040, 0x7211, "Hauppauge", "HVR-950Q-MXL"),
+AU0828_DEVICE(0x2040, 0x7281, "Hauppauge", "HVR-950Q-MXL"),
+AU0828_DEVICE(0x05e1, 0x0480, "Hauppauge", "Woodbury"),
+AU0828_DEVICE(0x2040, 0x8200, "Hauppauge", "Woodbury"),
+AU0828_DEVICE(0x2040, 0x7260, "Hauppauge", "HVR-950Q"),
+AU0828_DEVICE(0x2040, 0x7213, "Hauppauge", "HVR-950Q"),
+AU0828_DEVICE(0x2040, 0x7270, "Hauppauge", "HVR-950Q"),
 
 /* Digidesign Mbox */
 {

Signature · 1 line

1.9.3

Devin Heitmueller

2014-10-30 13:15 UTC #3 lore raw

Re: [PATCH v2 2/2] [media] sound: Update au0828 quirks table

Hi Mauro,

Quoted 3 lines

Syncronize it and put them on the same order as found at au0828 driver, as all the au0828 devices with analog TV need the same quirks.

The MXL and Woodbury boards don't support analog under Linux, so probably shouldn't be included in the list of quirks.

That said, the MXL and Woodbury versions of the PCBs were prototypes that never made it into production (and since the Auvitek chips are EOL, they never will). I wouldn't object to a patch which removed the board profiles entirely in the interest of removing dead code.

It was certainly nice of Mike Krufky to work to get support into the open source driver before the product was released, but after four years it probably makes sense to remove the entries for products that never actually shipped.

Devin

Signature · 2 lines

Devin J. Heitmueller - Kernel Labs
http://www.kernellabs.com

Mauro Carvalho Chehab

author

2014-10-30 13:37 UTC #4 lore raw

Re: [PATCH v2 2/2] [media] sound: Update au0828 quirks table

Hi Devin,

Em Thu, 30 Oct 2014 09:15:31 -0400
Devin Heitmueller <[email protected]> escreveu:

Quoted 8 lines

Hi Mauro,
Quoted 3 lines
Syncronize it and put them on the same order as found at au0828 driver, as all the au0828 devices with analog TV need the same quirks.
The MXL and Woodbury boards don't support analog under Linux, so probably shouldn't be included in the list of quirks.

True.

Quoted 10 lines

That said, the MXL and Woodbury versions of the PCBs were prototypes that never made it into production (and since the Auvitek chips are EOL, they never will). I wouldn't object to a patch which removed the board profiles entirely in the interest of removing dead code.
It was certainly nice of Mike Krufky to work to get support into the open source driver before the product was released, but after four years it probably makes sense to remove the entries for products that never actually shipped.

Yeah, if nobody is using such devices, then we should get rid of them, but I prefer to have this on a separate patch, in order to give people the opportunity to complain.

So, if I'm understanding well, you're suggesting to add a patch removing those 5 entries (and the corresponding quirks on alsa), right?

	{ USB_DEVICE(0x2040, 0x7201),
		.driver_info = AU0828_BOARD_HAUPPAUGE_HVR950Q_MXL },
	{ USB_DEVICE(0x2040, 0x7211),
		.driver_info = AU0828_BOARD_HAUPPAUGE_HVR950Q_MXL },
	{ USB_DEVICE(0x2040, 0x7281),
		.driver_info = AU0828_BOARD_HAUPPAUGE_HVR950Q_MXL },
	{ USB_DEVICE(0x05e1, 0x0480),
		.driver_info = AU0828_BOARD_HAUPPAUGE_WOODBURY },
	{ USB_DEVICE(0x2040, 0x8200),
		.driver_info = AU0828_BOARD_HAUPPAUGE_WOODBURY },
	{ USB_DEVICE(0x2040, 0x7260),

Regards,
Mauro

Devin Heitmueller

2014-10-30 14:13 UTC #5 lore raw

Re: [PATCH v2 2/2] [media] sound: Update au0828 quirks table

Quoted 3 lines · Mauro Carvalho Chehab

Yeah, if nobody is using such devices, then we should get rid of them, but I prefer to have this on a separate patch, in order to give people the opportunity to complain.

Yes, I would definitely suggest a separate patch. There's no reason it should be mixed in with your general cleanup of the ALSA quirks.

Quoted 4 lines

So, if I'm understanding well, you're suggesting to add a patch removing those 5 entries (and the corresponding quirks on alsa), right?

Quoted 11 lines

        { USB_DEVICE(0x2040, 0x7201),
                .driver_info = AU0828_BOARD_HAUPPAUGE_HVR950Q_MXL },
        { USB_DEVICE(0x2040, 0x7211),
                .driver_info = AU0828_BOARD_HAUPPAUGE_HVR950Q_MXL },
        { USB_DEVICE(0x2040, 0x7281),
                .driver_info = AU0828_BOARD_HAUPPAUGE_HVR950Q_MXL },
        { USB_DEVICE(0x05e1, 0x0480),
                .driver_info = AU0828_BOARD_HAUPPAUGE_WOODBURY },
        { USB_DEVICE(0x2040, 0x8200),
                .driver_info = AU0828_BOARD_HAUPPAUGE_WOODBURY },
        { USB_DEVICE(0x2040, 0x7260),

Exactly.

Devin

Signature · 2 lines

Devin J. Heitmueller - Kernel Labs
http://www.kernellabs.com

Michael Ira Krufky

2014-10-30 19:52 UTC #6 lore raw

Re: [PATCH v2 2/2] [media] sound: Update au0828 quirks table

In reply to Mauro Carvalho Chehab

Quoted 46 lines · Mauro Carvalho Chehab

Hi Devin,
Em Thu, 30 Oct 2014 09:15:31 -0400
Devin Heitmueller <[email protected]> escreveu:
Quoted 8 lines
Hi Mauro,
Quoted 3 lines
Syncronize it and put them on the same order as found at au0828 driver, as all the au0828 devices with analog TV need the same quirks.
The MXL and Woodbury boards don't support analog under Linux, so probably shouldn't be included in the list of quirks.
True.
Quoted 10 lines
That said, the MXL and Woodbury versions of the PCBs were prototypes that never made it into production (and since the Auvitek chips are EOL, they never will). I wouldn't object to a patch which removed the board profiles entirely in the interest of removing dead code.
It was certainly nice of Mike Krufky to work to get support into the open source driver before the product was released, but after four years it probably makes sense to remove the entries for products that never actually shipped.
Yeah, if nobody is using such devices, then we should get rid of them, but I prefer to have this on a separate patch, in order to give people the opportunity to complain.
So, if I'm understanding well, you're suggesting to add a patch removing those 5 entries (and the corresponding quirks on alsa), right?
        { USB_DEVICE(0x2040, 0x7201),
                .driver_info = AU0828_BOARD_HAUPPAUGE_HVR950Q_MXL },
        { USB_DEVICE(0x2040, 0x7211),
                .driver_info = AU0828_BOARD_HAUPPAUGE_HVR950Q_MXL },
        { USB_DEVICE(0x2040, 0x7281),
                .driver_info = AU0828_BOARD_HAUPPAUGE_HVR950Q_MXL },
        { USB_DEVICE(0x05e1, 0x0480),
                .driver_info = AU0828_BOARD_HAUPPAUGE_WOODBURY },
        { USB_DEVICE(0x2040, 0x8200),
                .driver_info = AU0828_BOARD_HAUPPAUGE_WOODBURY },
        { USB_DEVICE(0x2040, 0x7260),

Quoted 6 lines

Regards,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Let's *not* remove DTV support for WOODBURY board -- it is not the business of the public whether or not the board shipped in mass-production. The board profile is in fact being used for some reference designs, and I still use my woodbury prototype to test the MXL tuner.

I am not the only person using this profile -- no not remove it, please.

Michael Ira Krufky

2014-10-30 19:55 UTC #7 lore raw

Re: [PATCH v2 2/2] [media] sound: Update au0828 quirks table

Quoted 56 lines · Michael Ira Krufky

Quoted 46 lines · Mauro Carvalho Chehab
Hi Devin,
Em Thu, 30 Oct 2014 09:15:31 -0400
Devin Heitmueller <[email protected]> escreveu:
Quoted 8 lines
Hi Mauro,
Quoted 3 lines
Syncronize it and put them on the same order as found at au0828 driver, as all the au0828 devices with analog TV need the same quirks.
The MXL and Woodbury boards don't support analog under Linux, so probably shouldn't be included in the list of quirks.
True.
Quoted 10 lines
That said, the MXL and Woodbury versions of the PCBs were prototypes that never made it into production (and since the Auvitek chips are EOL, they never will). I wouldn't object to a patch which removed the board profiles entirely in the interest of removing dead code.
It was certainly nice of Mike Krufky to work to get support into the open source driver before the product was released, but after four years it probably makes sense to remove the entries for products that never actually shipped.
Yeah, if nobody is using such devices, then we should get rid of them, but I prefer to have this on a separate patch, in order to give people the opportunity to complain.
So, if I'm understanding well, you're suggesting to add a patch removing those 5 entries (and the corresponding quirks on alsa), right?
        { USB_DEVICE(0x2040, 0x7201),
                .driver_info = AU0828_BOARD_HAUPPAUGE_HVR950Q_MXL },
        { USB_DEVICE(0x2040, 0x7211),
                .driver_info = AU0828_BOARD_HAUPPAUGE_HVR950Q_MXL },
        { USB_DEVICE(0x2040, 0x7281),
                .driver_info = AU0828_BOARD_HAUPPAUGE_HVR950Q_MXL },
        { USB_DEVICE(0x05e1, 0x0480),
                .driver_info = AU0828_BOARD_HAUPPAUGE_WOODBURY },
        { USB_DEVICE(0x2040, 0x8200),
                .driver_info = AU0828_BOARD_HAUPPAUGE_WOODBURY },
        { USB_DEVICE(0x2040, 0x7260),
Quoted 6 lines
Regards,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Quoted 7 lines

Let's *not* remove DTV support for WOODBURY board -- it is not the business of the public whether or not the board shipped in mass-production. The board profile is in fact being used for some reference designs, and I still use my woodbury prototype to test the MXL tuner.
I am not the only person using this profile -- no not remove it, please.

correction: I still use both the woodbury prototype (to test the reference design) *and* the MXL version for testing the mxl tuner.

There is no reason to remove these profiles, the USB IDs will not be recycled