Skip to contentSkip to conversation

arm: fix a typo of instruction operand

PATCH New Jethro Hsu 2 participants 2 messages Oct 30, 2014

lore
Share & tools
lore

Jethro Hsu

author
#0 lore raw

PATCH 1/1 arm: fix a typo of instruction operand

#1 lore raw

PATCH 1/1 arm: fix a typo of instruction operand

Hello Jethro,

Quoted 39 lines · Jethro Hsu

From 79344f479bad75b47477dcc9768e564e02f72f59 Mon Sep 17 00:00:00 2001
From: Jethro Hsu <[email protected]>
Date: Thu, 30 Oct 2014 17:26:00 +0800
Subject: [PATCH] arm: fix a typo of instruction operand

To fix compile error caused by incorrect data format, add "0x" to specify the operand value in hex mode.

error message:

arch/arm/lib/gic_64.S: Assembler messages:
arch/arm/lib/gic_64.S:187: Error: unexpected characters following instruction at operand 3 -- `and w9,w9,#3ff'

Change-Id Ifef22c6d9a0f6a4255b3f2daf96bef08db6731dc
Cc Albert Aribaud <[email protected]>
Cc Arnab Basu <[email protected]>
Cc David Feng <[email protected]>
Cc York Sun <[email protected]>
Cc Scott Wood <[email protected]>
---
 arch/arm/include/asm/macro.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/include/asm/macro.h +1 -2
index 541b443..1c8c425 100644
@@ -193,7 +193,7 @@ lr  .req    x30
 0 :    wfi
        ldr     \wreg2, [\xreg1, GICC_AIAR]
        str     \wreg2, [\xreg1, GICC_AEOIR]
-       and     \wreg2, \wreg2, #3ff
+       and     \wreg2, \wreg2, #0x3ff
        cbnz    \wreg2, 0b
 .endm
 #endif
--
Quoted 1 line

1.8.3.1

This was fixed already in u-boot-arm/master (currently top of tree, soon to merge into u-boot/master.

Amicalement,

Signature · 1 line
Albert.