Skip to contentSkip to conversation

shairport-sync: needs toolchain with NPTL

PATCH New Baruch Siach 3 participants 3 messages Oct 29, 2014 – Oct 30, 2014

lore
Share & tools
lore

Baruch Siach

author
#0 lore raw

PATCH 1/1 shairport-sync: needs toolchain with NPTL

Also remove the comment attributing threads dependency to alsa-lib, since shairport-sync itself uses pthreads.

Fixes:
http://autobuild.buildroot.net/results/58e/58eafd2499919a45bfb5a2becc233d3678deedde/

Signed-off-by Baruch Siach <[email protected]>
---
 package/shairport-sync/Config.in | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
package/shairport-sync/Config.in +3 -3
index ce3106186fb3..c1d81a7e2a54 100644
@@ -1,7 +1,7 @@
 config BR2_PACKAGE_SHAIRPORT_SYNC
 	bool "shairport-sync"
 	depends on BR2_USE_MMU # libdaemon
-	depends on BR2_TOOLCHAIN_HAS_THREADS # alsa_lib
+	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
 	select BR2_PACKAGE_ALSA_LIB
 	select BR2_PACKAGE_ALSA_LIB_MIXER
 	select BR2_PACKAGE_LIBDAEMON

@@ -33,6 +33,6 @@ config BR2_PACKAGE_SHAIRPORT_SYNC_LIBSOXR
 
 endif
 
-comment "shairport-sync needs a toolchain w/ threads"
+comment "shairport-sync needs a toolchain w/ NPTL"
 	depends on BR2_USE_MMU
-	depends on !BR2_TOOLCHAIN_HAS_THREADS
+	depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL
Signature · 1 line
2.1.1
#1 lore raw

PATCH 1/1 shairport-sync: needs toolchain with NPTL

Quoted 7 lines · Baruch Siach

Also remove the comment attributing threads dependency to alsa-lib, since shairport-sync itself uses pthreads.

Fixes:
http://autobuild.buildroot.net/results/58e/58eafd2499919a45bfb5a2becc233d3678deedde/

Signed-off-by Baruch Siach <[email protected]>
Reviewed-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>

Regards,
Arnout

Quoted 27 lines
---
 package/shairport-sync/Config.in | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
package/shairport-sync/Config.in +3 -3
index ce3106186fb3..c1d81a7e2a54 100644
@@ -1,7 +1,7 @@
 config BR2_PACKAGE_SHAIRPORT_SYNC
 	bool "shairport-sync"
 	depends on BR2_USE_MMU # libdaemon
-	depends on BR2_TOOLCHAIN_HAS_THREADS # alsa_lib
+	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
 	select BR2_PACKAGE_ALSA_LIB
 	select BR2_PACKAGE_ALSA_LIB_MIXER
 	select BR2_PACKAGE_LIBDAEMON

@@ -33,6 +33,6 @@ config BR2_PACKAGE_SHAIRPORT_SYNC_LIBSOXR
 
 endif
 
-comment "shairport-sync needs a toolchain w/ threads"
+comment "shairport-sync needs a toolchain w/ NPTL"
 	depends on BR2_USE_MMU
-	depends on !BR2_TOOLCHAIN_HAS_THREADS
+	depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
Applied
#2 lore raw

PATCH 1/1 shairport-sync: needs toolchain with NPTL

In reply to Baruch Siach

Dear Baruch Siach,

Quoted 10 lines · Baruch Siach

Also remove the comment attributing threads dependency to alsa-lib, since shairport-sync itself uses pthreads.

Fixes:
http://autobuild.buildroot.net/results/58e/58eafd2499919a45bfb5a2becc233d3678deedde/

Signed-off-by Baruch Siach <[email protected]>
---
 package/shairport-sync/Config.in | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Applied, thanks. And thanks to Arnout for the review.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com