package/dovecot: New package

---
v6: no changes
v5: bumped to 2.2.15
v4: bumped to 2.2.14
v3: DOVECOT_CONF_OPT -> DOVECOT_CONF_OPTS
v2: - Reworked dependencies (Thomas)
- added MySQL/SQLite support
- removed cruft from CONV_OPT not needed for buildroot (Thomas)

---
 package/Config.in          |    1 +
 package/dovecot/Config.in  |   56 +++++++++++++++++++++++++
 package/dovecot/dovecot.mk |   97 ++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 154 insertions(+)
 create mode 100644 package/dovecot/Config.in
 create mode 100644 package/dovecot/dovecot.mk

index 321aa1c..aec3c14 100644
@@ -955,6 +955,7 @@ menu "Miscellaneous"
 endmenu
 
 menu "Mail"
+	source "package/dovecot/Config.in"
 	source "package/exim/Config.in"
 	source "package/fetchmail/Config.in"
 	source "package/heirloom-mailx/Config.in"

1.7.10.4

---
v6: bump version to 0.4.4
v5: no changes
v4: no changes
v3: DOVECOT_PIGEONHOLE_CONF_OPT -> DOVECOT_PIGEONHOLE_CONF_OPTS
v2: - package moved to new Dovecot dependency submenu
- removed cruft from CONV_OPT not needed for buildroot (Thomas)

---
 package/dovecot-pigeonhole/Config.in             |    8 ++++++++
 package/dovecot-pigeonhole/dovecot-pigeonhole.mk |   16 ++++++++++++++++
 package/dovecot/Config.in                        |    2 ++
 3 files changed, 26 insertions(+)
 create mode 100644 package/dovecot-pigeonhole/Config.in
 create mode 100644 package/dovecot-pigeonhole/dovecot-pigeonhole.mk

new file mode 100644
index 0000000..83f5287
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_DOVECOT_PIGEONHOLE
+	bool "dovecot-pigeonhole"
+	help
+	  Pigeonhole is the name of the project that adds support for the Sieve
+	  language (RFC 5228) and the ManageSieve protocol (RFC 5804) to the
+	  Dovecot Secure IMAP Server.
+
+	  http://pigeonhole.dovecot.org

new file mode 100644
index 0000000..15f421c
@@ -0,0 +1,16 @@
+################################################################################
+#
+# dovecot-pigeonhole
+#
+################################################################################
+
+DOVECOT_PIGEONHOLE_VERSION = 0.4.4
+DOVECOT_PIGEONHOLE_SOURCE = dovecot-2.2-pigeonhole-$(DOVECOT_PIGEONHOLE_VERSION).tar.gz
+DOVECOT_PIGEONHOLE_SITE = http://pigeonhole.dovecot.org/releases/2.2
+DOVECOT_PIGEONHOLE_LICENSE = LGPLv2.1
+DOVECOT_PIGEONHOLE_LICENSE_FILES = COPYING
+DOVECOT_PIGEONHOLE_DEPENDENCIES = dovecot
+
+DOVECOT_PIGEONHOLE_CONF_OPTS = --with-dovecot=$(STAGING_DIR)/usr/lib
+
+$(eval $(autotools-package))

index c692402..9c0ecc8 100644
@@ -49,6 +49,8 @@ config BR2_PACKAGE_DOVECOT_ZLIB
 	help
 	  Enable zlib support.
 
+source package/dovecot-pigeonhole/Config.in
+
 endif # BR2_PACKAGE_DOVECOT
 
 comment "dovecot needs a toolchain w/ ipv6"

1.7.10.4

Dear Bernd Kuhls,

Applied, thanks.

Thomas

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

---
v6: no changes
v5: no changes
v4: Initial version

---
 package/exim/exim.mk |    8 ++++++++
 1 file changed, 8 insertions(+)

index 9ae94c3..43f1a6b 100644
@@ -55,6 +55,13 @@ define EXIM_USE_DEFAULT_CONFIG_FILE_CLAMAV
 endef
 endif
 
+ifeq ($(BR2_PACKAGE_DOVECOT),y)
+EXIM_DEPENDENCIES += dovecot
+define EXIM_USE_DEFAULT_CONFIG_FILE_DOVECOT
+	$(call exim-config-change,AUTH_DOVECOT,yes)
+endef
+endif
+
 define EXIM_CONFIGURE_TOOLCHAIN
 	$(call exim-config-add,CC,$(TARGET_CC))
 	$(call exim-config-add,CFLAGS,$(TARGET_CFLAGS))

@@ -73,6 +80,7 @@ else # CUSTOM_CONFIG
 define EXIM_CONFIGURE_CMDS
 	$(EXIM_USE_DEFAULT_CONFIG_FILE)
 	$(EXIM_USE_DEFAULT_CONFIG_FILE_CLAMAV)
+	$(EXIM_USE_DEFAULT_CONFIG_FILE_DOVECOT)
 	$(EXIM_CONFIGURE_TOOLCHAIN)
 endef
 endif # CUSTOM_CONFIG

1.7.10.4

Dear Bernd Kuhls,

Applied, thanks. However, there was an issue with your three patches:
your SoB line was after the "---" sign, so it was stripped by git when applying your patches. I restored it for the exim patch, but forgot for the two previous patches.

Also, your exim patch was based on top of your ClamAV patches, so it didn't apply cleanly. In such cases, please send your patches as part of a patch series that include all patches, or make sure they are properly based on master.

Thanks a lot!

Thomas

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Dear Bernd Kuhls,

Applied, thanks. I've done a few changes though:

[Thomas:
- slightly adjust the prompt of options in the Config.in file
- fix license: it's just LGPLv2.1, no exceptions. Parts of the code are under public domain, or under the MIT license, but the combination is under LGPLv2.1.
- rewrap one comment in the .mk file.]

Also, could you:

* Send a patch to add an init script, if applicable? Since dovecot is a POP3/IMAP server, it would make sense to have an init script available for it, so that it works "out of the box" in at least a default way for users.

* Check if iconv is needed or not when the toolchain doesn't have locale support? You have $(if $(BR2_PACKAGE_LIBICONV),iconv) in DEPENDENCIES. But the iconv package is not selected.

Thanks!

Thomas

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com