Skip to contentSkip to conversation

Linux 3.2.63-rt93-rc1

PATCH New Steven Rostedt 1 participant 3 messages Oct 31, 2014

lore
Share & tools
lore
#0 lore raw

cover Linux 3.2.63-rt93-rc1

Dear RT Folks,

This is the RT stable review cycle of patch 3.2.63-rt93-rc1.

Please scream at me if I messed something up. Please test the patches too.

The -rc release will be uploaded to kernel.org and will be deleted when the final release is out. This is just a review release (or release candidate).

The pre-releases will not be pushed to the git repository, only the final release is.

If all goes well, this patch will be converted to the next main release on 11/3/2014.

Enjoy,

-- Steve

To build 3.2.63-rt93-rc1 directly, the following patches should be applied:

http://www.kernel.org/pub/linux/kernel/v3.x/linux-3.2.tar.xz

http://www.kernel.org/pub/linux/kernel/v3.x/patch-3.2.63.xz

http://www.kernel.org/pub/linux/kernel/projects/rt/3.2/patch-3.2.63-rt93-rc1.patch.xz

You can also build from 3.2.63-rt92 by applying the incremental patch:

http://www.kernel.org/pub/linux/kernel/projects/rt/3.2/incr/patch-3.2.63-rt92-rt93-rc1.patch.xz

Changes from 3.2.63-rt92:

---

Steven Rostedt (Red Hat) (2):
lockdep: Fix backport of "Correctly annotate hardirq context in irq_exit()" Linux 3.2.63-rt93-rc1

----

 kernel/softirq.c | 5 +++--
 localversion-rt  | 2 +-
 2 files changed, 4 insertions(+), 3 deletions(-)
#1 lore raw

PATCH 1/2 lockdep: Fix backport of "Correctly annotate hardirq context in irq_exit()"

3.2.63-rt93-rc1 stable review patch.
If anyone has any objections, please let me know.

------------------

From: "Steven Rostedt (Red Hat)" <[email protected]>

The backport of f1a83e652bed "lockdep: Correctly annotate hardirq context in irq_exit()" to v3.2.53-rt76 wasn't correct because v3.2-rt had two calls to invoke_softirq(). One when __ARCH_IRQ_EXIT_IRQS_DISABLED is defined and another when it is not defined. v3.14 which introduced this change only had one version.

When I backported this change, I didn't see the two places and only one was added. Unfortunately, it was the one that x86 does not use, and this caused a lockdep splat on one of my tests. It only affected the -rt patch when PREEMPT_RT_FULL was not set, so I did not spend much time looking to see what broke.

Well, I finally spent a little time and found the cause, and this was a simple fix. Now my all my tests pass on the v3.2-rt kernel, even the one where I test CONFIG_PREEMPT_RT_FULL not set.

---
 kernel/softirq.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
kernel/softirq.c +3 -2
index 7d882ccfa22b..56d30853345d 100644
@@ -637,9 +637,10 @@ static inline void invoke_softirq(void)
 static inline void invoke_softirq(void)
 {
 #ifndef CONFIG_PREEMPT_RT_FULL
-	if (!force_irqthreads)
+	if (!force_irqthreads) {
+		lockdep_softirq_from_hardirq();
 		do_softirq();
-	else {
+	} else {
 		__local_bh_disable((unsigned long)__builtin_return_address(0),
 				SOFTIRQ_OFFSET);
 		wakeup_softirqd();
Signature · 1 line
2.1.1
#2 lore raw

PATCH 2/2 Linux 3.2.63-rt93-rc1

In reply to Steven Rostedt

3.2.63-rt93-rc1 stable review patch.
If anyone has any objections, please let me know.

------------------

From: "Steven Rostedt (Red Hat)" <[email protected]>

---
 localversion-rt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
localversion-rt +1 -1
index 4905d52a4828..4821d0e04d28 100644
@@ -1 +1 @@
--rt92
+-rt93-rc1
Signature · 1 line
2.1.1