Skip to contentSkip to conversation

package/tinyxml: fix the upstream URL

PATCH New Romain Naour 3 participants 3 messages Nov 1, 2014 – Nov 3, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/tinyxml: fix the upstream URL

---
 package/tinyxml/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/tinyxml/Config.in +1 -1
index 061ff67..466e391 100644
@@ -5,7 +5,7 @@ config BR2_PACKAGE_TINYXML
 	  TinyXML is a simple, small, C++ XML parser that can be
 	  easily integrating into other programs.
 
-	  https://github.com/leethomason/tinyxml2
+	  http://sourceforge.net/projects/tinyxml
 
 comment "tinyxml needs a toolchain w/ C++"
 	depends on !BR2_INSTALL_LIBSTDCPP
Signature · 1 line
1.9.3
#1 lore raw

PATCH 1/1 package/tinyxml: fix the upstream URL

Romain, All,

On 2014-11-01 19:08 +0100, Romain Naour spake thusly:

Quoted 10 lines
---
 package/tinyxml/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/tinyxml/Config.in +0 -0
index 061ff67..466e391 100644

package/tinyxml/Config.in config BR2_PACKAGE_TINYXML · line 8

Quoted 5 lines
package/tinyxml/Config.in +1 -1
@@ -5,7 +5,7 @@ config BR2_PACKAGE_TINYXML
 	  TinyXML is a simple, small, C++ XML parser that can be
 	  easily integrating into other programs.
 
-	  https://github.com/leethomason/tinyxml2
+	  http://sourceforge.net/projects/tinyxml

Well, I'm not even sure we are using that TinyXML.

In fact, we get it from an XMBC mirror:
TINYXML_SITE = http://mirrors.xbmc.org/build-deps/sources

The content of the tinyxml-2.6.2_2.tar.gz archive is not even remotely similar to the content of the repository on the sourceforge webpage; at least, it has been hugely re-organised, and patched. It also has autotools files, which is good, though.

So, NAK on this, until we have a clear explanations on what's going on.

Maxime, why do we need this specially patched tinyxml from the XBMC mirror, instead of the one from upstream?

Regards,
Yann E. MORIN.

Quoted 9 lines
package/tinyxml/Config.in +0 -0
 comment "tinyxml needs a toolchain w/ C++"
 	depends on !BR2_INSTALL_LIBSTDCPP
Signature · 6 lines
1.9.3

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH 1/1 package/tinyxml: fix the upstream URL

Hi Yann, Romain, all

Quoted 29 lines · Yann E. MORIN

Romain, All,

On 2014-11-01 19:08 +0100, Romain Naour spake thusly:

Quoted 10 lines
---
 package/tinyxml/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/tinyxml/Config.in +0 -0
index 061ff67..466e391 100644

package/tinyxml/Config.in config BR2_PACKAGE_TINYXML · line 8

Quoted 5 lines
package/tinyxml/Config.in +1 -1
@@ -5,7 +5,7 @@ config BR2_PACKAGE_TINYXML
        TinyXML is a simple, small, C++ XML parser that can be
        easily integrating into other programs.
 
-       https://github.com/leethomason/tinyxml2
+       http://sourceforge.net/projects/tinyxml

Well, I'm not even sure we are using that TinyXML.

In fact, we get it from an XMBC mirror:
TINYXML_SITE = http://mirrors.xbmc.org/build-deps/sources

The content of the tinyxml-2.6.2_2.tar.gz archive is not even remotely similar to the content of the repository on the sourceforge webpage; at least, it has been hugely re-organised, and patched. It also has autotools files, which is good, though.

Quoted 4 lines

So, NAK on this, until we have a clear explanations on what's going on.

Maxime, why do we need this specially patched tinyxml from the XBMC mirror, instead of the one from upstream?

So, the XBMC folks have organised the source (created a src, include, tests folder and put relevant files in each), added autotools suports, a tinyxml.pc.in and reworked the Visual Studio project file (for building XBMC for Windows I assume).
The main tweaks is that they have forced the STL support through a modification in tinyxml.h
I think a full rework of this package should be in order, I'll cookup a patch reworking it fully to uses the source from sourceforge, making sure it doesn't break XBMC.

Quoted 21 lines

Regards,
Yann E. MORIN.

Quoted 9 lines
package/tinyxml/Config.in +0 -1
 comment "tinyxml needs a toolchain w/ C++"
      depends on !BR2_INSTALL_LIBSTDCPP
--

1.9.3

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

--
.-----------------.--------------------.------------------.--------------------.

|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |

'------------------------------^-------^------------------^--------------------'