Skip to contentSkip to conversation

mfd: twl4030-power: Fix regression with missing compatible flag

PATCH Applied Tony Lindgren 2 participants 2 messages Nov 2, 2014 – Nov 3, 2014

Subsystems (2)
lore
Share & tools
lore

Tony Lindgren

author maintainer
#0 lore raw

PATCH 1/1 mfd: twl4030-power: Fix regression with missing compatible flag

Commit e7cd1d1eb16f ("mfd: twl4030-power: Add generic reset configuration") accidentally removed the compatible flag for "ti,twl4030-power" that should be there as documented in the binding.

If "ti,twl4030-power" only the poweroff configuration is done by the driver.

Fixes e7cd1d1eb16f ("mfd: twl4030-power: Add generic reset configuration")
Cc [email protected] # v3.16+
drivers/mfd/twl4030-power.c +3 -0
@@ -831,6 +831,9 @@ static struct twl4030_power_data osc_off_idle = {
 
 static struct of_device_id twl4030_power_of_match[] = {
 	{
+		.compatible = "ti,twl4030-power",
+	},
+	{
 		.compatible = "ti,twl4030-power-reset",
 		.data = &omap3_reset,
 	},
Applied
#1 lore raw
Quoted 5 lines · Tony Lindgren

Commit e7cd1d1eb16f ("mfd: twl4030-power: Add generic reset configuration") accidentally removed the compatible flag for "ti,twl4030-power" that should be there as documented in the binding.

Quoted 7 lines

If "ti,twl4030-power" only the poweroff configuration is done by the driver.

Fixes e7cd1d1eb16f ("mfd: twl4030-power: Add generic reset configuration")
Cc [email protected] # v3.16+

Applied, thanks.

Quoted 12 lines
drivers/mfd/twl4030-power.c +3 -0
@@ -831,6 +831,9 @@ static struct twl4030_power_data osc_off_idle = {
 
 static struct of_device_id twl4030_power_of_match[] = {
 	{
+		.compatible = "ti,twl4030-power",
+	},
+	{
 		.compatible = "ti,twl4030-power-reset",
 		.data = &omap3_reset,
 	},
Signature · 4 lines
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog