iscsi_firmware manpage fix
PATCH 1/1 iscsi_firmware manpage fix
Seems iscsi_firmware means rd.iscsi.firmware=1, so the manpage should be wrong
Also add '-d' in parse-iscsi script since it's depracated.
Signed-off-by Dave Young <[email protected]>
--- dracut.cmdline.7.asc | 2 +- modules.d/95iscsi/parse-iscsiroot.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
dracut.cmdline.7.asc +1 -1
@@ -972,7 +972,7 @@ iscsi_in_username:: rd.iscsi.in.username iscsi_in_password:: rd.iscsi.in.password -iscsi_firmware:: rd.iscsi.firmware=0 +iscsi_firmware:: rd.iscsi.firmware=1 rd_NO_PLYMOUTH:: rd.plymouth=0
modules.d/95iscsi/parse-iscsiroot.sh +1 -1
@@ -20,7 +20,7 @@ if [ -z "$netroot" ]; then [ "${netroot%%:*}" = "iscsi" ] || unset netroot fi [ -z "$iscsiroot" ] && iscsiroot=$(getarg iscsiroot=) -[ -z "$iscsi_firmware" ] && getargbool 0 rd.iscsi.firmware -y iscsi_firmware && iscsi_firmware="1" +[ -z "$iscsi_firmware" ] && getargbool 0 rd.iscsi.firmware -d -y iscsi_firmware && iscsi_firmware="1" [ -n "$iscsiroot" ] && [ -n "$iscsi_firmware" ] && die "Mixing iscsiroot and iscsi_firmware is dangerous"
A message that is not in the archive (sent off-list or not yet received): 20141103034010.GA4811-4/[email protected]
Hi,
I had no chance to test the patch, just found the problem by reviewing code. So it definitely need your careful review.
Quoted 39 lines · Dave Young
Seems
iscsi_firmwaremeans rd.iscsi.firmware=1, so the manpage should be wrongAlso add '-d' in parse-iscsi script since it's depracated.
Signed-off-by Dave Young <[email protected]>--- dracut.cmdline.7.asc | 2 +- modules.d/95iscsi/parse-iscsiroot.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)dracut.cmdline.7.asc +1
-1@@ -972,7 +972,7 @@ iscsi_in_username:: rd.iscsi.in.username iscsi_in_password:: rd.iscsi.in.password -iscsi_firmware:: rd.iscsi.firmware=0 +iscsi_firmware:: rd.iscsi.firmware=1 rd_NO_PLYMOUTH:: rd.plymouth=0modules.d/95iscsi/parse-iscsiroot.sh +1
-2@@ -20,7 +20,7 @@ if [ -z "$netroot" ]; then [ "${netroot%%:*}" = "iscsi" ] || unset netroot fi [ -z "$iscsiroot" ] && iscsiroot=$(getarg iscsiroot=) -[ -z "$iscsi_firmware" ] && getargbool 0 rd.iscsi.firmware -y iscsi_firmware && iscsi_firmware="1" +[ -z "$iscsi_firmware" ] && getargbool 0 rd.iscsi.firmware -d -y iscsi_firmware && iscsi_firmware="1" [ -n "$iscsiroot" ] && [ -n "$iscsi_firmware" ] && die "Mixing iscsiroot and iscsi_firmware is dangerous" --To unsubscribe from this list: send the line "unsubscribe initramfs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html