Skip to contentSkip to conversation

ARM: imx: Explicitly select CONFIG_SPI

PATCH New Fabio Estevam 2 participants 5 messages Oct 29, 2014 – Nov 4, 2014

Subsystems (2)
Arm (32-bit) Arm i.MX and Layerscape
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 ARM: imx: Explicitly select CONFIG_SPI

From: Fabio Estevam <[email protected]>

Since 3.18-rc1 CONFIG_SPI is no longer automatically selected for imx_v4_v5_defconfig and imx_v6_v7_defconfig, so in order to keep the same behaviour as previous kernel versions and avoid regressions, let's explicitly select CONFIG_SPI.

Signed-off-by Fabio Estevam <[email protected]>

---
Shawn,

If possible, please apply this as a bug fix for 3.18.

 arch/arm/configs/imx_v4_v5_defconfig | 1 +
 arch/arm/configs/imx_v6_v7_defconfig | 1 +
 2 files changed, 2 insertions(+)
arch/arm/configs/imx_v4_v5_defconfig +1 -0
index e688741..e6b0007 100644
@@ -97,6 +97,7 @@ CONFIG_SERIAL_IMX_CONSOLE=y
 # CONFIG_HW_RANDOM is not set
 CONFIG_I2C_CHARDEV=y
 CONFIG_I2C_IMX=y
+CONFIG_SPI=y
 CONFIG_SPI_IMX=y
 CONFIG_SPI_SPIDEV=y
 CONFIG_GPIO_SYSFS=y
arch/arm/configs/imx_v6_v7_defconfig +1 -0
index 8fca6e2..6790f1b 100644
@@ -158,6 +158,7 @@ CONFIG_I2C_CHARDEV=y
 CONFIG_I2C_ALGOPCF=m
 CONFIG_I2C_ALGOPCA=m
 CONFIG_I2C_IMX=y
+CONFIG_SPI=y
 CONFIG_SPI_IMX=y
 CONFIG_GPIO_SYSFS=y
 CONFIG_GPIO_MC9S08DZ60=y
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 ARM: imx: Explicitly select CONFIG_SPI

Quoted 7 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Since 3.18-rc1 CONFIG_SPI is no longer automatically selected for imx_v4_v5_defconfig and imx_v6_v7_defconfig, so in order to keep the same behaviour as previous kernel versions and avoid regressions, let's explicitly select CONFIG_SPI.

Quoted 5 lines
Signed-off-by Fabio Estevam <[email protected]>

---
Shawn,

If possible, please apply this as a bug fix for 3.18.

Can you please mention the commit that introduced the regression in the commit log?

Shawn

author reviewer
#2 lore raw

PATCH 1/1 ARM: imx: Explicitly select CONFIG_SPI

Hi Shawn,

Quoted 8 lines · Shawn Guo
Quoted 7 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Since 3.18-rc1 CONFIG_SPI is no longer automatically selected for imx_v4_v5_defconfig and imx_v6_v7_defconfig, so in order to keep the same behaviour as previous kernel versions and avoid regressions, let's explicitly select CONFIG_SPI.

Quoted 8 lines
Quoted 5 lines
Signed-off-by Fabio Estevam <[email protected]>

---
Shawn,

If possible, please apply this as a bug fix for 3.18.

Can you please mention the commit that introduced the regression in the commit log?

The problem is that 'git bisect' did not produce a valid result for me. It says that:

commit cf377ad7d42c566356d79049536d9cb37499cb77
Merge: 212fe84 d8f0faa
Author: Linus Torvalds <[email protected]>
Date: Wed Oct 8 17:13:04 2014 -0400

Merge tag 'soc-for-linus' of
git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc

, is the first bad commit, but this does not look correct, so I was not able to really identify the commit that caused this regression.

Here is my procedure (starting at 3.18-rc1):

git bisect start
git bisect bad
git bisect good v3.17
make imx_v6_v7_defconfig
cat .config | grep CONFIG_SPI=y

Then I add "git bisect good or bad" depending on the output of the 'cat' command.

Any ideas?

#3 lore raw

PATCH 1/1 ARM: imx: Explicitly select CONFIG_SPI

Quoted 43 lines · Fabio Estevam

Hi Shawn,

Quoted 8 lines · Shawn Guo
Quoted 7 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Since 3.18-rc1 CONFIG_SPI is no longer automatically selected for imx_v4_v5_defconfig and imx_v6_v7_defconfig, so in order to keep the same behaviour as previous kernel versions and avoid regressions, let's explicitly select CONFIG_SPI.

Quoted 8 lines
Quoted 5 lines
Signed-off-by Fabio Estevam <[email protected]>

---
Shawn,

If possible, please apply this as a bug fix for 3.18.

Can you please mention the commit that introduced the regression in the commit log?

The problem is that 'git bisect' did not produce a valid result for me. It says that:

commit cf377ad7d42c566356d79049536d9cb37499cb77
Merge: 212fe84 d8f0faa
Author: Linus Torvalds <[email protected]>
Date: Wed Oct 8 17:13:04 2014 -0400

Merge tag 'soc-for-linus' of
git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc

, is the first bad commit, but this does not look correct, so I was not able to really identify the commit that caused this regression.

Here is my procedure (starting at 3.18-rc1):

git bisect start
git bisect bad
git bisect good v3.17
make imx_v6_v7_defconfig
cat .config | grep CONFIG_SPI=y

Quoted 4 lines

Then I add "git bisect good or bad" depending on the output of the 'cat' command.

Any ideas?

The CONFIG_SPI was removed by your commit 64546e9fe3a5 (ARM:
imx_v6_v7_defconfig updates), which cames from savedefconfig, I assume. That said, in the code base that your patch was generated, option CONFIG_SPI is redundant, But it's not the case on mainline.

Shawn

author reviewer
#4 lore raw

PATCH 1/1 ARM: imx: Explicitly select CONFIG_SPI

Quoted 4 lines · Shawn Guo

The CONFIG_SPI was removed by your commit 64546e9fe3a5 (ARM:
imx_v6_v7_defconfig updates), which cames from savedefconfig, I assume. That said, in the code base that your patch was generated, option CONFIG_SPI is redundant, But it's not the case on mainline.

Ops, sorry about that. That's correct. I have just sent v2 and pointed out the faulty commits.

Thanks