Skip to contentSkip to conversation

usb: yurex: fixed sparse warning of incorrect type

PATCH In review Sudip Mukherjee 1 participant 2 messages Oct 10, 2014 – Nov 3, 2014 USB

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usb: yurex: fixed sparse warning of incorrect type

fixed sparse warning of
1) incorrect type (different address spaces)
2) incorrect type in initializer

---
 drivers/usb/misc/yurex.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/usb/misc/yurex.c +4 -2
index c3a45da..343fa6f 100644
@@ -410,7 +410,8 @@ static int yurex_release(struct inode *inode, struct file *file)
 	return 0;
 }
 
-static ssize_t yurex_read(struct file *file, char *buffer, size_t count, loff_t *ppos)
+static ssize_t yurex_read(struct file *file, char __user *buffer, size_t count,
+			  loff_t *ppos)
 {
 	struct usb_yurex *dev;
 	int retval = 0;
@@ -444,7 +445,8 @@ exit:
 	return retval;
 }
 
-static ssize_t yurex_write(struct file *file, const char *user_buffer, size_t count, loff_t *ppos)
+static ssize_t yurex_write(struct file *file, const char __user *user_buffer,
+			   size_t count, loff_t *ppos)
 {
 	struct usb_yurex *dev;
 	int i, set = 0, retval = 0;
Signature · 1 line
1.8.1.2
#1 lore raw
Quoted 36 lines · Sudip Mukherjee

fixed sparse warning of
1) incorrect type (different address spaces)
2) incorrect type in initializer

---
 drivers/usb/misc/yurex.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/usb/misc/yurex.c +4 -2
index c3a45da..343fa6f 100644
@@ -410,7 +410,8 @@ static int yurex_release(struct inode *inode, struct file *file)
 	return 0;
 }
 
-static ssize_t yurex_read(struct file *file, char *buffer, size_t count, loff_t *ppos)
+static ssize_t yurex_read(struct file *file, char __user *buffer, size_t count,
+			  loff_t *ppos)
 {
 	struct usb_yurex *dev;
 	int retval = 0;
@@ -444,7 +445,8 @@ exit:
 	return retval;
 }
 
-static ssize_t yurex_write(struct file *file, const char *user_buffer, size_t count, loff_t *ppos)
+static ssize_t yurex_write(struct file *file, const char __user *user_buffer,
+			   size_t count, loff_t *ppos)
 {
 	struct usb_yurex *dev;
 	int i, set = 0, retval = 0;
Signature · 1 line
1.8.1.2

gentle ping

thanks
sudip