Skip to contentSkip to conversation

staging: bcm: vendorspecificextn: Fix coding style

PATCH New Sunil Shahu 3 participants 3 messages Nov 2, 2014 – Nov 3, 2014

lore
Share & tools
lore

Sunil Shahu

author
#0 lore raw

PATCH 1/1 staging: bcm: vendorspecificextn: Fix coding style

Hello,

I was going through kernel source and found out that I can work on staging area for fixes.

I have generated a patch for coding style fixes.

I have few questions about how do submit my patch and to whom.

1) Is it ok if I send it directly to Greg Kroah-Hartman <[email protected]>, who seems to be signing off all the patches in that directory as per git log.

2) What is the standard procedure to submit my patch after I have verified it. Whom do I send it? How do I get it review? How to get it merged in mainline?

Also, I am attaching my patch here.

Any suggestions on patch and answer to my queries will be great help.

Thanks,
Sunil.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-staging-bcm-vendorspecificextn-Fix-coding-style.patch
Type: text/x-patch
Size: 2943 bytes
Desc: not available
Url : http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20141102/f5b9237e/attachment.bin

#1 lore raw

PATCH 1/1 staging: bcm: vendorspecificextn: Fix coding style

Quoted 3 lines · Sunil Shahu

Hello,

I was going through kernel source and found out that I can work on staging area for fixes.

Hello, that's ok. Many people start there.

Quoted 5 lines

I have generated a patch for coding style fixes.

I have few questions about how do submit my patch and to whom.

1) Is it ok if I send it directly to Greg Kroah-Hartman <[email protected]>, who seems to be signing off all the patches in that directory as per git log.

Use scripts/get_maintainer.pl. It will tell you where to send your patch. Always cc a mailing list because kernel development happens in public. Also, limit your line text to 72 characters in your e-mail messages.

Quoted 1 line

2) What is the standard procedure to submit my patch after I have verified it. Whom do I send it? How do I get it review? How to get it merged in mainline?

There are various ways to test your patch but at least it must not break the build and also pass checkpatch.pl tests. If not, you should be able to defend against the errors/warnings/etc. it issues. It is not always right.

For the other questions: there is helpful documentation about submitting patches and about how kernel is developed in Documentation/development-process/ and also there is Documentation/SubmittingPatches.

For starters many people recommend doing the eudyptula challenge. Check it out if you haven't heard about it.

Hopefully this will be helpful,
Giedrius

#2 lore raw

PATCH 1/1 staging: bcm: vendorspecificextn: Fix coding style

In reply to Sunil Shahu
Quoted 6 lines · Sunil Shahu

Hello,

I was going through kernel source and found out that I can work on staging area for fixes.

I have generated a patch for coding style fixes.

Quoted 7 lines

I have few questions about how do submit my patch and to whom.

1) Is it ok if I send it directly to Greg Kroah-Hartman <[email protected]>, who seems to be signing off all the patches in that directory as per git log.

2) What is the standard procedure to submit my patch after I have verified it. Whom do I send it? How do I get it review? How to get it merged in mainline?

Also, I am attaching my patch here.

1) never send your patch as an MIME attachment. it should be always inline. this one came as an attachment.
2) this patch is not applying to next-20141103.
error: drivers/staging/bcm/vendorspecificextn.c: No such file or directory

thanks
sudip

Quoted 88 lines

Any suggestions on patch and answer to my queries will be great help.

Thanks,
Sunil.

From d09048ffe41531d691df9d90fe25e34ffc11c8f8 Mon Sep 17 00:00:00 2001
From: Sunil Shahu <[email protected]>
Date: Sun, 2 Nov 2014 19:37:15 +0530
Subject: [PATCH] staging: bcm: vendorspecificextn: Fix coding style

This fixes the coding style warnings of line over 80 characters.

Signed-off-by Sunil Shahu <[email protected]>
---
 drivers/staging/bcm/vendorspecificextn.c |   23 ++++++++++++++---------
 1 file changed, 14 insertions(+), 9 deletions(-)
drivers/staging/bcm/vendorspecificextn.c +14 -9
index d38a06f..797d21d 100644
@@ -11,7 +11,8 @@
  *		STATUS_SUCCESS/STATUS_FAILURE
  *
  */
-INT vendorextnGetSectionInfo(PVOID  pContext, struct bcm_flash2x_vendor_info *pVendorInfo)
+INT vendorextnGetSectionInfo(PVOID  pContext,
+			     struct bcm_flash2x_vendor_info *pVendorInfo)
 {
 	return STATUS_FAILURE;
 }

@@ -61,8 +62,9 @@ INT vendorextnExit(struct bcm_mini_adapter *Adapter)
  *		arg	-input parameter sent by vendor
  *
  * Returns:
- *		CONTINUE_COMMON_PATH in case it is not meant to be processed by vendor ioctls
- *		STATUS_SUCCESS/STATUS_FAILURE as per the IOCTL return value
+ *		CONTINUE_COMMON_PATH in case it is not meant to be processed by
+ *		vendor ioctls STATUS_SUCCESS/STATUS_FAILURE as per the IOCTL
+ *		return value
  */
 
 INT vendorextnIoctl(struct bcm_mini_adapter *Adapter, UINT cmd, ULONG arg)

@@ -88,8 +90,9 @@ INT vendorextnIoctl(struct bcm_mini_adapter *Adapter, UINT cmd, ULONG arg)
  *		STATUS_SUCCESS/STATUS_FAILURE
  */
 
-INT vendorextnReadSection(PVOID  pContext, PUCHAR pBuffer, enum bcm_flash2x_section_val SectionVal,
-			UINT offset, UINT numOfBytes)
+INT vendorextnReadSection(PVOID  pContext, PUCHAR pBuffer,
+			  enum bcm_flash2x_section_val SectionVal,
+			  UINT offset, UINT numOfBytes)
 {
 	return STATUS_FAILURE;
 }

@@ -112,8 +115,9 @@ INT vendorextnReadSection(PVOID  pContext, PUCHAR pBuffer, enum bcm_flash2x_sect
  * Returns:
  *		STATUS_SUCCESS/STATUS_FAILURE
  */
-INT vendorextnWriteSection(PVOID  pContext, PUCHAR pBuffer, enum bcm_flash2x_section_val SectionVal,
-			UINT offset, UINT numOfBytes, BOOLEAN bVerify)
+INT vendorextnWriteSection(PVOID  pContext, PUCHAR pBuffer,
+			   enum bcm_flash2x_section_val SectionVal,
+			   UINT offset, UINT numOfBytes, BOOLEAN bVerify)
 {
 	return STATUS_FAILURE;
 }

@@ -135,8 +139,9 @@ INT vendorextnWriteSection(PVOID  pContext, PUCHAR pBuffer, enum bcm_flash2x_sec
  * Returns:
  *		STATUS_SUCCESS/STATUS_FAILURE
  */
-INT vendorextnWriteSectionWithoutErase(PVOID  pContext, PUCHAR pBuffer, enum bcm_flash2x_section_val SectionVal,
-			UINT offset, UINT numOfBytes)
+INT vendorextnWriteSectionWithoutErase(PVOID  pContext, PUCHAR pBuffer,
+				       enum bcm_flash2x_section_val SectionVal,
+				       UINT offset, UINT numOfBytes)
 {
 	return STATUS_FAILURE;
 }
Signature · 7 lines
1.7.9.5


_______________________________________________
Kernelnewbies mailing list
Kernelnewbies at kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies