Skip to contentSkip to conversation

bnx2fc: check IS_ERR() instead of NULL

PATCH Applied Dan Carpenter 3 participants 3 messages Nov 4, 2014 – Nov 6, 2014

Subsystems (3)
SCSI Kernel janitors Broadcom BNX2FC 10 gigabit FCoE driver
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/2 bnx2fc: check IS_ERR() instead of NULL

The bnx2fc_if_create() function returns NULL on failure, it never returns an error pointer.

Signed-off-by Dan Carpenter <[email protected]>
drivers/scsi/bnx2fc/bnx2fc_fcoe.c +1 -1
index 79e5c94..dfed4be 100644
@@ -1081,7 +1081,7 @@ static int bnx2fc_vport_create(struct fc_vport *vport, bool disabled)
 	mutex_unlock(&bnx2fc_dev_lock);
 	rtnl_unlock();
 
-	if (IS_ERR(vn_port)) {
+	if (!vn_port) {
 		printk(KERN_ERR PFX "bnx2fc_vport_create (%s) failed\n",
 			netdev->name);
 		return -EIO;
Acked-by on v1 1/2
#1 lore raw

Looks ok.

Acked-by Chad Dupuis <[email protected]>
Quoted 19 lines · Dan Carpenter

The bnx2fc_if_create() function returns NULL on failure, it never returns an error pointer.

Signed-off-by Dan Carpenter <[email protected]>
drivers/scsi/bnx2fc/bnx2fc_fcoe.c +1 -1
index 79e5c94..dfed4be 100644
@@ -1081,7 +1081,7 @@ static int bnx2fc_vport_create(struct fc_vport *vport, bool disabled)
 	mutex_unlock(&bnx2fc_dev_lock);
 	rtnl_unlock();
 
-	if (IS_ERR(vn_port)) {
+	if (!vn_port) {
 		printk(KERN_ERR PFX "bnx2fc_vport_create (%s) failed\n",
 			netdev->name);
 		return -EIO;